NullPointerException with plugin with Implemented Vault

Hello there I'm bassically trying to make plugin just which gives you money when you kill a monster pretty simple uhh ? But I just want to use Vault with this couse I'll probably make some othere stuffs with Vualt. So here is my code :

Code:java

package me.Al3xFx;
 
import net.milkbowl.vault.economy.Economy;
import net.milkbowl.vault.economy.EconomyResponse;
import net.milkbowl.vault.permission.Permission;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.EntityDeathEvent;
import org.bukkit.plugin.RegisteredServiceProvider;
import org.bukkit.plugin.java.JavaPlugin;
 
 
public class KillMoney extends JavaPlugin implements Listener{
    public static Economy econ = null;
    public static Permission perms = null;
 
    public void onEnable(){
        getLogger().info("Plugin has been enabled");
        Bukkit.getServer().getPluginManager().registerEvents(this, this);
    }
 
    public void onDisable(){
    }
 
 
    private boolean setupPermissions() {
        RegisteredServiceProvider<Permission> rsp = getServer().getServicesManager().getRegistration(Permission.class);
        perms = rsp.getProvider();
        return perms != null;
    }
 
 
 
    private boolean setupEconomy() {
        if (getServer().getPluginManager().getPlugin("Vault") == null) {
            return false;
        }
        RegisteredServiceProvider<Economy> rsp = getServer().getServicesManager().getRegistration(Economy.class);
        if (rsp == null) {
            return false;
        }
        econ = rsp.getProvider();
        return econ != null;
    }
 
 
 
    @EventHandler
    public void onEntityDeath(EntityDeathEvent e ){
        Player p = e.getEntity().getKiller();
 
        if(!(e.getEntity().getKiller() instanceof Player)){
            p.sendMessage("fuck off");
        }
        else{
 
 
            p.sendMessage(ChatColor.AQUA + "You Killed a: " + ChatColor.GREEN + e.getEntity().getType());
            EconomyResponse r = econ.depositPlayer(p.getName(), 10.00);
            if(r.transactionSuccess()) {
                p.sendMessage(ChatColor.GREEN + "You have been awaraded with $10.00 for killing" + e.getEntity().getType());
            } else {
                p.sendMessage(ChatColor.DARK_RED + "ECONOMY" + ChatColor.RED + " Is not working propiertly please contact an admin right away !");
            }
 
        }
 
 
 
    }
 
}
 

So i got Vault imported .
My plugin.yml is fine .
Where is my problem ?
My log :

Code:

[18:33:42 ERROR]: Could not pass event EntityDeathEvent to AbsoluteZero v1.0
org.bukkit.event.EventException
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.ja
va:294) ~[craftbukkit-1.7.9-R0.2.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks
]
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.jav
a:62) ~[craftbukkit-1.7.9-R0.2.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
        at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.j
ava:501) [craftbukkit-1.7.9-R0.2.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks
]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.j
ava:486) [craftbukkit-1.7.9-R0.2.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks
]
        at org.bukkit.craftbukkit.v1_7_R3.event.CraftEventFactory.callEntityDeat
hEvent(CraftEventFactory.java:353) [craftbukkit-1.7.9-R0.2.jar:git-Bukkit-1.7.9-
R0.1-10-g8688bd4-b3092jnks]
        at net.minecraft.server.v1_7_R3.EntityLiving.die(EntityLiving.java:799)
[craftbukkit-1.7.9-R0.2.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
        at net.minecraft.server.v1_7_R3.EntityLiving.damageEntity(EntityLiving.j
ava:734) [craftbukkit-1.7.9-R0.2.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks
]
        at net.minecraft.server.v1_7_R3.EntityAnimal.damageEntity(SourceFile:145
) [craftbukkit-1.7.9-R0.2.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
        at net.minecraft.server.v1_7_R3.EntityHuman.attack(EntityHuman.java:925)
[craftbukkit-1.7.9-R0.2.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
        at net.minecraft.server.v1_7_R3.PlayerConnection.a(PlayerConnection.java
:1106) [craftbukkit-1.7.9-R0.2.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
        at net.minecraft.server.v1_7_R3.PacketPlayInUseEntity.a(SourceFile:55) [
craftbukkit-1.7.9-R0.2.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
        at net.minecraft.server.v1_7_R3.PacketPlayInUseEntity.handle(SourceFile:
10) [craftbukkit-1.7.9-R0.2.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
        at net.minecraft.server.v1_7_R3.NetworkManager.a(NetworkManager.java:157
) [craftbukkit-1.7.9-R0.2.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
        at net.minecraft.server.v1_7_R3.ServerConnection.c(SourceFile:134) [craf
tbukkit-1.7.9-R0.2.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
        at net.minecraft.server.v1_7_R3.MinecraftServer.v(MinecraftServer.java:6
67) [craftbukkit-1.7.9-R0.2.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
        at net.minecraft.server.v1_7_R3.DedicatedServer.v(DedicatedServer.java:2
60) [craftbukkit-1.7.9-R0.2.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
        at net.minecraft.server.v1_7_R3.MinecraftServer.u(MinecraftServer.java:5
58) [craftbukkit-1.7.9-R0.2.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
        at net.minecraft.server.v1_7_R3.MinecraftServer.run(MinecraftServer.java
:469) [craftbukkit-1.7.9-R0.2.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
        at net.minecraft.server.v1_7_R3.ThreadServerApplication.run(SourceFile:6
28) [craftbukkit-1.7.9-R0.2.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
Caused by: java.lang.NullPointerException
        at me.Al3xFx.KillMoney.onEntityDeath(KillMoney.java:65) ~[?:?]
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0
_20]
        at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0
_20]
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1
.8.0_20]
        at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_20]
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.ja
va:292) ~[craftbukkit-1.7.9-R0.2.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks
]
        ... 18 more
>

 

AlexHystra

Your casting doesn't make sense. First check, then cast.
Secondly, you're generating a nullPointer exception in 'onEntityDeath'. Im pretty sure that's because sometimes there killer is null.

Code:java

@EventHandler
public void onEntityDeath(EntityDeathEvent e){
  if(e.getEntity().getKiller() instanceof Player){
        Player p = (Player) e.getEntity();
        p.sendMessage("You killed an "+e.getEntity().getType());
  }
}

Secondly, read your first check

Code:java

 if(!(e.getEntity().getKiller() instanceof Player)){
    p.sendMessage("Swear Word");
}

You're basically doing this.
If the entity is NOT killed by an player, send a message to that player.

 

AlexHystra You do know that getKiller() either returns a Player or null, right? Check for null instead of instanceof.
Unica whilst correct about the check-cast order, ^

 

fireblast709
What about a creeper / skeleton killing a entity ?

 

Unica the return type of the method is Player. Thus, if the player was killed by another entity, it will just be null (because that Player is nonexistent)

 

The killer is null.

 

Alright guys I've just did some null checks and the problem is not from the cast. The problem becomes from my :

Code:java

EconomyResponse r = econ.depositPlayer(p.getName(), 10.00);

It's mentioned in the report.

Actually i found out something else look it seems that the killer is null because if I use this :

Code:java

@EventHandler
    public void onEntityDeath(EntityDeathEvent e ){
        Player p = e.getEntity().getKiller();
 
    if(!(e.getEntity().getKiller() != null)){
 
 
            p.sendMessage(ChatColor.AQUA + "You Killed a: " + ChatColor.GREEN + e.getEntity().getType());
            EconomyResponse r = econ.depositPlayer(p.getName(), 10.00);
            if(r.transactionSuccess()) {
                p.sendMessage(ChatColor.GREEN + "You have been awaraded with $10.00 for killing" + e.getEntity().getType());
            } else {
                p.sendMessage(ChatColor.DARK_RED + "ECONOMY" + ChatColor.RED + " Is not working propiertly please contact an admin right away !");
            }
 
        }else{
            Bukkit.broadcastMessage("test");
            }
 
 
 
    }

The server returns test .
So what should I do and where is my mistake ?

fireblast709
Also if I try to do something super simple like :

Code:java

public boolean onCommand(CommandSender sender, Command cmd, String cmdLabel, String[] args)
{
if(cmdLabel.equalsIgnoreCase("pari")){
Player player = (Player)sender;
econ.depositPlayer(player, 10);
}
return false;
 
 
 
}

It again gives my NullPointerException on line

Code:java

 econ.depositPlayer(player, 10); 

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

AlexHystra

 

AlexHystra As teej107 is trying to point out, you are never really setting up Economy or Permissions, and then you expect them to work...

 

AlexHystra In addition to the post above:

• use cmd.getName() instead of cmdLabel, for alias support.
• Check if sender instanceof Player before casting to Player.