Solved Add Items and Stop When Inventory is Full

I want to add mushroom soup to a player's inventory until the inventory is full, where I want to stop giving them the mushroom soup. Is there an effective or efficient way to stop the code upon the full inventory check? I believe the check is something like this:

Code:java

Player player = (Player) sender;
PlayerInventory pi = p.getInventory;
if(pi.firstEmpty() == -1) {
//run code here
}

I don't know, so help would be greatly appreciated! Thanks!

Code:

Code:java

        } if(cmd.getName().equalsIgnoreCase("refill")) {
            Player p = (Player) sender;
            PlayerInventory pi = p.getInventory();
            pi.addItem(new ItemStack(Material.MUSHROOM_SOUP, 1));
            pi.addItem(new ItemStack(Material.MUSHROOM_SOUP, 1));
            pi.addItem(new ItemStack(Material.MUSHROOM_SOUP, 1));
            pi.addItem(new ItemStack(Material.MUSHROOM_SOUP, 1));
            pi.addItem(new ItemStack(Material.MUSHROOM_SOUP, 1));
            pi.addItem(new ItemStack(Material.MUSHROOM_SOUP, 1));
            pi.addItem(new ItemStack(Material.MUSHROOM_SOUP, 1));
            pi.addItem(new ItemStack(Material.MUSHROOM_SOUP, 1));
            pi.addItem(new ItemStack(Material.MUSHROOM_SOUP, 1));
            pi.addItem(new ItemStack(Material.MUSHROOM_SOUP, 1));
            pi.addItem(new ItemStack(Material.MUSHROOM_SOUP, 1));
            pi.addItem(new ItemStack(Material.MUSHROOM_SOUP, 1));
            pi.addItem(new ItemStack(Material.MUSHROOM_SOUP, 1));
            pi.addItem(new ItemStack(Material.MUSHROOM_SOUP, 1));
            pi.addItem(new ItemStack(Material.MUSHROOM_SOUP, 1));
            pi.addItem(new ItemStack(Material.MUSHROOM_SOUP, 1));
            pi.addItem(new ItemStack(Material.MUSHROOM_SOUP, 1));
            pi.addItem(new ItemStack(Material.MUSHROOM_SOUP, 1));
            pi.addItem(new ItemStack(Material.MUSHROOM_SOUP, 1));
            pi.addItem(new ItemStack(Material.MUSHROOM_SOUP, 1));
            pi.addItem(new ItemStack(Material.MUSHROOM_SOUP, 1));
            pi.addItem(new ItemStack(Material.MUSHROOM_SOUP, 1));
            pi.addItem(new ItemStack(Material.MUSHROOM_SOUP, 1));
            pi.addItem(new ItemStack(Material.MUSHROOM_SOUP, 1));
            pi.addItem(new ItemStack(Material.MUSHROOM_SOUP, 1));
            pi.addItem(new ItemStack(Material.MUSHROOM_SOUP, 1));
            pi.addItem(new ItemStack(Material.MUSHROOM_SOUP, 1));
            pi.addItem(new ItemStack(Material.MUSHROOM_SOUP, 1));
            pi.addItem(new ItemStack(Material.MUSHROOM_SOUP, 1));
            pi.addItem(new ItemStack(Material.MUSHROOM_SOUP, 1));
            pi.addItem(new ItemStack(Material.MUSHROOM_SOUP, 1));
            pi.addItem(new ItemStack(Material.MUSHROOM_SOUP, 1));
            pi.addItem(new ItemStack(Material.MUSHROOM_SOUP, 1));
            pi.addItem(new ItemStack(Material.MUSHROOM_SOUP, 1));
            pi.addItem(new ItemStack(Material.MUSHROOM_SOUP, 1));
            p.sendMessage(ChatColor.AQUA + "Your " + ChatColor.YELLOW + "mushroom soup " + ChatColor.AQUA + "has been delivered!");
        }

 

Compressions The best way to do this is to use a while loop

Code:java

 
Player p = (Player) sender;
PlayerInventory pi = p.getInventory();
 
while (!(pi.firstEmpty() == -1)) {
     pi.addItem(new ItemStack(Material.MUSHROOM_SOUP, 1));
}
 
p.sendMessage(ChatColor.AQUA + "Your " + ChatColor.YELLOW + "mushroom soup " + ChatColor.AQUA + "has been delivered!");
 

 

MrSparkzz Will the while loop replace all of my addItem lines?

 

Compressions Yes, it'll take the place of those lines, it'll simplify your code and make it look more professional.

 

MrSparkzz Thanks! Solved. Just realized that Bukkit cancels inventory overflow, but, as you stated,

MrSparkzz How would you use a while loop to check if you have less than or equal to a certain Material?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

I know you can check for a direct value, but I don't know how you would implement less than or greater than into the pi.contains() method. I'm gonna do some testing and I'll get back to you as soon as possible.

 

MrSparkzz Awesome! Thanks

 

Compressions I'm not sure if this is what you were looking for, but this, after every loop, will check to see if the amount of Mushroom Stew is a certain amount. if it is, then it will exit the loop and continue the code.

Code:java

 
while (!(pi.firstEmpty() == -1)) {
      pi.addItem(new ItemStack(Material.MUSHROOM_SOUP, 1));
 
      if (pi.contains(Material.MUSHROOM_SOUP, 10)) {
            break;
      }
}
 
p.sendMessage(ChatColor.AQUA + "Your " + ChatColor.YELLOW + "mushroom soup " + ChatColor.AQUA + "has been delivered!");
 

 

MrSparkzz I was using it for another command, where it adds 8 mushroom soup, or it has a while loop that counts until it adds 8 mushroom soup.

 

Compressions are you saying, it will add mushroom soup until their inventory has 8 in it? Or?

 

MrSparkzz It disregards how many mushroom soup the inventory has. What it needs to check is to add mushroom soup until the check has added 8 mushroom soup.

 

Compressions I solved it.

Code:java

 
int count = 0;
do {
     pi.addItem(new ItemStack(Material.MUSHROOM_SOUP, 1));
     count++;
     if (pi.firstEmpty() == -1) break;
} while (count < 8);
 

This is a do loop. Every time it runs it will add one to the "count" variable. There's a while check at the end, which will check if "count" is less than 8. If it is then it will exit the loop. There's also a check in side the loop which will check to see if there is any room left. If there isn't then it will break the loop.

 

Thanks!