Solved Am i blind?

Hello,

A friend of mine is trying to learn java, So i am helping her a little bit.
But for a unkown reason it just doesnt work.

Code:java

package me.stacy.main;
 
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
 
 
public class main extends JavaPlugin {
 
    public boolean onCommand(CommandSender s, Command cmd, String Label, String[] args) {
        if (s instanceof Player) {
            Player p = (Player) s;
            if (cmd.getName().equalsIgnoreCase("kitty")) {
                p.sendMessage(ChatColor.BLUE + "jij gebruikte /kitty");
            }
        }
        return false;
    }
}

Code:

name: main
 
version: 1
author: Stacy
 
description: >
            StacyTestPlugin
main: me.stacy.main.main
 
commands:
  kitty:
    description: random message!

Error message: 'Unkown Command'.

 

MinecraftChicken Show main class.

 

bwfcwalshy this is the main class i think xD

You have to extends CommandExecutor I think

 

bennie3211 You need to implement it and also register it in onEnable.

 

Since when is that?

 

That's only for Bukkit Events, onCommand(...) however isn't an actual Event, so main doesn't have to extend Listener.
Ref: http://wiki.bukkit.org/Plugin_Tutorial#The_onCommand.28.29_Method

bennie3211: Check in the console whether the plugin successfully loads without errors.

 

JWhy It still does and you still have to register it.

MinecraftChicken Make an onEnable and add that.

Code:java

getCommand("kitty").setExecutor(this);

 

JWhy don't you still have to do something like Bukkit.getCommand("kitty").setCommandExecutor(this); ?

 

Techy4198 Yes you do, but not Bukkit because it is the main class.

 

bwfcwalshy Yep,

Code:

getCommand("commandname").setExecutor(this);

and 'implements CommandExecutor' after 'extends JavaPlugin'. Then no other changes.

 

bwfcwalshy i did exactly as you said but it still doesnt work:

Code:java

package me.stacy.main;
 
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
 
 
public class main extends JavaPlugin implements CommandExecutor {
 
    @Override
    public void onEnable() {
        getCommand("kitty").setExecutor(this);
    }
 
    @Override
    public void onDisable() {
    }
 
    public boolean onCommand(CommandSender s, Command cmd, String Label, String[] args) {
        if (s instanceof Player) {
            Player p = (Player) s;
            if (cmd.getName().equalsIgnoreCase("kitty")) {
                p.sendMessage(ChatColor.BLUE + "jij gebruikte /kitty");
            }
        }
        return false;
    }
}

 

MinecraftChicken Any stacktraces?

 

I actually am blind.. i did read the console for error logs but i didnt find 1 earlier... now i start reading again and it appears the plugin.yml is wrong... Can somebody pls tel me how to do it?

Plugin.yml:

Code:

name: main
 
version: 1
author: Stacy
 
description: >
            StacyTestPlugin
main: me.stacy.main.main
 
commands:
  kitty:
    description: random message!

 

This should work , just make sure to remove the "<any words in here>" and replace it with the correct details
also remove the (case sensitive) haha

Code:

name: <plugin name>
version: 1
author: Stacy
description: <description>
main: <path> (case sensitive)
commands:
  kitty:
    description: <description>
    usage: /<command>

 

Kassestral MinecraftChicken The usage is not needed.

 

bwfcwalshy

it's not mandatory, but it is nice to have it there either way

 

thx it worked

 

No problem

 

Just gonna add this: You don't need to implement CommandExecutor since JavaPlugin is in the main class.
Although CommandExecutor may work, just using JavaPlugin is good practice. I only use CommandExecutor when there are commands in other classes.

 

I have Never, ever implemented CommandExecutor and used getCommand("commandname").setExecutor(this);

 

"friend" LOL

 

Jaaakee224

Exactly what he said

 

ChipDev In that case you have Never, ever set up a command where the basic setup is guaranteed 100% to work in any future Bukkit version.