Solved Amount Of Online Players On Sign Need Help (bug)

Hello, so i wanted to make a simple plugin for my test server. The plugins function is that is records the amount of players online and put them onto a sign and here is where im stuck: so it working fine it records players online and puts them on the sign but when there are only 2 players online and one leave the sign still shows 2 players out of max and i dont know how to fix it here is my code.

Code:java

package me.johny9020.playerSign;
 
import java.util.logging.Logger;
 
import org.bukkit.Bukkit;
import org.bukkit.Location;
import org.bukkit.World;
import org.bukkit.block.Sign;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.SignChangeEvent;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.event.player.PlayerQuitEvent;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin implements Listener{
 
public final Logger logger = Logger.getLogger("Minecraft");
 
@Override
public void onEnable() {
saveDefaultConfig();
this.logger.info("Was Enabled!");
Bukkit.getServer().getPluginManager().registerEvents(this, this);
}
 
@Override
public void onDisable() {
 
}
 
public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args) {
if(cmd.getName().equalsIgnoreCase("oplayers")) {
sender.sendMessage("Total People Online: " + Bukkit.getServer().getOnlinePlayers().length + "/" + Bukkit.getServer().getMaxPlayers());
}
return true;
}
 
@EventHandler
public void onPlayerJoin(PlayerJoinEvent e) {
 
Player p = e.getPlayer();
 
World w = Bukkit.getServer().getWorld(this.getConfig().getString("OPlayers.World"));
double x = this.getConfig().getDouble("OPlayers.X");
double y = this.getConfig().getDouble("OPlayers.Y");
double z = this.getConfig().getDouble("OPlayers.Z");
Location OPlayers = new Location(w, x, y, z);
 
if(p.getWorld().getBlockAt(OPlayers) != null) {
Sign sign = (Sign) p.getWorld().getBlockAt(OPlayers).getState();
sign.setLine(0, Bukkit.getServer().getOnlinePlayers().length + "/" + Bukkit.getServer().getMaxPlayers());
sign.update(true);
sign.update();
}
 
}
 
@EventHandler
public void onPlayerLeave(PlayerQuitEvent e) {
 
Player p = e.getPlayer();
 
World w = Bukkit.getServer().getWorld(this.getConfig().getString("OPlayers.World"));
double x = this.getConfig().getDouble("OPlayers.X");
double y = this.getConfig().getDouble("OPlayers.Y");
double z = this.getConfig().getDouble("OPlayers.Z");
Location OPlayers = new Location(w, x, y, z);
 
if(p.getWorld().getBlockAt(OPlayers) != null) {
Sign sign = (Sign) p.getWorld().getBlockAt(OPlayers).getState();
sign.setLine(0, Bukkit.getServer().getOnlinePlayers().length + "/" + Bukkit.getServer().getMaxPlayers());
sign.update();
 
}
 
}
 
@EventHandler
public void onSignChange(SignChangeEvent e) {
if(e.getLine(0).equalsIgnoreCase("[oplayers]")) {
this.getConfig().set("OPlayers.X", e.getBlock().getLocation().getX());
this.getConfig().set("OPlayers.Y", e.getBlock().getLocation().getY());
this.getConfig().set("OPlayers.Z", e.getBlock().getLocation().getZ());
this.getConfig().set("OPlayers.World", e.getBlock().getLocation().getWorld().getName());
this.saveConfig();
e.setLine(0, Bukkit.getServer().getOnlinePlayers().length + "/" + Bukkit.getServer().getMaxPlayers());
}
}
 
}
 

please tell me what im doing wrong thanks

 

Hi,

I think when executing the player leave method, the leaving player is still counted in the Bukkit.getOnlinePlayers(). If that's the case, just do:

 

Thanks Ill Try It Out

Thank You, you fixed my problem!

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Johny9020 You're very welcome!

-If you ever need my help again, just PM ME or create a new topic!