Solved Broadcast message + play sound when specific player joins

I'm going to be running a server where one of my admins owns a black market where you can find rare items for cheap, but you can only buy from the shop when he's online. When he joins the server, I want a message to be broadcasted, and I want the wither spawning noise to play. I'm very new with coding, and I want either a plugin like this, or a way to make one. I've researched a bit about this plugin, and I've managed to come up with this code:

Code:java

package net.malicepvp.run;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Sound;
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.entity.Player;
import org.bukkit.event.Event;
import org.bukkit.event.EventHandler;
import org.bukkit.event.EventPriority;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerLoginEvent;
 
public class listeners implements Listener {
    @EventHandler (priority = EventPriority.HIGH)
    public void onPlayerLogin(PlayerLoginEvent event) {
        if(event.getPlayer().getName().equals("Skeleton_o_Dhuum")){
            Bukkit.getServer().broadcastMessage(ChatColor.AQUA + "[" + ChatColor.GRAY + "???" + ChatColor.AQUA + "] " + ChatColor.BLACK + "He has arrived...");
            for(Player p : Bukkit.getOnlinePlayers()){
                p.playSound(p.getLocation(), Sound.WITHER_DEATH, 1, 0);
                }
                    }
 
    }
}

When my friend, Skeleton_o_Dhuum, who will be the owner of the market, joins the server, nothing happens. I probably committed a very obvious error, but like I said, I'm new to this stuff.

 

You need to have your listener class registered in your main class file.
Needs to be in onEnable()

Code:

getServer().getPluginManager().registerEvents(new listeners(this), this);

and you need to register your plugin main in listener:

Code:

MainClassName plugin; <---Needs to be plugin
 
public listeners(MainClassName instance){
plugin = instance;
}

 

Well, i thinks this is gonna work.

Code:java

        if(p.getName().equalsIgnoreCase("LordManegane"))
    Bukkit.getServer().broadcastMessage(ChatColor.AQUA+"["+ChatColor.GRAY + "???"+ ChatColor.AQUA+"]"+ChatColor.BLACK+ "He has arrived...");
for(Player player : Bukkit.getOnlinePlayers()){
player.playSound(player.getLocation(), Sound.WITHER_DEATH, 10, 1);
}

If works please notify me

 

"p" cannot be resolved in "if(p.getName()..."

there's a red line under "(new listeners(this),"
and i get a bunch of errors on this

Code:java

public listeners(RUN instance){
plugin == instance()); }

which are these

Code:

Multiple markers at this line
- Syntax error on token(s), misplaced construct(s)
- Syntax error, insert "enum Identifier" to complete
EnumHeader

Also, RUN (Main class) isn't recognized, even after I import it.

I tried this, and there's no errors.. let's see what happens on the server
(He's not online, I'm just going to use an alt)

*Edit: same thing, didn't work. And yes I did change "Skeleton_o_Dhuum" to my alt's name for the test, I'm not that stupid xD

Oh and if it helps any, this is my main class file, RUN

Code:

package net.malicepvp.run;
 
import org.bukkit.plugin.java.JavaPlugin;
 
public final class RUN  extends JavaPlugin {
 
    @Override
    public void onEnable(){
        getLogger().info("RUN has been enabled, noob!");
    }
   
    @Override
    public void onDisable() {
        getLogger().info("RUN has been disabled, noob!");
    }
}

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

4non
Put this in your listnener exactly as you see it.

Code:

RUN plugin;
 
public listeners(RUN instance){
plugin = instance;
}

Then put this in your main class onEnable();

Code:

getServer().getPluginManager().registerEvents(new listeners(this), this);

EDIT: I tried this code and it worked fine for me. Although I didnt see the message others did. If you want to make it so you can see it make a delayed task that runs when you login so it gives you time to connect.

 

RUN.java :

Code:java

package net.malicepvp.run;
 
import org.bukkit.plugin.java.JavaPlugin;
 
public final class RUN  extends JavaPlugin {
 
    @Override
    public void onEnable(){
        getLogger().info("RUN has been enabled, noob!");
        getServer().getPluginManager().registerEvents(new listeners(this), this);
    }
 
    @Override
    public void onDisable() {
        getLogger().info("RUN has been disabled, noob!");
    }
}

listeners.java

Code:java

package net.malicepvp.run;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Sound;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.EventPriority;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerLoginEvent;
 
public class listeners implements Listener {
    RUN plugin;
 
    public listeners(RUN instance){
    plugin = instance;
    }
    @EventHandler (priority = EventPriority.HIGH)
    public void onPlayerLogin(PlayerLoginEvent event) {
        if(event.getPlayer().getName().equals("athbi2012")){
            Bukkit.getServer().broadcastMessage(ChatColor.AQUA + "[" + ChatColor.GRAY + "???" + ChatColor.AQUA + "] " + ChatColor.BLACK + "He has arrived...");
            for(Player p : Bukkit.getOnlinePlayers()){
                p.playSound(p.getLocation(), Sound.WITHER_DEATH, 1, 0);
                }
                    }
 
    }
}

I don't hear a noise, no message displays, and the console shows nothing. What am I doing wrong?

 

can you do equalsignorecase? instead of equals? This works just fine for me and thats the only difference.

 

Nothing is working. I'm so confused at what the problem could be... everything you're telling me makes perfect sense. Whenever my friend (Skeleton_o_Dhuum) joins the server, nothing happens. It doesn't display the join message because of another plugin I have, but that shouldn't affect this plugin... could you upload the file on mediafire or something?

*Edit: I think it might be something with the way I'm packaging it into a .jar. Are there any settings that I need to have enabled for it to load in minecraft?

*Edit #2: Actually, famas, I don't think I need anything else.. thanks for helping me! I'm probably just doing something really stupid and obvious that I didn't include in the post.. I'm just going to try again later. It might be a problem with 1.6...

 

4non
did you remember to register the events in the main class?

 

My code worked for iFamasssxD so I think everything should be working.. it might be a problem with my system, or maybe I screwed up some option in the exporting to a .jar thing. It should be working, but it's not for some reason, and I don't think the problem is in the code.

And yes, I did.

 

iFamasssxD It's working now, I just put my plugin.yml in the wrong place. Thanks for all the help