Bukkit.getServer().getOnlinePlayers() error

I'm trying to create a thirst plugin, and the person I'm developing it for wanted a wave thirst system, so it would subtract thirst from all online players at once. I attempted to use this code:

Code:java

package io.github.Tudedude100.SurvivalThirst;
 
import java.io.File;
import java.io.IOException;
import java.io.InputStream;
import java.lang.reflect.InvocationTargetException;
import java.util.Collection;
import java.util.logging.Level;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.GameMode;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.configuration.file.FileConfiguration;
import org.bukkit.configuration.file.YamlConfiguration;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.event.player.PlayerQuitEvent;
import org.bukkit.plugin.Plugin;
import org.bukkit.plugin.PluginManager;
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.scoreboard.DisplaySlot;
import org.bukkit.scoreboard.Objective;
import org.bukkit.scoreboard.Score;
import org.bukkit.scoreboard.Scoreboard;
import org.bukkit.scoreboard.ScoreboardManager;
import org.bukkit.scoreboard.Team;
 
public class Main extends JavaPlugin implements Listener{
 
public boolean bossBarEnabled;
 
public int thirst;
 
ScoreboardManager manager = Bukkit.getScoreboardManager();
Scoreboard board = manager.getNewScoreboard();
Objective objective = board.registerNewObjective("Thirst", "dummy");
 
public void onEnable(){
PluginManager pm = getServer().getPluginManager();
pm.registerEvents(this, this);
this.saveDefaultConfig();
Plugin BarAPI = pm.getPlugin("BarAPI");
if(BarAPI == null){
getLogger().severe("BarAPI not found! Disabling the boss bar visual display setting!");
getConfig().set("bossBarEnabled", false);
getLogger().info("Boss bar visual display setting disabled.");
}else{
getLogger().info("BarAPI detected, enabling boss bar visual display setting.");
getConfig().set("bossBarEnabled", true);
}
 
taskID = Bukkit.getScheduler().scheduleSyncRepeatingTask(this, new Runnable() {
@Override
public void run() {
doThirst();
}
}, 18 * 20L, 18 * 20L);
 
objective.setDisplayName("Thirst");
objective.setDisplaySlot(DisplaySlot.SIDEBAR);
reloadCustomConfig();
}
 
private FileConfiguration customConfig = null;
private File customConfigFile = null;
 
int display = 1;
 
public void reloadCustomConfig() {
if (customConfigFile == null) {
customConfigFile = new File(getDataFolder(), "thirstPlayers.yml");
}
customConfig = YamlConfiguration.loadConfiguration(customConfigFile);
 
// Look for defaults in the jar
InputStream defConfigStream = this.getResource("thirstPlayers.yml");
if (defConfigStream != null) {
@SuppressWarnings("deprecation")
YamlConfiguration defConfig = YamlConfiguration.loadConfiguration(defConfigStream);
customConfig.setDefaults(defConfig);
}
}
 
public FileConfiguration getCustomConfig() {
if(customConfig == null){
reloadCustomConfig();
}
return customConfig;
}
 
public void saveCustomConfig(){
if(customConfig == null || customConfigFile == null){
return;
}
try{
getCustomConfig().save(customConfigFile);
}
catch(IOException e){
e.printStackTrace();
}
}
 
public void doThirst(){
for(Player p : Bukkit.getOnlinePlayers()){
String pNames = p.getName();
int oThirst = getConfig().getInt("Thirst." + pNames + ".Thirst");
if(p.getGameMode().equals(GameMode.SURVIVAL)){
int thirst = (oThirst - 1);
getCustomConfig().set("Thirst." + pNames + ".Thirst", thirst);
saveCustomConfig();
}
//TODO - REMOVE DEBUG CODE
Bukkit.getServer().broadcast("DEBUG - WAVE OCCURED", "DEBUG - WAVE OCCURED");
}
}
 
public void displayVisualSystems(Player p, int display){
switch(display){
case 1:
p.setScoreboard(board);
Score score = objective.getScore(Bukkit.getOfflinePlayer(ChatColor.GREEN + "Thirst"));
score.setScore(getCustomConfig().getInt("Players." + p.getName() + ".Thirst"));
break;
case 2:
//chat notifications
break;
case 3:
//boss bar
break;
}
}
 
public void switchVisualSystem(Player p, int newDisplay, int oldDisplay){
//Display tracking vars:
// - Scoreboard: 1
// - Chat notifications: 2
// - BossBar (IF ENABLED): 3
int displayVar = newDisplay + (oldDisplay*10);
switch(displayVar){
case 11:
p.sendMessage("You cannot switch to a display you're already on!");
break;
case 12:
p.sendMessage("Switchingd");
//TODO - ADD SWITCHING CODE
break;
case 13:
p.sendMessage("Switching");
//TODO - ADD SWITCHING CODE
break;
case 21:
p.sendMessage("Switching");
//TODO - ADD SWITCHING CODE
break;
case 22:
p.sendMessage("You cannot switch to a display you're already on!");
break;
case 23:
p.sendMessage("Switching");
//TODO - ADD SWITCHING CODE
break;
case 31:
p.sendMessage("Switching");
//TODO - ADD SWITCHING CODE
break;
case 32:
p.sendMessage("Switching");
//TODO - ADD SWITCHING CODE
break;
case 33:
p.sendMessage("You cannot switch to a display you're already on!");
break;
}
}
 
@Override
public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
if(cmd.getName().equalsIgnoreCase("thirst")){
Player p = (Player) sender;
int cThirst = getCustomConfig().getInt("Players." + p.getName()+ ".Thirst");
sender.sendMessage("Your thirst is: " + cThirst);
displayVisualSystems(p, 1);
return true;
}
return false;
}
 
private Integer taskID;
 
@EventHandler
public void onPlayerJoin(PlayerJoinEvent e){
//TODO- SETUP TASK SCHEDULER, .YML PLACEMENT, .YML CHECKS, AND DISPLAY CODE
final Player p = e.getPlayer();
if(!(getCustomConfig().isSet("Players." + p.getName() + ".Thirst"))){
getCustomConfig().set("Players." + p.getName() + ".Thirst", 100);
saveCustomConfig();
}
taskID = Bukkit.getScheduler().scheduleSyncRepeatingTask(this, new Runnable() {
@Override
public void run() {
int pThirst = getCustomConfig().getInt("Players." + p.getName()+ ".Thirst");
if(p.getGameMode().equals(GameMode.SURVIVAL) || p.getGameMode().equals(GameMode.ADVENTURE)){
thirst = pThirst-1;
getCustomConfig().set("Players." + p.getName() + ".Thirst", thirst);
saveCustomConfig();
}else{
thirst = pThirst;
saveCustomConfig();
}
 
}
}, 18 * 20L, 18 * 20L);
getCustomConfig().set("TaskIDs." + p.getName() + ".TaskID", taskID);
saveCustomConfig();
}
 
public void onPlayerLeave(PlayerQuitEvent e){
Player p = e.getPlayer();
taskID = getConfig().getInt("TaskIDs."+p.getName()+".taskID");
if(!(taskID == null)){
Bukkit.getScheduler().cancelTask(taskID);
getCustomConfig().set("TaskIDs." + p.getName() + ".taskID", "Offline");
saveConfig();
}
}
 
}
 

And it came up with this error.

Code:java

 
[15:39:53] [Server thread/WARN]: [SurvivalThirst] Task #29 for SurvivalThirst v0.0 [INDEV] generated an exception
java.lang.NoSuchMethodError: org.bukkit.Bukkit.getOnlinePlayers()Ljava/util/Collection;
at io.github.Tudedude100.SurvivalThirst.Main.doThirst(Main.java:108) ~[?:?]
at io.github.Tudedude100.SurvivalThirst.Main$1.run(Main.java:59) ~[?:?]
at org.bukkit.craftbukkit.v1_7_R3.scheduler.CraftTask.run(CraftTask.java:53) ~[craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
at org.bukkit.craftbukkit.v1_7_R3.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:345) [craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
at net.minecraft.server.v1_7_R3.MinecraftServer.v(MinecraftServer.java:600) [craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
at net.minecraft.server.v1_7_R3.DedicatedServer.v(DedicatedServer.java:260) [craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
at net.minecraft.server.v1_7_R3.MinecraftServer.u(MinecraftServer.java:558) [craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
at net.minecraft.server.v1_7_R3.MinecraftServer.run(MinecraftServer.java:469) [craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
at net.minecraft.server.v1_7_R3.ThreadServerApplication.run(SourceFile:628) [craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
 

It appears to think that the getOnlinePlayers() method doesn't exist, however, Eclipse and the JavaDocs seem to disagree. Any ideas of how to fix this, or possibly alternate methods?
PS: I do realize much of this code is unfinished. It is to a point where it shouldn't conflict with anything else though, and I've mostly started working on the arbitrary configuration part and the thirst wave part.

Quick edit: I do realize the method in the code is Bukkit.getOnlinePlayers() not Bukkit.getServer().getOnlinePlayers(), but I've tried it both ways, and it gives the same error :I

 

Tudedude
In one of the latest updates, the return type of getOnlinePlayers() was changed. This will cause that error.

 

Gnat008
I just remembered reading about that... is there any way to achieve what I'm trying to do with an alternate method, or something like that?

 

Tudedude
You could just change how your plugin gets the data to use the other return type instead. It depends on who is going to use the plugin, and what their environment is like (version of CraftBukkit using the new method or not).

*EDIT: For full compatibility, I suppose you could check to see what the method returns, and go from there.

 

Gnat008 Ty for bringing up the new method or not. I realized I was building off of the 1.7.10 dev version, instead of the 1.7.9 beta. In 1.7.10, it's the stupid Collection<? extends Player> and in 1.7.9, it's a nice, easy to use Player[] array. Thank you so much for your help, and I'll get back when I have a solution, so if the general public has a problem like this, they have a solution to help them on their way.

 

Tudedude
Good luck, and glad to help!

 

Tudedude If you want it to be compatible with all versions here is a simple work around...

Code:java

public static List<Player> getOnlinePlayers() {
    List<Player> list = Lists.newArrayList();
    for (World world : Bukkit.getWorlds()) {
        list.addAll(world.getPlayers());
    }
    return Collections.unmodifiableList(list);
}

 

Goblom Oh, ty. I've already made a workaround for the current version, but when it needs to be updated, I'll use your method. Thanks!

And to the general public, my workaround was, with Bukkit 1.7.9 R0.2, getting the array of players, using a for loop to count through and select all the players, and then do stuff to them with the method. For my thirst plugin, I did the following:

Code:java

-snip-
public void onEnable(){
taskID = Bukkit.getScheduler().scheduleSyncRepeatingTask(this, new Runnable() {
@Override
public void run() {
doThirst();
}
}, 18 * 20L, 18 * 20L);
}
-snip-
public void doThirst(){
Player[] p = Bukkit.getOnlinePlayers();
for(int i=0; i<p.length; i++){
Player tp = p[I];[/I]
if(!(getServer().getPlayer(tp.getUniqueId()) == null)){
if(!(tp.hasPermission("survivalthirst.bypass"))){
if(tp.getGameMode() == GameMode.SURVIVAL){
int oThirst = getCustomConfig().getInt("Players." + tp.getName() + ".Thirst");
int thirst = oThirst - 1;
getCustomConfig().set("Players." + tp.getName() + ".Thirst", thirst);
tp.sendMessage("DEBUG - WAVE OCCURED");
saveCustomConfig();
}
}
}
}
}

Edit: For the record, my code is formatted, but for some reason it removed the formatting...
¯\_(ツ)_/¯

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

compile vs proper cbukkit version.
read update logs
???
profit

 

Wasn't it
Bukkit.getOnlinePlayers()
instead of
Bukkit.getServer().getOnlinePlayers()?....