Cancelling bukkit runnable in other method

Hello i want to cancel my bukkit runable in the updateInventory(final Player p) method in my inventoryCloseEvent this is my code:

Code:java

package net.voxelvoid.themepark.inventory;
 
import java.util.Arrays;
import net.voxelvoid.themepark.ThemePark;
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.inventory.InventoryClickEvent;
import org.bukkit.event.inventory.InventoryCloseEvent;
import org.bukkit.event.inventory.InventoryOpenEvent;
import org.bukkit.inventory.Inventory;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.ItemMeta;
import org.bukkit.scheduler.BukkitRunnable;
 
/**
*
* @author Tim
*/
public class InventoryShows implements Listener {
 
    private static ThemePark instance;
    private static InventoryMain main;
 
    public InventoryShows(ThemePark instance) {
        this.instance = instance;
        this.main = new InventoryMain(instance);
    }
 
    private static final ItemStack pegasusWaterShowClosed = createItem(ChatColor.GOLD + "Pegasus", Material.STAINED_CLAY, 1, (short) 14, ChatColor.GRAY + "Click to go to the", ChatColor.GRAY + "amazing Pegasus watershow!");
    private static final ItemStack pegasusWaterShowStarted = createItem(ChatColor.GOLD + "Pegasus", Material.STAINED_CLAY, 1, (short) 4, ChatColor.GRAY + "Click to go to the", ChatColor.GRAY + "amazing Pegasus watershow!");
    private static final ItemStack pegasusWaterShowOpend = createItem(ChatColor.GOLD + "Pegasus", Material.STAINED_CLAY, 1, (short) 5, ChatColor.GRAY + "Click to go to the", ChatColor.GRAY + "amazing Pegasus watershow!");
    private static final ItemStack VoxelVoidFireworkShowClosed = createItem(ChatColor.GOLD + "VoxelVoid firework", Material.STAINED_CLAY, 1, (short) 14, ChatColor.GRAY + "Click to go to the", ChatColor.GRAY + "amazing Bonfire firework show!");
    private static final ItemStack VoxelVoidFireworkShowStarted = createItem(ChatColor.GOLD + "VoxelVoid firework", Material.STAINED_CLAY, 1, (short) 4, ChatColor.GRAY + "Click to go to the", ChatColor.GRAY + "amazing Bonfire firework show!");
    private static final ItemStack VoxelVoidFireworkShowOpend = createItem(ChatColor.GOLD + "VoxelVoid firework", Material.STAINED_CLAY, 1, (short) 5, ChatColor.GRAY + "Click to go to the", ChatColor.GRAY + "amazing Bonfire firework show!");
    private static final ItemStack magicCircleTheaterShowClosed = createItem(ChatColor.GOLD + "The magic circle", Material.STAINED_CLAY, 1, (short) 14, ChatColor.GRAY + "Click to go to the", ChatColor.GRAY + "amazing magic circle theatershow!");
    private static final ItemStack magicCircleTheaterShowStarted = createItem(ChatColor.GOLD + "The magic circle", Material.STAINED_CLAY, 4, (short) 1, ChatColor.GRAY + "Click to go to the", ChatColor.GRAY + "amazing magic circle theatershow!");
    private static final ItemStack magicCircleTheaterShowOpend = createItem(ChatColor.GOLD + "The magic circle", Material.STAINED_CLAY, 5, (short) 1, ChatColor.GRAY + "Click to go to the", ChatColor.GRAY + "amazing magic circle theatershow!");
    private static final ItemStack juegoCircusClosed = createItem(ChatColor.GOLD + "Circus Juego", Material.STAINED_CLAY, 1, (short) 14, ChatColor.GRAY + "Click to go to the", ChatColor.GRAY + "amazing Juego circus!");
    private static final ItemStack juegoCircusStarted = createItem(ChatColor.GOLD + "Circus Juego", Material.STAINED_CLAY, 1, (short) 4, ChatColor.GRAY + "Click to go to the", ChatColor.GRAY + "amazing Juego circus!");
    private static final ItemStack juegoCircusOpend = createItem(ChatColor.GOLD + "Circus Juego", Material.STAINED_CLAY, 1, (short) 5, ChatColor.GRAY + "Click to go to the", ChatColor.GRAY + "amazing Juego circus!");
    private static final ItemStack destinyConcertClosed = createItem(ChatColor.GOLD + "Concert Destiny", Material.STAINED_CLAY, 1, (short) 14, ChatColor.GRAY + "Click to go to the", ChatColor.GRAY + "amazing concert Destiny");
    private static final ItemStack destinyConcertStarted = createItem(ChatColor.GOLD + "Concert Destiny", Material.STAINED_CLAY, 1, (short) 4, ChatColor.GRAY + "Click to go to the", ChatColor.GRAY + "amazing concert Destiny");
    private static final ItemStack destinyConcertOpend = createItem(ChatColor.GOLD + "Concert Destiny", Material.STAINED_CLAY, 1, (short) 5, ChatColor.GRAY + "Click to go to the", ChatColor.GRAY + "amazing concert Destiny");
    private static final ItemStack backItem = createItem(ChatColor.GOLD + "Main menu", Material.ARROW, 1, (short) 0, ChatColor.GRAY + "Click to go back to the main menu.");
 
    public static Inventory inventory_shows = Bukkit.createInventory(null, 9, ChatColor.BLACK + "" + ChatColor.BOLD + "            Shows.");
 
    private static ItemStack createItem(String name, Material mat, int amount, short data, String... lore) {
        ItemStack item = new ItemStack(mat, amount, data);
        ItemMeta meta = item.getItemMeta();
        meta.setDisplayName(name);
        meta.setLore(Arrays.asList(lore));
        item.setItemMeta(meta);
        return item;
    }
 
    public void updateInventory(final Player p) {
        Bukkit.broadcastMessage("update");
        new BukkitRunnable() {
            @Override
            public void run() {
                Bukkit.broadcastMessage("update!");
                final Inventory inv = p.getOpenInventory().getTopInventory();
                for (ItemStack i : inv.getContents()) {
                    if (i.hasItemMeta()) {
                        if (i.getItemMeta().hasDisplayName()) {
                            String s = i.getItemMeta().getDisplayName();
                            if (s.contains(ChatColor.GOLD + "Pegasus")) {
                                String a = instance.showsAndRides.getString("shows.pegasus");
                                if (a.equals("opend")) {
                                    inv.setItem(0, pegasusWaterShowOpend);
                                    p.updateInventory();
                                } else if (a.equals("started")) {
                                    inv.setItem(0, pegasusWaterShowStarted);
                                    p.updateInventory();
                                } else if (a.equals("closed")) {
                                    inv.setItem(0, pegasusWaterShowClosed);
                                    p.updateInventory();
                                } else {
                                    inv.setItem(0, pegasusWaterShowClosed);
                                    p.updateInventory();
                                }
                            } else if (s.contains(ChatColor.GOLD + "VoxelVoid firework")) {
                                String a = instance.showsAndRides.getString("shows.voxelvoid firework");
                                if (a.equals("opend")) {
                                    inv.setItem(1, VoxelVoidFireworkShowOpend);
                                    p.updateInventory();
                                } else if (a.equals("started")) {
                                    inv.setItem(1, VoxelVoidFireworkShowStarted);
                                    p.updateInventory();
                                } else if (a.equals("closed")) {
                                    inv.setItem(1, VoxelVoidFireworkShowClosed);
                                    p.updateInventory();
                                } else {
                                    inv.setItem(1, VoxelVoidFireworkShowClosed);
                                    p.updateInventory();
                                }
                            } else if (s.contains(ChatColor.GOLD + "The magig circle")) {
                                String a = instance.showsAndRides.getString("shows.magic circle");
                                if (a.equals("opend")) {
                                    inv.setItem(2, magicCircleTheaterShowOpend);
                                    p.updateInventory();
                                } else if (a.equals("started")) {
                                    inv.setItem(2, magicCircleTheaterShowStarted);
                                    p.updateInventory();
                                } else if (a.equals("closed")) {
                                    inv.setItem(2, magicCircleTheaterShowClosed);
                                    p.updateInventory();
                                } else {
                                    inv.setItem(2, magicCircleTheaterShowClosed);
                                    p.updateInventory();
                                }
                            } else if (s.contains(ChatColor.GOLD + "Circus Juego")) {
                                String a = instance.showsAndRides.getString("shows.circus juego");
                                if (a.equals("opend")) {
                                    inv.setItem(3, juegoCircusOpend);
                                    p.updateInventory();
                                } else if (a.equals("started")) {
                                    inv.setItem(3, juegoCircusStarted);
                                    p.updateInventory();
                                } else if (a.equals("closed")) {
                                    inv.setItem(3, juegoCircusClosed);
                                    p.updateInventory();
                                } else {
                                    inv.setItem(3, juegoCircusClosed);
                                    p.updateInventory();
                                }
                            } else if (s.contains(ChatColor.GOLD + "Concert Destiny")) {
                                String a = instance.showsAndRides.getString("shows.concert destiny");
                                if (a.equals("opend")) {
                                    inv.setItem(4, destinyConcertOpend);
                                    p.updateInventory();
                                } else if (a.equals("started")) {
                                    inv.setItem(4, destinyConcertStarted);
                                    p.updateInventory();
                                } else if (a.equals("closed")) {
                                    inv.setItem(4, destinyConcertClosed);
                                    p.updateInventory();
                                } else {
                                    inv.setItem(4, destinyConcertClosed);
                                    p.updateInventory();
                                }
                            }
                        }
                    }
                }
            }
        }.runTaskTimer(instance, 20L, 50L);
    }
 
    @EventHandler
    public void onClose(InventoryCloseEvent e) {
 
        if (e.getInventory().getName().equals(inventory_shows.getName())) {
            e.getInventory().clear();
        } else {
            return;
        }
    }
 
    @EventHandler
    public void onOpen(InventoryOpenEvent e) {
        updateInventory((Player) e.getPlayer());
    }
 
    public static void loadInventory(final Player p) {
        final Inventory inv = Bukkit.createInventory(null, 9, ChatColor.BLACK + "" + ChatColor.BOLD + "            Shows.");
        p.openInventory(inv);
 
        inv.setItem(8, pegasusWaterShowClosed);
 
        new BukkitRunnable() {
            @Override
            public void run() {
                inv.setItem(7, pegasusWaterShowClosed);
                inv.setItem(8, VoxelVoidFireworkShowClosed);
            }
        }.runTaskLater(instance, 2L);
 
        new BukkitRunnable() {
            @Override
            public void run() {
                inv.setItem(6, pegasusWaterShowClosed);
                inv.setItem(7, VoxelVoidFireworkShowClosed);
                inv.setItem(8, magicCircleTheaterShowClosed);
            }
        }.runTaskLater(instance, 4L);
 
        new BukkitRunnable() {
            @Override
            public void run() {
                inv.setItem(5, pegasusWaterShowClosed);
                inv.setItem(6, VoxelVoidFireworkShowClosed);
                inv.setItem(7, magicCircleTheaterShowClosed);
                inv.setItem(8, juegoCircusClosed);
            }
        }.runTaskLater(instance, 6L);
 
        new BukkitRunnable() {
            @Override
            public void run() {
                inv.setItem(4, pegasusWaterShowClosed);
                inv.setItem(5, VoxelVoidFireworkShowClosed);
                inv.setItem(6, magicCircleTheaterShowClosed);
                inv.setItem(7, juegoCircusClosed);
                inv.setItem(8, destinyConcertClosed);
            }
        }.runTaskLater(instance, 8L);
 
        new BukkitRunnable() {
            @Override
            public void run() {
                inv.setItem(3, pegasusWaterShowClosed);
                inv.setItem(4, VoxelVoidFireworkShowClosed);
                inv.setItem(5, magicCircleTheaterShowClosed);
                inv.setItem(6, juegoCircusClosed);
                inv.setItem(7, destinyConcertClosed);
                inv.setItem(8, backItem);
            }
        }.runTaskLater(instance, 10L);
 
        new BukkitRunnable() {
            @Override
            public void run() {
                inv.setItem(2, pegasusWaterShowClosed);
                inv.setItem(3, VoxelVoidFireworkShowClosed);
                inv.setItem(4, magicCircleTheaterShowClosed);
                inv.setItem(5, juegoCircusClosed);
                inv.setItem(7, null);
                inv.setItem(6, destinyConcertClosed);
            }
        }.runTaskLater(instance, 12L);
 
        new BukkitRunnable() {
            @Override
            public void run() {
                inv.setItem(1, pegasusWaterShowClosed);
                inv.setItem(2, VoxelVoidFireworkShowClosed);
                inv.setItem(3, magicCircleTheaterShowClosed);
                inv.setItem(4, juegoCircusClosed);
                inv.setItem(6, null);
                inv.setItem(5, destinyConcertClosed);
            }
        }.runTaskLater(instance, 14L);
 
        new BukkitRunnable() {
            @Override
            public void run() {
                inv.setItem(0, pegasusWaterShowClosed);
                inv.setItem(1, VoxelVoidFireworkShowClosed);
                inv.setItem(2, magicCircleTheaterShowClosed);
                inv.setItem(3, juegoCircusClosed);
                inv.setItem(5, null);
                inv.setItem(4, destinyConcertClosed);
            }
        }.runTaskLater(instance, 16L);
    }
 
    @EventHandler
    public void onClick(InventoryClickEvent e) {
        Player p = (Player) e.getWhoClicked();
        if (e.getInventory().getName().equals(inventory_shows.getName())) {
            if (e.getCurrentItem() != null && !e.getCurrentItem().getType().equals(Material.AIR)) {
                if (e.getCurrentItem().hasItemMeta()) {
                    if (e.getCurrentItem().getItemMeta().hasDisplayName()) {
                        if (e.getCurrentItem().getItemMeta().getDisplayName().equals(backItem.getItemMeta().getDisplayName())) {
                            e.setCancelled(true);
                            p.closeInventory();
                            main.loadInventory(p);
                        } else if (e.getCurrentItem().getItemMeta().getDisplayName().equals(pegasusWaterShowClosed.getItemMeta().getDisplayName())) {
                            e.setCancelled(true);
                            p.closeInventory();
                            //command
                        } else if (e.getCurrentItem().getItemMeta().getDisplayName().equals(VoxelVoidFireworkShowClosed.getItemMeta().getDisplayName())) {
                            e.setCancelled(true);
                            p.closeInventory();
                            //command
                        } else if (e.getCurrentItem().getItemMeta().getDisplayName().equals(magicCircleTheaterShowClosed.getItemMeta().getDisplayName())) {
                            e.setCancelled(true);
                            p.closeInventory();
                            //command
                        } else if (e.getCurrentItem().getItemMeta().getDisplayName().equals(juegoCircusClosed.getItemMeta().getDisplayName())) {
                            e.setCancelled(true);
                            p.closeInventory();
                            //command
                        } else if (e.getCurrentItem().getItemMeta().getDisplayName().equals(destinyConcertClosed.getItemMeta().getDisplayName())) {
                            e.setCancelled(true);
                            p.closeInventory();
                            //command
                        } else {
                            e.setCancelled(true);
                        }
                    } else {
                        return;
                    }
                } else {
                    return;
                }
            } else {
                return;
            }
        } else {
            return;
        }
    }
}
 

 

Dmrtje

Why is everything static? I legitimately flinched trying to read that code. Go back and learn what Object Oriented design means before you try and write in a language that is as object oriented as Java.

As for your issue, you have to obtain an instance of the runnable and invoke cancel(), or obtain it's task id when you schedule it and ask the scheduler to cancel it with cancel(int).

 

Dmrtje Use constructors to pass the runnable to your other class. Also do what mythbusterma said because that is a lot of static.

 

My hair is standing up from all that static .
Once you follow mythbusterma and Skionz advice (I highly suggest you do, you clearly don't know what static is meant for)
To cancel a BukkitRunnable, all you have to do is have an instance of the BukkitRunnable and then call http://jd.bukkit.org/rb/apidocs/org/bukkit/scheduler/BukkitRunnable.html#cancel() on it.

 

teej107 Skionz mythbusterma I know where static is for it is for getting something without a instance and this is just a preview later ill change the most from static to not static. And how do i obtain an instance from the runnable i'm kinda new to runnables?

 

Dmrtje

The same way you obtain the instance of any other class.

 

mythbusterma But a runnalbe is not a method itself its a method inside of a method.

I know how to obtain an instance from a class but i don't get how i obtain the instance of the runnable.

 

No, the Runnable is the object. run() is the method inside the Runnable. When you create a straight up Runnable, you are doing what you would call an anonymous class. There are no such thing as methods inside other methods.

 

teej107 okay thanks for the information but i still don't get how to cancel the runnable

 

Dmrtje Bukkit.getScheduler().cancelTask(int)? Use a constructor to pass it to another class.

 

Skionz i want it in the same class but the problem is for everyone that opens the GUI a new schedular starts since everyone has a custom GUI but i only want to cancel the schedular for the menu of that player

 

Dmrtje Use the same way.

 

Skionz ehm i don't get it i mean i need a taskID to cancel it outside the run method right? but how do i obtain the taskID since it is different for everyone

 

Dmrtje Use a Map that saves the Player and the id (Integer)

 

Skionz thanks gonna try it!
do you know how to see if a player has my custom inventory opend cause player.getOpendInventory does not return my custom inventory

 

Dmrtje It should. Try comparing the names.

 

Skionz i already did but it gives me something weird like container.crafting

Skionz do you know why?

<Edit by mrCookieSlime: Merged Posts. Please dont double post. There is an Edit-Button right next to the Date.>

 

Dmrtje That is probably the type. Use Inventory#getName()

 

there is only inventory.getTitle() or i need to do inventory.getTopInventory.getName() but that does return container.crafting too

EDIT:
forgot to tahg you Skionz

 

Dmrtje http://jd.bukkit.org/rb/doxygen/d3/...entory.html#afd574513babad56d95c6944231e5856e
What is "inventory?"

 

if i do e.getInventory from the InventoryCloseEvent its an inventory but if i do p.getOpendInventory its an inventoryView

EDIT:
Forgot to tahg you again (facepalm) Skionz

 

Skionz do you know why r somebody that knows it?