Changing BarAPI message

So. If you read my post yesterday. I was asking how to repeat an action every couple of seconds. After i got that working. I began having issues with actually changing the message. So i tried this but with BarAPI i dont think there is an easy way to get the current message that is being displayed. Here is what i tried.

Code:java

public void initBar() {
        BukkitScheduler scheduler = Bukkit.getServer().getScheduler();
        scheduler.scheduleSyncRepeatingTask(this, new Runnable() {
            @Override
            public void run() {
                for(final Player players : Bukkit.getOnlinePlayers()) {
                    BarAPI.setMessage("Remember to /vote");
                    if(BarAPI.getMessage(players) == "Remember to /vote") {
                        BarAPI.setMessage("2nd Message");
                    }
 
                    if (BarAPI.getMessage(players) == "2nd Message") {
                        BarAPI.setMessage("Remember to /vote");
                    }
                }
            }
        }, 0L, 20L);
    }

How and what would be the best way of doing this?

 

ImPhantom Use:

Code:java

 
BarAPI.getMessage(players).eqauls("<message>")
 

 

Jozeth
It still stays "Remember to /vote" and doesnt change.

 

I know it would, I was just suggesting a better way of seeing what a message equals.

 

Jozeth
Oh. Haha. Well thanks for the help. Ill try and work this out. If any others wish to help, tahg me.

 

ImPhantom
Why are you looping over all the players and calling the setMessage method that does not take in a player? Not sure if you knew this but calling the BarAPI.setMessage(String message) loops through all the players already on the server and sets their message to the message passed.

MCForger
If you wanted to make it so it only set it for the player you have in your loop pass the player object as an argument before the message.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

ImPhantom
"BarAPI.setMessage(Player player, String message)

Set a message for the player. It will remain there until the player logs off or another plugin overrides it.
BarAPI.setMessage(Player player, String message, float percent)

Same as above except you can set the % of the health bar. 100 shows the entire health bar, 50 shows half the health bar and so on.
BarAPI.setMessage(final Player player, String message, int seconds)

Sets a timed message for the player. It will remain until the timer runs out. The health automatically reduces based on how long the timer is."

- http://dev.bukkit.org/bukkit-plugins/bar-api/

You're setting the message wrong...

Edit:

Code:java

BarAPI.setMessage(players, "Remember to /vote");
BarAPI.setMessage(players, "2nd Message");
 

To be honest you could just do:

Code:java

    public void initBar() {
        BukkitScheduler scheduler = Bukkit.getServer().getScheduler();
        scheduler.scheduleSyncRepeatingTask(this, new Runnable() {
            @Override
            public void run() {
                for(final Player players : Bukkit.getOnlinePlayers()) {
                    BarAPI.setMessage(players, "Remember to /vote", 2);
                    if(BarAPI.getMessage(players).equals("Remember to /vote")) {
                        BarAPI.setMessage(players, "2nd Message", 2);
                    }
 
                    if (BarAPI.getMessage(players).equals("2nd Message")) {
                        BarAPI.setMessage(players, "3rd Message", 2);
                    }
                }
            }
        }, 0L, 7*20L);
    }

Because you're repeating it every second and you are checking if it equals a message then it checks again and gives you back the original message.

Code:java

    public void initBar() {
        BukkitScheduler scheduler = Bukkit.getServer().getScheduler();
        scheduler.scheduleSyncRepeatingTask(this, new Runnable() {
            @Override
            public void run() {
                for(final Player players : Bukkit.getOnlinePlayers()) {
                    BarAPI.setMessage(players, "Remember to /vote");
                    if(BarAPI.getMessage(players).equals("Remember to /vote")) {
                        BarAPI.setMessage(players, "2nd Message");
                    }
 
                    if (BarAPI.getMessage(players).equals("2nd Message")) {
                        BarAPI.setMessage("Remember to /vote");
                    }
                }
            }
        }, 0L, 20L);
    }

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Put continue statements after each setMessage so it doesn't check and loop back to the original message. Also, don't use a plural noun in the loop. It's misleading because it implies that the variable represents every player at once instead of each in sequence.

 

Garris0n Jozeth MCForger
Okay. Would it be easier to just iterate through a List<String> that contains all of the strings instead of having to to the if statement stuff?

 

Yes.