CheckInventory issue.

When I mine and get the blocks even though there is still space it sends a message saying its full, and when it is full it also still sends it.

Current code:

Code:java

 public static boolean inventoryCheck(Player player) {
boolean isEmpty = true;
for (ItemStack item : player.getInventory().getContents()) {
if(item != null) {
isEmpty = false;
}
}
if(isEmpty == false) {
player.sendMessage(ChatColor.RED + "" + ChatColor.BOLD + "Your inventory is full!!");
}
return isEmpty;
}
}
 

What happens:

http://prntscr.com/4odmk6

 

Your code isn't checking wether your inventory is full it's checking wether it has atleast a single item in it, eventhough there may be space left, if you have any items in your inventory your code's going to fire and say Your inventory is full! Change the variable isEmpty to isFull and make it true. Then when you loop, change if statement to if(item == null) { isFull = false; }

Don't check wether you have items in your inventory, but check if you have any space, because if you have items in your inventory it doesn't mean it's full, it can though, but if you check if there's space, and there's no space then that means your inventory IS full. It's just a matter of logic.

To tidy up:

Code:java

public static boolean inventoryCheck(Player player) {
boolean isFull = true;
for (ItemStack item : player.getInventory().getContents()) {
if(item == null) {
isFull = false;
}
}
if(isFull == true) {
player.sendMessage(ChatColor.RED + "" + ChatColor.BOLD + "Your inventory is full!!");
}
return isEmpty;
}
}

Regards
augustas656

 

augustas656 Checking it. I will edit this post with the results.

EDIT: Ok works great, thanks!

 

I've had a quick search on google and if you want to find out wether there's any possible items to add to an itemstack eventhough the inventory is full check: this bukkit forums thread, so basically let's say your inventory is full of dirt but there's one stack that has 32 items, so half a stack and some more can fit, that thread may help you with this. It's better to have a quick search on the forums or google if you haven't on a problem before asking, unless you're sure.

Regards
augustas656

 

augustas656 Can you help with my other issue? http://forums.bukkit.org/threads/another-issue.312679/

 

I'll reply to your problem in your other thread.