Could someone troubleshoot this for me?

Im really not sure why this isnt working.
Im trying to make it so when a player already has a quest, they cannot activate another one.

Code:java

    @SuppressWarnings("deprecation")
    @EventHandler(priority = EventPriority.HIGHEST)
    public void onBlockClick(PlayerInteractEvent event){
        Player player = event.getPlayer();
        if(event.getAction() == Action.RIGHT_CLICK_BLOCK){
            Block block = event.getClickedBlock();
            if(block.getType() == Material.STONE){
                String quest = "bread";
                String current = "bread";
                if (this.getConfig().get(player.getName() + ".currentquest") == current){
                    player.sendMessage(ChatColor.RED + "You already have an active quest");
                } else if (this.getConfig().get(player.getName() + ".currentquest") == current) {
                    player.sendMessage(ChatColor.DARK_AQUA + "New quest started!");
                    player.sendMessage(ChatColor.AQUA + "Deliver this bread to the bakery");
                    player.getInventory().addItem(new ItemStack(Material.BREAD, 3));
                    player.updateInventory();
                    this.getConfig().get(player.getName() + ".currentquest", quest);
                    saveConfig();
                }
                saveConfig();
            }
        }
    }
 
    @EventHandler(priority = EventPriority.HIGHEST)
    public void onQuestFinish(PlayerInteractEvent event){
        Player player = event.getPlayer();
        if(event.getAction() == Action.RIGHT_CLICK_BLOCK){
            Block block = event.getClickedBlock();
            if(block.getType() == Material.GOLD_BLOCK){
                if (this.getConfig().get(player.getName() + ".currentquest") == "bread"){
                    player.sendMessage(ChatColor.RED + "You did it!");
                    this.getConfig().get(player.getName() + ".currentquest", "none");
                    saveConfig();
                } else if (this.getConfig().get(player.getName() + ".currentquest") == "none") {
                    player.sendMessage("That quest is nut fur u!");
                }
            }
        }
    }

 

So why is line 10 and 12 the same condition?

 

Yep, why's line 10 and 12 are the same?

 

zDylann so true. lol

 

xJeremyCx Oh, didnt see that there lol
I changed some things around and now I got this;

Code:java

 @SuppressWarnings("deprecation")
@EventHandler(priority = EventPriority.HIGHEST)
public void onBlockClick(PlayerInteractEvent event){
Player player = event.getPlayer();
if(event.getAction() == Action.RIGHT_CLICK_BLOCK){
Block block = event.getClickedBlock();
if(block.getType() == Material.STONE){
String none = "none";
String bread = "bread";
if (this.getConfig().get(player.getName() + ".currentquest") == bread){
player.sendMessage(ChatColor.RED + "You already have an active quest");
} else if (this.getConfig().get(player.getName() + ".currentquest") == none) {
player.sendMessage(ChatColor.DARK_AQUA + "New quest started!");
player.sendMessage(ChatColor.AQUA + "Deliver this bread to the bakery");
player.getInventory().addItem(new ItemStack(Material.BREAD, 3));
player.updateInventory();
this.getConfig().get(player.getName() + ".currentquest", bread);
saveConfig();
}
saveConfig();
}
}
}
 
@EventHandler(priority = EventPriority.HIGHEST)
public void onQuestFinish(PlayerInteractEvent event){
Player player = event.getPlayer();
if(event.getAction() == Action.RIGHT_CLICK_BLOCK){
Block block = event.getClickedBlock();
if(block.getType() == Material.GOLD_BLOCK){
if (this.getConfig().get(player.getName() + ".currentquest") == "bread"){
player.sendMessage(ChatColor.RED + "You did it!");
this.getConfig().get(player.getName() + ".currentquest", "none");
saveConfig();
} else if (this.getConfig().get(player.getName() + ".currentquest") == "none") {
player.sendMessage("That quest is nut fur u!");
}
}
}
}

But it still doesnt work

EDIT: Got it working now, thanks for the help guys

 

Zix
Try this maybe?

Code:java

getConfig().getString(player.getName() + ".currentquest") == bread

 

Wrong. Strings are compared with '.equals()' or '.equalsIgnoreCase()'. I don't know the exact technicalities, but you cannot compare Strings with '=='.

 

Oh yes, you are right. I forgot that

 

Comparing two objects with the equality operator compares their memory addresses, I believe.

 

Done.

Code:java

@SuppressWarnings("deprecation")
@EventHandler(priority = EventPriority.HIGHEST)
public void onBlockClick(PlayerInteractEvent event){
Player player = event.getPlayer();
if(event.getAction() == Action.RIGHT_CLICK_BLOCK){
Block block = event.getClickedBlock();
if(block.getType() == Material.STONE){
String quest = "bread";
String current = "bread";
if (this.getConfig().get(player.getName() + ".currentquest") == current){
player.sendMessage(ChatColor.RED + "You already have an active quest");
} else if (this.getConfig().get(player.getName() + ".currentquest") != current) {
player.sendMessage(ChatColor.DARK_AQUA + "New quest started!");
player.sendMessage(ChatColor.AQUA + "Deliver this bread to the bakery");
player.getInventory().addItem(new ItemStack(Material.BREAD, 3));
player.updateInventory();
this.getConfig().get(player.getName() + ".currentquest", quest);
saveConfig();
}
saveConfig();
}
}
}
}

Edited.