CraftItemEvent won't update CraftingInventory

I made a custom recipe added to the server onEnable().
I managed to craft the item.
When i tries to craft and pickup just 1 resulted item, it has no problem at all.

But when i tries to do quantity pickup (InventoryAction.MOVE_TO_OTHER_INVENTORY), the TopInventory will not update correctly and leaves a ghostly recipe behind.
BottomInventory will not update to the right amount.

I've tried making the player to UpdateInventory but its not working.
Anyone can help me?

 

Please post your main java file (containing above code).
- Minty

 

Code:java

public class Main extends JavaPlugin implements Listener
{
    private Echo gEcho = new Echo();
    private HomeFeather gHomeFeather = new HomeFeather();
 
    public void onEnable()
    {               
        //Register plugin to plugin manager
        EnchantGlow glow = new EnchantGlow(128);
        this.getServer().getPluginManager().registerEvents(this, this);
        this.getServer().addRecipe(gHomeFeather.HomeFeatherRecipe());
 
        try
        {
            try
            {
                Field f = Enchantment.class.getDeclaredField("acceptingNew");
                f.setAccessible(true);
                f.set(null, true);
            }
            catch (Exception e)
            {
                e.printStackTrace();
            }
 
            try
            {
                Enchantment.registerEnchantment(glow);
            }
            catch (IllegalArgumentException e)
            {
                //if this is thrown it means the id is already taken.
            }
        }catch(Exception e)
        {
            e.printStackTrace();
        }
    }
 
    public void onDisable()
    {   
        this.getServer().resetRecipes();
        HandlerList.unregisterAll();
    }
 
    //@SuppressWarnings("deprecation")
    @EventHandler
    public void onCraftItem(CraftItemEvent e)
    {
        //i stop here, some problems when the player collects the result in bulk will
        //make the craft inventory not updated.
 
 
 
    }
 
    @EventHandler
    public void onInteract(PlayerInteractEvent e)
    {
        try
        {
            if(e.getAction() == Action.RIGHT_CLICK_BLOCK)
            {
                if(e.getPlayer().getItemInHand() != null)
                {
                    if(e.getPlayer().getItemInHand() instanceof ItemStack)
                    {
                        if(e.getPlayer().getItemInHand().getType().equals(gHomeFeather.Item_HomeFeather().getType()))
                        {
                            ItemStack itemStack = e.getPlayer().getItemInHand();
                            if(gHomeFeather.Exist(itemStack))
                            {
                                e.setCancelled(true);
                                if(e.getPlayer().teleport(e.getPlayer().getBedSpawnLocation(),TeleportCause.PLUGIN))
                                {
                                    gEcho.Msg(e.getPlayer(), ChatColor.YELLOW + "Welcome home.");
                                    if(e.getPlayer().getItemInHand().getAmount() > 1)
                                    {
                                        e.getPlayer().getItemInHand().setAmount(e.getPlayer().getItemInHand().getAmount()-1);
                                    }else
                                    {
                                        e.getPlayer().setItemInHand(null);
                                    }
                                }else
                                {
                                    gEcho.Msg(e.getPlayer(), ChatColor.YELLOW + "Sorry. Unable to bring you home.");
                                }
                            }
                        }
                    }
                }
            }
        }catch(Exception ex)
        {
            gEcho.Trace("Home Feather :: onInteract() :: " + ex.getMessage());
            gEcho.Msg(e.getPlayer(), ChatColor.YELLOW + "Sorry. Unable to bring you home.");
        }
    }
 
}

Thanks in advance.

I got no idea where to fix this.
Can't seem to find any "CraftingInventory.Update()" in the API.

** I had taken away the syntax for the InventoryAction, coz i cant find any methods to update it, so i assume it was something else...

And the HomeFeather Class code goes below.

Code:java

public class HomeFeather
{
    private String _ItemName = "HOME FEATHER";
    private String _ItemCode = "123456";
    private Short _ItemSubID = 999;
    private Material _ItemType = Material.FEATHER;   
 
 
    public HomeFeather()
    {
 
    }
 
    public ShapedRecipe HomeFeatherRecipe()
    {
        ShapedRecipe recipe = new ShapedRecipe(Item_HomeFeather());
        recipe.shape("FFF", "F F", "FFF");
        recipe.setIngredient('F', Material.FEATHER);
        return recipe;
    }
 
    public ItemStack Item_HomeFeather()
    {
        EnchantGlow glow = new EnchantGlow(128);
        ItemStack iStack = new ItemStack(_ItemType, 1, _ItemSubID);
        ItemMeta iMeta = iStack.getItemMeta();
        iMeta.setDisplayName(ChatColor.AQUA + _ItemName);
        iMeta.setLore(Arrays.asList(ChatColor.MAGIC + _ItemCode, ChatColor.GRAY + "Right-Click this to go home."));
        iStack.setItemMeta(iMeta);
        iStack.addUnsafeEnchantment(glow, 1);
 
        return iStack;
    }
 
    public boolean Exist(ItemStack itemStack)
    {
        if(itemStack.getItemMeta().getDisplayName() != null)
        {                           
            if(itemStack.getItemMeta().getDisplayName().equalsIgnoreCase("null") == false)
            {
                if((itemStack.getItemMeta().getDisplayName().equalsIgnoreCase(ChatColor.AQUA + _ItemName)))
                {
                    if(itemStack.getType() == _ItemType)
                    {
                        if(itemStack.getDurability() == _ItemSubID)
                        {
                            if(itemStack.getItemMeta().getLore().toArray()[0].toString().contains(_ItemCode))
                            {
                                return true;
                            }
                        }
                    }
                }
            }
        }
        return false;
    }
 
    public void Create(Player player)
    {
        player.getInventory().addItem(Item_HomeFeather());
    }
 
}

This is the class i made for the HomeFeather Item.
As you can see, the ShapedRecipe should be very simple.
Just not sure why it has problems.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Hi, I've posted the code.
Your help would be very much appreciated.
Thank you.

 

zerodevice
Have you tried just using this? :

Code:

Player player = /*get player*/;
player.updateInventory();

If this doesn't seem to work, you could always look at this thread. However, try and avoid his method ( I hate BukkitRunnables , with great passion - mainly because so many people - me included once upon a time - use it for a cool down, when you don't need to).

Hope this helped,
- Minty

 

I did tried the updateInventory() but doesn't change anything and its updating the players inventory and not the crafting inventory.

 

zerodevice
I see you commented out your CraftItemEvent. Please could you post this too?

Thanks,
- Minty

 

I didn't really commented out the CraftItemEvent, it was just there blank because i've tested several attempts including the updateinventory and other methods and it's not working so im leaving it blank until i can figure it out.

do you know of any methods to actually update the CraftingInventory or im actually coding a wrong approach from the beginning?

My main target is to create my own custom recipe and then players can craft them with 1 or quantity.
i've seen other plugins made it but just not sure why i couldn't do it.

Thanks.

 

zerodevice
After looking through some of the javadocs, I have come to the conclusion that your coding from the wrong approach. Here (for CraftingInventory) you GET the items being crafted using these (here for better documentation):

Code:

itemstack.getResult();
//Check what item is in the resulting slot of the crafting inventory - gets recipe formed
itemstack.getMatrix();
//get crafting matrix (where user crafts - applies items for crafting) - gets contents, if any
setResult(ItemStack, newResult);
//set the result (what the player gets from the resulting slot)
setMatrix(ItemStack[], contents);
//replace the items placed into the matrix (crafting area)
Recipe recipe = event.getRecipe();
//get the recipe formed inside the crafting box, if any
 
/*extra paremeters : */
newResult

I hope this helped considerably more,
- Minty

 

H

Hmm.... Ok Thanks Minty, I've going to give it a try.