Custom File StringList

Hey,
Files Class: http://www.hastebin.com/afasayusox.avrasm
Error: http://www.hastebin.com/sawaqinifu.avrasm
I want to make a StringList so I can save Lists when the server reloads/shutsdown.
Thanks in advance

 

Marten Mooij
You are trying to create section on an empty childnode. See line 28 in GhostData

 

Gater12 Could you please explain a bit more about what I am doing wrong/how to fix it?

 

Marten Mooij
This line:

Code:java

config.createSection("Ghosts.");

You're trying to create a section on an empty node. This of it like a key/value storage. The key is the node name and the value is the value you what to store in associate with the key.

 

Marten Mooij YAML paths are separated by fullstops. When you look at your path, it exists of two parts: the first part of the path is "Ghosts", and the second (child) part is "". Now, if you read the error, you notice that it complains about an empty path, right? And if we look at the explanation I wrote a few lines back, your second part is an empty String.

Since this is actually hardcoded, it is up to you how you fix it, as long as you have something after "Ghosts.".

 

Gater12 fireblast709
Files Class: http://www.hastebin.com/fodoqozulu.avrasm
onDisable: http://www.hastebin.com/yuzudenavo.avrasm

public static List<UUID> ghosts = new ArrayList<UUID>();

What am I missing/doing wrong? I don't seem to get it.
EDIT: The error: http://www.hastebin.com/eyacucafip.avrasm

 

Marten Mooij ghosts is null (in the main class). Also note that you don't need to invoke toString(), you should be able to save Sets directly.

 

fireblast709 I check to see whether or not ghosts is null and only if ghosts contains something will it save the UUIDs to the StringList.

Code:java

 if(!(ghosts.isEmpty())){
GhostData.getConfig().set("Ghosts", ghosts);
GhostData.saveConfig();
}
}

Having this problem whenever I use custom files, any help is appreciated.

It works but now it seems to be doing this:

Code:

Ghosts:
- !!java.util.UUID {}

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

When you save a UUID to a source outside of Java, you need to convert it to a String, using UUID#toString.

When you load the UUID from an outside source, use: UUID#fromString.

 

FerusGrim If I do:

Code:java

    public void onDisable(){
    Bukkit.getServer().getConsoleSender().sendMessage(ChatColor.DARK_RED + "[Ghosty] Is Now Disabled.");
 
    if(!(ghosts.isEmpty())){
    GhostData.getConfig().set("Ghosts", ghosts.toString());
    GhostData.saveConfig();
    }
    }

It makes it this:

Code:

Ghosts: '[b0ec0f58-5935-45bd-bfa1-d4b9b14a715d]'

And I want it to be a StringList.

 

Marten Mooij
Create a List of Strings

Code:java

List<String> myList = new LinkedList<String>();

Add all of the current config list using the addAll(); method.

Then add the ghost to that list using the add(); method.

Save the config path using:

Code:java

MyConfig.set("Ghosts", myList);

Save your config.

 

CraftCreeper6 But I want to use UUIDs.

 

Marten Mooij
Same concept.

EDIT: Change String to UUID.

 

CraftCreeper6 "Add all of the current config list using the addAll(); method.
Then add the ghost to that list using the add(); method."
You're going to have to show me an example since I do not get what you mean by that.

 

Marten Mooij
Change it back to String.
Instead of using
add(player.getUniqueId());

Use
add(player.getUniqueId().toString());

 

Code:java

 Main.ghosts.add(player.getUniqueId().toString());

Gives me this:

Code:

The method add(UUID) in the type List<UUID> is not applicable for the arguments (String)

EDIT: Changing the ArrayList to use <String>

 

Marten Mooij
Like I said, change

Code:java

List<UUID> myList = new LinkedList<UUID>();

To:

Code:java

List<String> myList = new LinkedList<String>();

 

CraftCreeper6 Thank you so much, it works.

 

Marten Mooij

 

Something is throwing a NullPointerException.

What line is on line 50? My guess is that you cannot refer to your config using a static call to GhostData.

 

Marten Mooij

• You try to use a UUID as a name, use UUID.fromString(String) and use that UUID object.
• They might not be online, thus returning null.

 

Thinking on this, it's probably a combination of the two.

Using a string in getPlayerExact() would look for a username with the UUID of the name. A player with that name would never be online, thus returning null. =p

 

FerusGrim fireblast709 Updated code:

Code:java

public static void restoreGhosts(){
    for(String uuids : GhostData.getConfig().getStringList("Ghosts")){
 
    Player players = Bukkit.getServer().getPlayer(UUID.fromString(uuids));
 
    if(players.isOnline()){
    players.setGameMode(GameMode.ADVENTURE);
    }
    }
    }
}
 

The error is on line 33 which is: for(String uuids : GhostData.getConfig().getStringList("Ghosts")){

 

Marten Mooij

• FerusGrim was right about this one, getConfig() returns null.
• players.isOnline() is a NullPointerException when that is fixed. isOnline() only works for OfflinePlayers, check null when using Players.

 

Can we see the config.yml? It's possible the NPE is caused by Ghosts not existing in a proper state to be called.

However, I'm thinking the issue is with statically referring to GhostData.

 

fireblast709 FerusGrim Here is the GhostData file:

Code:

Ghosts:
- b0ec0f58-5935-45bd-bfa1-d4b9b14a715d

Updated code how I think it should be:

Code:java

public static void restoreGhosts(){
    for(String uuids : GhostData.getConfig().getStringList("Ghosts")){
 
    Player players = Bukkit.getServer().getPlayer(UUID.fromString(uuids));
 
    if(players == null){
    return;
    }
 
    if(players.isOnline()){
    players.setGameMode(GameMode.ADVENTURE);
    }
    }
    }
}
 

How exactly is GhostData.getConfig() return null?
Thanks so much for your help guys

 

Because getConfig() is something that relies on your class Object, rather than the file itself. Meaning that getConfig(), unless instantiated, is null. Meaning you can't refer to it statically.

There are two methods that are popular for solving this issue. getInstance(), or putting a constructor in your other classes which saves the class instance.

getInstance():

Code:java

public class GhostData extends JavaPlugin {
    private static GhostData instance;
 
    @Override
    public void onEnable() {
        instance = this;
    }
 
    public static GhostData getInstance() {
        return instance;
    }
}
// Then, do something like this:
GhostData.getInstance().getConfig().getStringList("Ghosts");

Or, using a constructor:

Code:java

public class SomeClass {
    private final GhostData plugin;
 
    public SomeClass(GhostData plugin) {
        this.plugin = plugin;
    }
 
    public void someMethod() {
        // Then, do this:
        plugin.getConfig().getStringList("Ghosts");
    }
}
 
// In the class that extends JavaPlugin:
@Override
public void onEnable() {
    new SomeClass(this);
}
 

 

Code:java

    public static void restoreGhosts(){
    for(String uuids : GhostData.getConfig().getStringList("Ghosts")){
 
    Player players = Bukkit.getServer().getPlayerExact(uuids);
 
    if(players == null){
    return;
    }
 
    players.setGameMode(GameMode.ADVENTURE);
    }
    }
}

Here is the GhostData class:

Code:java

package me.lalala;
 
import java.io.File;
import java.io.IOException;
 
import me.lalalalala.Ghosty.Main;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.configuration.file.FileConfiguration;
import org.bukkit.configuration.file.YamlConfiguration;
 
public class GhostData{
 
    public static FileConfiguration config;
    public static File file = new File(Main.getPlugin().getDataFolder(), "GhostData");
 
    public static void createFile(){
    if(!(file.exists())){
    try{
    file.createNewFile();
    }catch(Exception ex){
    Bukkit.getServer().getConsoleSender().sendMessage(ChatColor.DARK_RED + "Failed to generate the file: GhostData");
    }
    config = YamlConfiguration.loadConfiguration(file);
    config.createSection("Ghosts");
    saveConfig();
    }
    }
 
    public static FileConfiguration getConfig(){
    return config;
    }
 
    public static void reloadConfig(){
    config = YamlConfiguration.loadConfiguration(file);
    }
 
    public static void saveConfig(){
    try{
    config.save(file);
    }catch(IOException ex){
    Bukkit.getServer().getConsoleSender().sendMessage(ChatColor.DARK_RED + "Could not save the file: GhostData");
    }
    }
}

Not sure how this can return null...

 

Egh. Sorry, I was assuming you were using the inherited JavaPlugin#getConfig.

 

FerusGrim So what can be the problem then :?

BUMP, any help is appreciated.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.