Custom PM command!

I have created a custom PM command so that players can private message someone. I don't understand why I don't say the actually message. When I typed /tell ajs333 hi... It won't tell ajs333 hi...

Here is my coding...

Code:

if (commandLabel.equalsIgnoreCase("tell") || commandLabel.equalsIgnoreCase("msg") || commandLabel.equalsIgnoreCase("r")) {
               
                String message1 = "";
                Player target = Bukkit.getServer().getPlayer(args[0]);
               
                if(mute.contains(sender.getName())) {
                    return false;
                } else {
     
                for (int i = 1; i < args.length; i++) message += (i > 1 ? " " : "") + args[i];
     
                        sender.sendMessage(ChatColor.GRAY + "[Me -> " + target.getName() + "] " + message1);
     
                        target.sendMessage(ChatColor.GRAY + "[" + sender.getName() + " - > Me] " + message1);
     
                        return true;   
                }
        }

 

ajs333

Code:java

if (commandLabel.equalsIgnoreCase("tell") || commandLabel.equalsIgnoreCase("msg") || commandLabel.equalsIgnoreCase("r")) {
 
String message1 = "";
Player target = Bukkit.getServer().getPlayer(args[0]);
 
if(mute.contains(sender.getName())) {
return false;
} else {
 
for (int i = 1; i < args.length; i++)
message1 += (i > 1 ? " " : "") + args[I]; // you had message not message1[/I]
 
[I] sender.sendMessage(ChatColor.GRAY + "[Me -> " + target.getName() + "] " + message1);[/I]
 
[I] target.sendMessage(ChatColor.GRAY + "[" + sender.getName() + " - > Me] " + message1);[/I]
 
[I] return true; [/I]
[I] }[/I]
[I] }[/I]

Does that fix your problem? If not does it throw any errors? Also it'd be a good idea to check if (args.length > 2) before trying to parse everything.

 

ajs333
never use commandLabel use command.getName().equalsIgnoreCase("tell") or cmd.getName().equalsIgnoreCase("tell")

 

Xacero
I get an error...
http://gyazo.com/ff724a390cf8bcd184e77a5472ea906d

MrSparkzz
Ok Ill use that... but that won't fix my issue...

 

ajs333
Try using

Code:java

args[ i ];

Or you can use my method of converting the args to Strings:

Code:java

StringBuilder str = new StringBuilder();
 
for (int i = start; i < args.length; i++) {
    str.append(args[ i ] + " ");
}
 
String message1 = str.toString();

replace the "start" variable with a number where you want to start the string builder, which I'm guessing would be 2.

 

MrSparkzz
I'm back to the first issue where it doesn't display the message.

 

ajs333
Does it display anything at all to the user? [ex [TargetName] -> (no message here)) ?

 

ajs333
post your new code?

PS: (Putting the I in the brackets was a huge pain, it kept thinking I wanted to italicize everything -.-)

 

Xacero
When I type /tell ajs333 Hi

This is what it displays!

[me -> ajs333]

MrSparkzz
Here is my code:

Code:

if (command.getName().equalsIgnoreCase("tell") || command.getName().equalsIgnoreCase("msg")) {
           
           
            StringBuilder str1 = new StringBuilder();
            Player target = Bukkit.getServer().getPlayer(args[0]);
           
            if(mute.contains(sender.getName())) {
            return false;
            } else {
           
                for (int i = 1; i < args.length; i++) {
                    str.append(args + " ");
                }
                String message1 = str1.toString();
           
                sender.sendMessage(ChatColor.GRAY + "[Me -> " + target.getName() + "] " + message1);
           
                target.sendMessage(ChatColor.GRAY + "[" + sender.getName() + " - > Me] " + message1);
           
                return true;
            }
        }

 

ajs333
Oh str isn't a variable in your code, sorry. So replace that with message1. Then remove String from infront of message1 in the code I supplied.

 

MrSparkzz
Woah, wait... I got a tone of errors...

 

ajs333

Code:java

if (command.getName().equalsIgnoreCase("tell") || command.getName().equalsIgnoreCase("msg")) {
 
Player target = Bukkit.getServer().getPlayer(args[0]);
 
if(mute.contains(sender.getName())) {
return false;
} else {
 
String message1 = "";
 
for (int i = 1; i < args.length; i++) {
message1 = message1 + (args + " ");
}
 
sender.sendMessage(ChatColor.GRAY + "[Me -> " + target.getName() + "] " + message1);
 
target.sendMessage(ChatColor.GRAY + "[" + sender.getName() + " - > Me] " + message1);
 
return true;
}
}

 

ajs333 Or you could do that ^

 

MrSparkzz Xacero
That doesn't work...

 

ajs333

Code:java

if (command.getName().equalsIgnoreCase("tell") || command.getName().equalsIgnoreCase("msg")) {
 
Player target = Bukkit.getServer().getPlayer(args[0]);
 
if(mute.contains(sender.getName())) {
return false;
} else {
 
String message1 = "";
 
for (int i = 1; i < args.length; i++) {
message1 = message1 + (args[I] + " ");[/I]
[I]}[/I]
 
[I]sender.sendMessage(ChatColor.GRAY + "[Me -> " + target.getName() + "] " + message1);[/I]
 
[I]target.sendMessage(ChatColor.GRAY + "[" + sender.getName() + " - > Me] " + message1);[/I]
 
[I]return true;[/I]
[I]}[/I]
[I]}[/I]

missed the index in the array.
You should really familiarize yourself with how arrays work
Easy error to fix if you knew what to look for, I'm writing this in the bukkit text editor so I sometimes miss things, sorry about that

 

Xacero
Ahhh, yes that worked... Thank you to everyone who helped me! Xacero and MrSparkzz

I don't want to overwhelm you two but now how could I do /r and that would reply to that message?

 

ajs333
You're quite welcome Have a nice day!

 

Xacero
I don't know if you saw my earlier post but I said that I didn't want to overwhelm you but how would I do /r to reply to that message?

 

ajs333

Code:java

 
// put this outside of your command method
HashMap<String, String> reply_list = new HashMap<String, String>();
 
//on your message command
reply_list.put(target.getName(), sender.getName());
 
//on your reply command
if (reply_list.containsKey(sender.getName())
target = Bukkit.getServer().getPlayer(reply_list.get(sender.getName());
else
sender.sendMessage(ChatColor.RED + "You have nobody to reply to!");
 

may need to rename some variables

 

Xacero
Ok, I'll try this and see what happens!

Xacero
I quick question... I get an error on the "target"

 

ajs333
Post your full command code please?

 

Xacero
I'm sure I did something wrong because I get an internal error...

Code:

if (command.getName().equalsIgnoreCase("tell") || command.getName().equalsIgnoreCase("msg")) {
           
            Player target = Bukkit.getServer().getPlayer(args[0]);
           
            reply_list.put(target.getName(), sender.getName());
           
            if(mute.contains(sender.getName())) {
                sender.sendMessage(ChatColor.GOLD + "You are muted!");
            return false;
            } else {
           
            String message1 = "";
           
            for (int i = 1; i < args.length; i++) {
            message1 = message1 + (args[i] + " ");
            }
           
            sender.sendMessage(ChatColor.GRAY + "[" + sender.getName() + " ->" + target.getName() + "] " + message1);
           
            target.sendMessage(ChatColor.GRAY + "[" + sender.getName() + " - > Me] " + message1);
           
            return true;
                }
            }
        if (command.getName().equalsIgnoreCase("r") || command.getName().equalsIgnoreCase("reply")) {
            Player target = null;
            String message1 = "";
           
            for (int i = 1; i < args.length; i++) {
            message1 = message1 + (args[i] + " ");
            }
 
            if (reply_list.containsKey(sender.getName()))
                    target = Bukkit.getServer().getPlayer(reply_list.get(sender.getName()));
                    sender.sendMessage(ChatColor.GRAY + "[" + sender.getName() + " ->" + target.getName() + "] " + message1);
           
                    target.sendMessage(ChatColor.GRAY + "[" + sender.getName() + " - > Me] " + message1);
        } else {
                    sender.sendMessage(ChatColor.RED + "You have nobody to reply to!");
        }
        return false;
    }
}

 

ajs333
target is returning null. In your "tell" command you need to add the target to the HashMap.

EDIT: just realized you already did that... Well you should probably have it the other way around so that the sender is the first thing in the HashMap and target is the second.

 

MrSparkzz
How do I do that??

 

MrSparkzz

The way it works :

format : [player] [last person to message player]

on message send : add to list [message target] [person that sent message]

on reply send : get value of key [sender] (will return) [person that sent message]

ajs333

Got a stacktrace for me to look at?

 

ajs333
This is what I would do

Code:java

// your hashmap
HashMap<Player, Player> reply_list = new HashMap<Player, Player>();
 
// adding to the hashmap
reply_list.put(sender, target);
 
// getting the hashmap
if (reply_list.containsKey(sender))
target = Bukkit.getServer().getPlayer(reply_list.get(sender));

Xacero when you do if (reply_list.containsKey(sender.getName)) you're looking for the first thing in the HashMap, which in the code you supplied would be the target's name. So basically you'd have to flip it around. and when you do reply_list.get(sender.getName()); you were still looking for the first thing in the HashMap and then get the second thing which would be the senders name in your case.

Basically you just had your variables backwards. And I think it would be better to use Player variables instead of Strings in the HashMap. (just so you can get more information from them and it just looks cleaner.)

 

MrSparkzz
Xacero
I get this error

20:47:25 [SEVERE] null
org.bukkit.command.CommandException: Unhandled exception executing command 'r' in plugin sBan v1
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:46)
at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:192)
at org.bukkit.craftbukkit.v1_6_R3.CraftServer.dispatchCommand(CraftServer.java:523)
at net.minecraft.server.v1_6_R3.PlayerConnection.handleCommand(PlayerConnection.java:959)
at net.minecraft.server.v1_6_R3.PlayerConnection.chat(PlayerConnection.java:877)
at net.minecraft.server.v1_6_R3.PlayerConnection.a(PlayerConnection.java:834)
at net.minecraft.server.v1_6_R3.Packet3Chat.handle(SourceFile:49)
at net.minecraft.server.v1_6_R3.NetworkManager.b(NetworkManager.java:296)
at net.minecraft.server.v1_6_R3.PlayerConnection.e(PlayerConnection.java:116)
at net.minecraft.server.v1_6_R3.ServerConnection.b(SourceFile:37)
at net.minecraft.server.v1_6_R3.DedicatedServerConnection.b(SourceFile:30)
at net.minecraft.server.v1_6_R3.MinecraftServer.t(MinecraftServer.java:592)
at net.minecraft.server.v1_6_R3.DedicatedServer.t(DedicatedServer.java:227)
at net.minecraft.server.v1_6_R3.MinecraftServer.s(MinecraftServer.java:488)
at net.minecraft.server.v1_6_R3.MinecraftServer.run(MinecraftServer.java:421)
at net.minecraft.server.v1_6_R3.ThreadServerApplication.run(SourceFile:583)
Caused by: java.lang.NullPointerException
at sBan.sBan.onCommand(sBan.java:166)
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:44)
... 15 more

>

 

MrSparkzz

If I'm reading that correctly it won't reply to the last person that messaged you, it'll send the message to the last person you messaged. Not the same thing

 

ajs333
What's line 166 (located in your onCommand() method)?

 

ajs333

Code:java

 
if (command.getName().equalsIgnoreCase("r") || command.getName().equalsIgnoreCase("reply")) {
String message1 = "";
 
for (int i = 0; i < args.length; i++) {
message1 = message1 + (args + " ");
}
 
if (reply_list.containsKey(sender.getName()))
Player target = Bukkit.getServer().getPlayer(reply_list.get(sender.getName()));
if (target == null) {
sender.sendMessage(ChatColor.RED + "That player is offline!");
return true;
}
sender.sendMessage(ChatColor.GRAY + "[" + sender.getName() + " ->" + target.getName() + "] " + message1);
 
target.sendMessage(ChatColor.GRAY + "[" + sender.getName() + " - > Me] " + message1);
} else {
sender.sendMessage(ChatColor.RED + "You have nobody to reply to!");
}
return false;[I][/I]

Try this?