Solved Death Cause problems (2 problems)

Hi,

First problem
I want to check if a player got killed by a Projectile, and since I fire a snowball, and use custom damage with that, I assume the player didn't directly got killed by a snowball.

Code:java

public static void doDamage(Projectile p, Player shot, Player shooter) {
        Random r = new Random(); //create new random
        if (p instanceof Snowball) {
          Snowball b = (Snowball) p;
          shot.damage(2); //Custom damage

I need the shooter of the projectile too btw.
I assumed you have to check for the last damage cause, but when I try

Code:java

@EventHandler
public void onDeath(PlayerDeathEvent e){
  //Assume I already casted it (I did)
  if(player.getLastDamageCause().equals(DamageCause.PROJECTILE)){
      System.out.println("Debug");
  }
}

It doesn't work. Any ideas?

Second problem
I made grenades, which do work. However, when the damaged player(s) took enough damage to die, I need to get the thrower of the grenade.

Code:java

private void onExplosion(Item item, double damage, Player thrower,
            Sound sound, int radius, ParticleEffect... effect) {
        for (ParticleEffect eff : effect) {
            eff.display(item.getLocation(), 2, 1, 2, 0, 300);
        }
        for (Entity e : item.getNearbyEntities(radius, radius, radius)) {
            if (e instanceof Player) {
                Player hit = (Player) e;
                hit.playSound(hit.getLocation(), sound, 30, 1);
                if (hit.equals(thrower) || m.teams.sameTeam(thrower, hit))
                    continue;
                hit.damage(damage);
            }
        }
    }

----------------------------------

Note:
I tried using

Code:java

public void checkDeath(Player killer, Player killed){
        if(killed.getHealth() == 0 || killed.getHealth() < 0){

But that bugs quite alot (multiple times fires when a single player dies)

 

Unica Why not just use setDamage() inside the EntityDamageByEntityEvent (which fires when you're hit by a snowball)?

 

AdamQpzm
Will that automatically know that the shooter = the killer in the PlayerDeathEvent ?

 

Unica I don't have the resources to check at the moment, so you should probably test that. Although I would say that it would - based on the fact that, by default, being shot to death gives the player as the killer in vanilla death messages.

 

AdamQpzm

Thank you It does actually work

How would achieve a thing like this with a explosion? Since I am checking for nearby entities, and they did not get hit by something.

 

Unica I don't understand the issue?

 

AdamQpzm
Let me enlighten you,

The 'grenade' which I made is a dropped item which I change velocity of.
Therefor no person get's damaged from the dropped item. I set custom damage for that,
so in the entityDamageEvent I cannot use

Code:java

if(e.getDamager() instanceof myGrenade)

Basically, I need to get the thrower + person who died by my explosion (could be more than one) in my
PlayerDeathEvent, so I can broadcast a message etc.

 

Unica is myGrenade an Entity?

 

Unica When you invoke onExplosion, set set a field somewhere to your entity and set it to null afterwards. Then, if a player died and that field isn't null, they died because of the grenade (because the damage and death events should be triggered before the damage method returns).

 

fireblast709

What do you mean with 'set a field' ?

 

Unica a field in your listener class, for example.

 

fireblast709

Code:java

private boolean grenade = false;
 
private void onExplosion(Item item, double damage, Player thrower,
            Sound sound, int radius, ParticleEffect... effect) {
        for (ParticleEffect eff :
            eff.display(item.getLocation(), 2, 1, 2, 0, 300);
        }
                grenade = true;
        for (Entity e : item.getNearbyEntities(radius, radius, radius)) {
            if (e instanceof Player) {
                Player hit = (Player) e;
                hit.playSound(hit.getLocation(), sound, 30, 1);
                if (hit.equals(thrower) || m.teams.sameTeam(thrower, hit))
                    continue;
                hit.damage(damage);
            }
        }
                grenade = false;
    }

Something like that?
If yes, what if there were multiple grenades thrown at the same time (multiple players), how would I achieve such a thing then?

 

Unica that's why I suggested an Entity (or a Player field since that would be the information you want) field instead of a boolean .

 

fireblast709
mm, That is indeed more logic.
But if I would 'private Player inRadius = playerFromLoop; that would turn out in one single player inside that field,
isn't it then smarter to use a Set?

 

Unica no lol. Set the 'private Player thrower' to the thrower, since that's the Player that actually kills them. Then, when a PlayerDeathEvent is fired, check if 'private Player thrower' is null. If it's not, then it's almost certain that the player died by a grenade from that Player.

Afterwards, set 'thrower' to null so the death events that follow (which aren't caused by the damage dealt in the explode method) won't be seen as grenade kills.

 

fireblast709

I owe you alot
Thanks!

For the ppl that are wondering how fireblast709 did this,

Code:java

private Player thrower = null;
 
public Player getThrower(){ //Method
return this.thrower;
}
 
public void explode(Player thrower){ //Earlier method when a grenade explodes
  this.thrower = thrower;
  for(Player nearby : bombThatGotThrown.getNearbyEntites(x, x, x)){
      nearby.damage(double);
  }
  thrower = null;
}
 
//OnDeath
 
@EventHandler
public void onDeath(PlayerDeathEvent e){
  if(getThrower != null){
      //Entity got killed by grenade
  }
}