Solved Detecting damage events that has beed caused by plugin

Hello. I'm developing a plugin. A part of it should return some percentage of dealt to player damage to damager. Here's the code:

Code:java

@EventHandler
public void entityDamaged(EntityDamageEvent e){
    if(e.getEntity().getType() != EntityType.PLAYER) return;
    if(e.getCause().equals(DamageCause.DROWNING)) return;
    Player p = (Player) e.getEntity();
    PlayerStatus ps = plugin.getStatus(p);
    if(ps.getBranch() == 0){
        //some another code goes here
        if(e instanceof EntityDamageByEntityEvent && ps.getAbility(6) > 0){
            EntityDamageByEntityEvent ee = (EntityDamageByEntityEvent) e;
            if(!(ee.getDamager() instanceof LivingEntity)) return;
            NCPManager.disableChecks(p);
            LivingEntity le = (LivingEntity) ee.getDamager();
            le.damage(e.getDamage() * ability_0_6[ps.getAbility(6)], p);
            NCPManager.enableChecks(p);
        }
    }
}

The problem is when two players with "return damage" ability hitting each other, it hangs the server up and ending with stack overflow error. I know why it's that: it's because plugin creates another EntityDamageEvent that passes checks and trying to return damage from returned damage. How can I prevent this from happening (deny plugin to process damage that was result of return)?

 

You can either set damage source to something you can track or you can use setHealth() instead. I think the latter is not calling damage event.

 

https://github.com/RawCode/UBT/blob/master/src/rc/ubt/hnde/ForcedPvP.java

line 74

 

Are you sure about that one? Edit: never mind

 

You know you can link to a line#:

https://github.com/RawCode/UBT/blob/master/src/rc/ubt/hnde/ForcedPvP.java#L74

That said, I assume what you're trying to suggest here is using a cooldown to avoid the problem?

I like the approach raGan. gave better, personally- check the damage cause, if it's "CUSTOM" than skip it, I think that ought to work.

 

Look closely at what it's doing. It's a perfectly valid answer.

 

I stared at it for quite a while. I honestly have no idea what it's trying to do, and I very much doubt the OP does either. No offense to the OP, I am more saying that coming in and dumping a link to a random piece of source code with no documentation, crazy-jibberish in-game messages (??), and providing absolutely no explanation is not super helpful.

OP asked how to detect damage events that were caused by a plugin- looking for the "CUSTOM" cause does exactly that. Sure you can start mapping your own damages with cooldowns or whatever, but isn't that a lot more complex and prone to getting out of sync?

I don't see how damaging players on quit if they haven't ... done ... something... within a certain threshold... or whatever, relates to any of this at all- but yeah you are probably right that I haven't looked closely and may be missing something... but I'm not sure I should have to look this closely to see what RawCode was trying to say. Maybe I'm daft

 

There is a boolean. It is set to true before (possibly) killing the player and then false after. In the death event, it will return before doing anything if the boolean is true. What this means is that if he kills the player inside the PlayerQuitEvent the death event will be ignored. You could apply a similar system to prevent recursion in situations like the OP's.

 

NathanWolf
learn 2 read code without spoonfeeding comments at every line, this helps.
messages in russian.

Garris0n
you had explained properly.

 

It would have been 100% more useful to say "set a flag to prevent recursion" than just post a random link to vaguely-relevant code. I don't want to spoonfeed people, either, but if you're trying to help don't you think a little explanation would be nice?

I still contend that checking the damage source is tremendously more straightforward and I haven't heard a good argument against it.

EDIT: Made it less flamey.

 

i provided valid code about setting flag and working with it.
if you can't read or require major explanation about simple code - you will have bad time if attempt to perform original research or read obfustaced code (like NMS) NathanWolf

 

I got it, it works, thanks