Disable bad words plugin not working!

I need help with my plugin thats disables bad words. But the canceling for the bad words is not that hard. but im in an orther part stuck! i have this code:

Code:java

public class DisWords implements Listener {
 
    private ScoreBoard plugin;
 
    public DisWords(ScoreBoard instance) {
        this.plugin = instance;
    }
 
    int kick = 0;
    final public ArrayList<Player> mute = new ArrayList<Player>();
 
    @EventHandler
    public void onPlayerChat(final AsyncPlayerChatEvent e) {
        if (e.getMessage().contains("test")) {
            e.setCancelled(true);
            e.getPlayer().sendMessage(MsgType.NORMAL + "Swearing in such words is NOT allowed. We like to ask you to leave if you come for nonsense stuff like this!");
            this.kick += 1;
        }
 
        if (this.kick == 2) {
            e.getPlayer().sendMessage(MsgType.NORMAL + "You really do not understand what we mean by NOT.");
            e.getPlayer().sendMessage(ChatColor.LIGHT_PURPLE + "Sorry but we have to really mute for one minute! i.v.m such childish words!");
            this.mute.add(e.getPlayer());
            Bukkit.getServer().getScheduler().scheduleSyncDelayedTask(plugin, new Runnable() {
                @Override
                public void run() {
                    mute.remove(e.getPlayer());
                }
            }, 60 * 20L);
        }
 
        if (this.kick == 3) {
            e.getPlayer().kickPlayer(MsgType.NORMAL + "KICKED, we give your karma!");
            this.kick = 0;
        }
    }
 
    @EventHandler
    public void onPlayerMute(AsyncPlayerChatEvent e) {
        if (this.mute.contains(e.getPlayer())) {
            e.setCancelled(true);
        }
    }
}

Everything works fine, but only one thing not! The not working thing, is when an player types test, it says the first message. but when they typed it again, it says the first message and the "if (this.kick == 2) {" message and it dont mute the player. when they typed it 3 times, it dont kick the player, but it says the first message. Can someone tell me what im doing wrong. I have registred my events and all the other stuff!

 

First of all, try putting some debug messages in to make sure all the variables are as they should be. Secondly, what is 'this.kick'?

 

TopTobster5
I have debug messages, see they as the text! And the kick is on line 9 "int kick = 0"
I had an debug message in the runnable, but that worked, but he spams the first message!

 

jusjus112 Ok, I don't think you need to use 'this.' before every variable, if it has been declared in this class, you should be alright. What you need to do with he debug messages is find out what kick is every time someone does something. These shouldn't make it into the release of the plugin, but help you find out why things are not working rather than using the messages which a regular user will see as your debug messages. I for example would log how many times someone did something to the console, so you can tell what the count is when you wonder why it has not kicked someone. Finally, I think your issue is that when you mute someone for a minute, you never add one onto kick.

 

Try looking here: https://forums.bukkit.org/threads/tutorial-scoreboards-teams-with-the-bukkit-api.139655/

 

acecheesecr14
If you read this thread good, it is not an scoreboard! its just an disable bad words plugin

 

jusjus112 I know, but i presumed that you were using scoreboards to log the number of attempts to swear...
Only bacause the Scoreboard variable type is used and I don't see any declaration of the "kick" variable defined anywhere in this class... per player*

 

acecheesecr14

jusjus112 Did you see my fix? If so, is that what was causing the problem?

 

Thats not going to be per player, use a hashmap.

That creates the hashmap var:

Code:java

private HashMap<String, int> kick = new HashMap<String, int>();
//Use the player name instead of the actual player
 

this will add to the player's kick var, Im not sure about the kick.remove(name), be sure to check it

Code:java

if(kick.contains(e.getPlayer().getName())){
    if (kick.get(e.getPlayer().getName()) == 1 /*1 or 2 */){
        //send message.
        int oldInt = kick.get(e.getPlayer.getName());
        kick.put(e.getPlayer().getName(), oldInt++);
    }//Repeate this with differnt message's etc...
}else{
    kick.put(e.getPlayer().getName(), 1);
}

 

acecheesecr14 Good point, didn't think of that

 

That's why I thought he was using scoreboards.

And on the 1st "BadWord" you need to add the playername (My bad. Slightly tired)!

Code:

kicks.put(e.getPlayer().getName(), 1);

I edited my code above!

 

HashMaps are smart enough that when you try to put, and it has it already, it will replace. no need to remove
all you would need to do is kick.put(e.getPlayer().getName(), kick.get(e.getPlayer().getName()));

 

Thanks, I didn't know that!