Discussion: Oops, I broke your plugins!

Discussion in 'Plugin Development' started by EvilSeph, Jan 18, 2011.

  1. Offline

    Dinnerbone Bukkit Team Member Administrator

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    No. We dropped the caching mechanism, that's why the two blocks are no longer the same object.
  2. Offline

    feildmaster Bukkit Team Member BukkitDev Staff

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    No. They used to use a caching mechanism. Now it checks the literal data.
  3. Offline

    Celtic Minstrel

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    I don't think I ever used == on blocks anyway... suppose I should double-check though.
  4. Offline

    tyzoid

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    What is this error caused by?
    How do I fix it?

    Code:
    2011-10-16 14:42:43 [SEVERE] Error occurred (in the plugin loader) while disabling Colors v1.7.5 (Is it up to date?): null
    java.lang.NullPointerException
    	at java.lang.Class.isAssignableFrom(Native Method)
    	at org.bukkit.plugin.java.JavaPluginLoader.removeClass(JavaPluginLoader.java:245)
    	at org.bukkit.plugin.java.JavaPluginLoader.disablePlugin(JavaPluginLoader.java:992)
    	at org.bukkit.plugin.SimplePluginManager.disablePlugin(SimplePluginManager.java:296)
    	at org.bukkit.plugin.SimplePluginManager.disablePlugins(SimplePluginManager.java:289)
    	at org.bukkit.craftbukkit.CraftServer.disablePlugins(CraftServer.java:166)
    	at net.minecraft.server.MinecraftServer.stop(MinecraftServer.java:325)
    	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:404)
    	at net.minecraft.server.ThreadServerApplication.run(SourceFile:417)
    
  5. Offline

    feildmaster Bukkit Team Member BukkitDev Staff

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    Happens to everyone, I don't know about the team, but I've been looking into it myself... With what little time I have.
  6. Offline

    tyzoid

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    @feildmaster
    Is it a problem with bukkit?
    Seems like... Let me see if a dev version fixed it.
  7. Offline

    feildmaster Bukkit Team Member BukkitDev Staff

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    @tyzoid : I assume it is. Because it happens for everything...
  8. Offline

    tyzoid

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    @feildmaster
    Yup, Build 1340 fixed the issue.

    I have no idea why the other build was recommended/doesn't work.
  9. Offline

    Dinnerbone Bukkit Team Member Administrator

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    It's just console spam, nothing is actually broken to my knowledge.
  10. Offline

    feildmaster Bukkit Team Member BukkitDev Staff

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    They fixed it right after the recommend, but it apparently didn't get updated before the new RB.

    This is correct.

    This post has been edited 1 time. It was last edited by feildmaster Oct 16, 2011.
  11. Offline

    tyzoid

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    Yea but it is odd that a native method would be generating a NPE... Anyway thanks for the info.
  12. Offline

    Don Redhorse

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    could we update this again... yeah I know it is me asking but this is still valid..
  13. Offline

    GummiA

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    Hello, im not sure if i am so post to post this in this forum but... The 1.2.3 release has came out. And on my server i am using Build for 1.2.3 and many many plugins wont load and i get so many errors. When the RB will release will this get fixed? I see you are removing some codes. Also u tell us to update our plugins. What if the plugin developer is no longer updateing it? And It's the only plugin that does this exact thing to my server? Plz give me some aswers.
  14. Offline

    Don Redhorse

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    this is the wrong place... there is a thread which was started by codename_B about updating plugins, take a look there.

    on a side note: @EvilSeph @Dinnerbone PLEASE start posting in the oops I broke your plugin again.
  15. Offline

    --GJ-- BukkitDev Staff

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    Epic necro is epic.
  16. Offline

    Richard Robertson

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    This thread should have been active the entire time.
  17. Offline

    feildmaster Bukkit Team Member BukkitDev Staff

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    I will post any breaks I notice... Simply because this topic is here. On that note, I don't know of anything that breaks at the moment. :)
    Don Redhorse likes this.
  18. Offline

    Don Redhorse

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    thanks... but those breakage should be posted in the team only thread.. this was just for discussion :)

    but that is better than nothing..
  19. Offline

    --GJ-- BukkitDev Staff

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    I do know of one break - if you fire a BlockBreakEvent manually, you'll have to update to include the list of drops in the constructor now.
  20. Offline

    feildmaster Bukkit Team Member BukkitDev Staff

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    I know, but I don't have the ability to post there. :)


    @--GJ-- : What? That's always been the case?
  21. Offline

    Celtic Minstrel

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    No, it's because my drops pull changed the constructor of BlockBreakEvent.
  22. Offline

    feildmaster Bukkit Team Member BukkitDev Staff

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    Oh... I see.
  23. Offline

    thisguy128512

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    So I guess this is the constructor that disabled poor world guard from working.
  24. Offline

    --GJ-- BukkitDev Staff

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    Probably.
  25. Offline

    jacklin213

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    i imported the new api 1.3.1 for bukkit and it says PlayerChatEvent is deprecated ....
  26. Offline

    Engelier

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    That's right. It's now AsyncPlayerChatEvent.
  27. Offline

    jacklin213

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    is there a difference? so it would look like this
    Code:
    public void onPlayerChat(AsyncPlayerChatEvent chat)
  28. Offline

    xZise

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    And what is, if I want to modify the chat event (e.g. cancelling it). Afaik this isn't possible if it is asynchronous.

    Fabian
  29. Offline

    theguynextdoor

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    Cancelling the event is fine, but what you can't do is any non thread safe method, such as player.hasPermission
  30. Offline

    Engelier

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    The reason being? XcraftChat does that to determine the correct formatting and it works like a charm.

    Is there a better way to check the senders permissions and formatting it's chatline?

Share This Page