[ECON] CommandShops v4.1.0 - The premier local shop plugin. [1.4.7]

D'awwww. you just got rid of it. Here I was all stoked that I could finally open up my cobble shop too. Oh well, thanks for the great plugin anyways.

Just an FYI - I moved all of the Item matching code we used in LocalShops4 over to Vault - I know one person is actually using it and has helped update/maintain it (he added all the potion IDs). So if you're looking for better search/item matching type code it's available for use if you wanted to start using Vault as a dependency.

You know, that may be the thing that makes me start using Vault -- I can easily update the search list for new items, but I'm pulling my damned hair out over all the inconsistencies (seems like multiple damage values map to the same types of Leaves in the latest bukkit which broke selling leaves to shops).
If your matching engine would make it easy to support "oak leaves 4" without breaking support for shops that currently store the seemingly still-valid "oak leaves 0" (and without having to put the old shops through a conversion process) then I'll switch right now.

errr, i think you may have invalid item data if you're experiencing those things. There was a post about it somewhere.

Invalid item data where? Do you have any more information about the issue or that post so I can try to find it?

@zolcos - check this: https://bukkit.atlassian.net/browse/BUKKIT-390

Hi, I'm having trouble making bundle's i use /shop set sell cobble 5 64 and it just sets the price to 64 could you help please? much appreciated

Would it be possible to add a daily upkeep cost?

Yes, although I'm not too keen on the idea but it wouldn't hurt to have the option so I can add it to the to-do list

Thanks. Although, that guy's problem ended up being due to a plugin and I don't think that's what I'm seeing. I filed a report https://bukkit.atlassian.net/browse/BUKKIT-787
You may want to follow it -- if anything comes of it, it may help with your item recognition feature, and if it turns out I'm wrong then we'll at least have a laugh.

No more bundles, check the revised command list and changelog

@zolcos - hmm that's very very odd. have you checked if this happens in vanilla too?

I just checked and it doesn't happen in vanilla -- it does, however, happen in bukkit with 0 plugins all the way from world generation to shearing.

Zolcos, could you start prepping up to use Vault? The upcoming new event system wont support Register, and I doubt its going to get updated.

If that's true, I'll do it now. How do we know the new event system will break Register, though?

Some feature requests:
1. An option for the old money-duplication feature on shops with unlimited money.
2. A folder with individual log files for each shop, or even better,
3. A log for total goods moved by shop, with just single in and out numbers for each type of good, which increment to keep a small, easily-readable file

The biggest problem I currently have with CommandShops is collating all the data from the logs into useful information so I can get a better overall picture of how the economy is running. Currently I have to sift through the logs and add stuff up by hand, which is time-consuming, boring, and if the server gets popular enough, impossible. I'm sure #3 would be a pain, but #1 can't be too hard since it used to do that anyway. I used to set infinite-money shops to fictional owners, then I could check their account to see how much cash was flowing into the shop. Losing that feature is annoying.

Thanks for reading.

I'd like to ask all server admins who use CommandShops to try to independently verify the damage issue:
https://bukkit.atlassian.net/browse/BUKKIT-787
Getting to the bottom of it will speed development of this plugin, and your reports on that ticket will make it stand out more to the Bukkit team.

#2/3 is already in the works -- I've wanted to store better transaction logging since I started, mainly for the purpose of letting shop owners query it in-game. The move to SQL (which will happen first) will also give server admins a lot of power to wrangle this information.
As for #1 I want to avoid making the config file too intimidating. Given that you were only using this feature for informational purposes, the increased reporting capacity may eliminate the need for it. If there are other reasons to keep it, though, it's still a possibility.

@Sleaker
I looked at the code for Vault and noticed that you avoided the Leaves problem by defining all the damage values as separate items, so #2 is "Birch Leaves Block" while #6 is just "Birch Leaves". So it looks like you copied the Bukkit values maybe without realizing they were different than vanilla. Unless I'm missing something and those are actually distinct items.

I do like how you switched from manually defining the Item IDs to using the Material.* constants. I wish Bukkit had a similar facility for the damage values, because if there was nothing left to manually define then we could just point to Bukkit regarding any inconsistencies (as right now, changing the list of valid values can break shops)

@zolcos - not sure I wrote all of that in there. It could be just a patch-fix for oddities with Bukkit too because someone was having the same issue :-/

Because the latest Dev builds already have the new system in place. And it breaks Commandshops and Registar(also most of all the public plugins for that matter )

It looks like that is going to be the only real stable solution. A few duplicates are a small price to pay for preventing incompatibilities.

Ah! You're right. To be fair, though, I don't think any economy plugins have updated to work with it yet, so no econ-using plugins have a chance.

Can someone please update this to at lease 1.1R5?

Thanks
-OstlerDev

Zolcos is still around and will be updating. Just be patient. You aren't required to run R5/R6.

OK I actually can't get Register working in the latest CB. Meanwhile, Essentials and Vault are updated for R6.
So tonight I'll pull myself away from Warband and get to work switching to Vault, SQL, and R6.

I am most likely going to donate after it gets updated

If you ever have time you should definitely move this to Dev. I loved LocalShops and Im glad to see your reviving it, an amazing plugin at that!

Cheers to you mate!

Do you think that you could put out a dev version? All my players are getting really mad at me :/

It's not that simple man give me a couple days

@zolcos

What mod of Warband ?

Register version: 1.6 and Iconomy version: 6.0.9b work on 1.2 (2036)
Hopefully MySq is not being forced on us to use it and the old system will still be in place.
Actually as bukkit has been slowing updating more older plugins for 1.1r6 are starting to kick in.

This is by far the best shop plugin since old heyo signshops, and has been on my server for a year easy.

MySQL will be optional. The old system is being eliminated in favor of SQLite which will be the new default and work basically the same as the old system (i.e. zero-configuration)

I still like vanilla tbh

Good, Sqlte is doable, I personally love mysql but many do not, and many people actually go out of the way to find sqlte and flatfile db's. Glad to hear your keeping alternatives instead of forcing mysql like so many have.

yeah Warband is a good game still