Inactive [EDIT/FUN] SecretPassage v1.6 - Create Structures That Can Disappear [1.2.5-R4.0]

Error. Big time... let me look into it.

ok cuz i didnt think i was doing anything wrong because in my plugins my secretpassage is a copy with a (1) so i thought that mightve been the problem but i guess not.. although that shouldnt matter

Lol, awesome, this plugin is able to replace craftbook and falsebook, we can make gates and bridges, and of course, secret passages =P

edit: i suggest u to add stairs support =), at that way we can do anything with this plugin

Nope, the (1) simply means its a duplicate, probably due to downloading two so close together. I can't seem to replicate the creative -> survival locking down the passage though... what other plugins are you using? I want to get this stamped out ;P

I actually haven't looked into either one, but I'll look at em now, see what they're about

As far as stairs, it's currently a "hopeful" feature, due to how I have the replacement system going. I need to figure out how to take the player's orientation in relation to the block, then use that to properly rotate the stair's data before adding it to the passage. Completely doable, but currently beyond my knowledge of Bukkit. I've been looking into it though, same with doors and beds.

U should add something like this http://dev.bukkit.org/server-mods/rotate-things/ , maybe it work with this plugin

well i have quite a few plugins. but it isnt letting me do any of the passages again so i just downloaded the no perms one and it seems to be working just fine.. i can give u a list of my plugins if ud still like to know tho

Nope, that's all I need to know - I'll be working on splitting the permissions out of the main code and into a secondary class, that way I can add a config option to use permissions. If set to false, it will default to Op like the NoPerms version, that way we can squash this bug once and for all... not sure when it will be done though, but know that it IS being worked on.

@WingedSpear The only reason I'm hesitant to do that is the mental image of using it to build a spiral staircase, which would be quite tedious. I'm going to dig through the WorldEdit code on GitHub and see if I can find his formulas for rotation... wish me luck

ic, well its still awesome, its too easy make doors and bridges with this, i dont need redstone for find an spot in my building, its like....wireless+craftbook

ok i see. but now the only problem is that since for the most part im on a private server is with the no perms it lets everyone use the switches which can get kind of annoying. but nothing to bad. just gotta hide the switches. thanks for all ur help

hey idk if ud include this in wingedspears suggestion but could u add support for like iron bars and stuff. and glass panes? cuz none of those work for me. i think thatd be amazing

Those actually work - I just didn't update the config file when they were introduced. All you have to do is add their block IDs to the list of allowed blocks - doesn't have to be in order, so just tack em onto the end. And for your switch idea, I have a question for you and @WingedSpear - would you guys like me to add a restrict command while working on the permissions changes? Example:

After creating a pass, meatHead types "/spass restrict allow TacoMan". Because meatHead is the creator, he can always open his passages, but now only people named TacoMan can open them as well. If he wanted to add someone later, he would go into modifying the passage and type it again. Conversely, he can also type "/spass restrict deny Griefer90210" to block Griefer90210 from ever using the switches for that passage again.

If I do this, the easiest way is going to be more small files in your plugin/secretpassage folder - I can make another folder that maintains the white/blacklists for each passage. If the passage doesn't have one, it ignores it. If it does, it loads it at startup to prevent using too much memory while running.

ya i like the idea sounds awesome, and ok thanks for the info, and i was wondering if you could also make to where i can place a actual switch on the switch block so u can press it and open the passage so like i can make a gate that people can press the switch to open? you understand what im saying?

As counter-intuitive as it may sound, it's actually already possible - to a point. It will only function on right click, but you can replace a switch block with anything that you can click, be it a block, button, lever, redstone, even a flower if you want to... as long as you can select it, the plugin can recognize it. I just used solid blocks in the vids to make it easier, but consider that the first vid has a door where the switches should be. As far as placing a button ON the switch block, I'd just recommend moving the switch block out one square and replacing it with the button, or you could even put two switches side-by-side if you'd prefer....

Not sure if that makes sense, but sadly life has decided to get hectic today - will resume coding tomorrow, and if my description doesn't make sense, I'll gladly post screenshots once I'm back to my comp - just leave a response.

haha no it makes sense. i know it souns retarded haha i come off like that alot ^^ but nah im good dont worry about it ^^ sorry for all the semi-dumb questions haha

Ya thats a good one, for a pvp server u can hide ur stuff from enemys, but they are gonna be able to open passages with a lever...

dont have permission when im trying to test it, and im op...

anyway, anyone have a permission bukkit? i need

Please make it so you can use this in creative mode!!!!!!!!!!!!!!

The latest version makes it so you can create the passages in creative mode but the switches fail.

The permissions fixed version you posted makes it so you can use the switches in creative mode but you cannot create any passages.

so im pretty sure you probably already answered this but maybe one directed at me will help me understand better, but i have downloaded the most recent version and it works great for everyone on my server except ops it wont allow us to activate the passages and we are using Permissions bukkit 1.2 maybe something in there is messing it up? if you could help me out here i'd appreciate it, we are trying to run an RP server and it would be awesome if we could get this up and running for ops, thanks!

For some reason evrytime I make a switch and try to activate it, it sayz "your not allowed to active this passage"

@Toasticuss @leonofthewind @davis7457 It's the same error I've been fighting with for a few versions. I'm going to see if there's errors in my logic for activating passages, as the switches seem to be the only problem with the SuperPerms support. Sadly, been away from my PC for the last week, so coding has been stalled. I'll be working on this and adding the new version of listeners for the plugin as soon as I get home.

@Toasticuss The NoPerms version is actually built to work with a very old version of Bukkit (build 753), which predates the addition of Creative Mode. What's bizarre is that the code for the switches perfectly matches on both versions - the only change is me using .hasPermission() instead of .isOp(), which is why I'm flabbergasted as to why it's failing so spectacularly.

A big problem-you forgot to make it so that OPs can use it too.
Because i created a door and cant use it

in SPPlayerListener you have a problem with the code of the onPlayerInteract event, it should be:

1) check if event is cancelled first
2) check if right clicked
3) than to do the rest

Also I don't really know why but with '*' I get the message you are not allowed to activate switches.

ok. I know why... line 229 in SecretPassage checks for rights secretpassage.deny.whatever... which I have, you should probably also check if people have the "admin" rights in this statement, if they have both ignore that part.

that shouldn't happen because I have both permissions you are looking for..

nevertheless the code flow is wrong as it will check this for every playerinteract..

haven't really looked into the code but also it looks like SwitchBlock is missing the world information

@krix @Toasticuss @leonofthewind @Davis @Untar1 I've made changes to the code, as well as the specific part that is giving me grief. Please test 1.5 if you can, let me know if you still can't activate passages as Op (I checked it as both Op and a standard player, both for my passages and another player's).

Thank you for the help with the code, it pointed out some bad errors I had made (including the fact that anyone unable to use the plugin would be hit with a deny message whenever they right clicked anything...). I'm hoping the change will squash the bug on activating passages, but let me know if it doesn't. What worries me is that the message should only show up when you have a specific permissions node (secretpassage.deny.thenameofthepassage), which is generated at run-time and set to false by default... any idea why it might be firing off without that? (I already added the admin check to it, for safety's sake. There's an "antilockout" perm that I added a while back due to plugins that gave all permissions nodes to users)

Also, I'm working on the black/whitelist feature. Do you guys want it to work as both, or should I restrict to one? My current plan is to allow either, but you can change it by using the opposite command...

the code in the main plugin class didn't had that check IIRC... I'm using PEX which has the old '*' which means EVERYTHING... so also the deny rights if you check with hasPermission ..

I know that using '*' is stupid, but I use it for testing... otherwise I have only limited rights (haven't tested that though).

concerning if statements you should also try to test the stuff first which fails more often... saves cpu cycles.. and especially with permissions that can be a bunch... there is a plugin which does test how long it takes to figure out permissions in general

You're correct - I added it back in. Not sure when I removed the check, as that's why the permission is there in the first place...

I'll see what I can do about revamping the IF statements, but as a general rule the entire thing needs some cleaning... Thank you for going through the code to help, and I'm sorry for the lack of structure.... self-taught, so I build it in a way that makes sense to me....

Im an OP
and when i click it, it says im not allowed
but normal people can do it..

I want the exact opposide of this.

how do i do that?

wait for a fix, see the last 3 - 4 messages above.

there is nothing wrong with being self-taught.. I just started coding again 3 month ago after more than 20 years not looking at code... and that was Turbo Pascal.

Grab v1.5a and you shouldn't have issues with activating. However, the plugin is designed to allow anyone the ability to activate passages, and there isn't a full lockout option without using a SuperPerms plugin. If you use one, just give your players "secretpassage.lockout" and they won't be able to access any facet of the plugin. Or, you can use the /spass toggle (Passage) command to activate them, and remove all the switches for your passages. Ops by default have access to it, while players do not, so you could lock them out that way as well.

I actually don't know what Turbo Pascal is used for. I've heard the name, but only in passage from an old teacher who introduced me to coding by handing me a floppy disc with Quick Basic on it... I've looked at your plugins and they're all very impressive - any tips on how to improve this one?
--------------------
And as before: Do you guys want the restriction options to function as whitelists, blacklists, or have the option for both? I'm hoping to get input from users before just coding it and throwing it out, that way it matches your needs...

Will there be an update for it?