Solved Error That I Cannot Figure Out In My Code. Please Help!!!

Hi. i am working on a plugin that gets the block of the player. here it is:

Code:java

package plugins.mkezar;
 
import net.minecraft.server.v1_7_R3.Material;
 
import org.bukkit.Bukkit;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerChangedWorldEvent;
import org.bukkit.event.player.PlayerMoveEvent;
import org.bukkit.plugin.java.JavaPlugin;
 
public class TrailPlugin extends JavaPlugin implements Listener {
 
@Override
public void onEnable() {
    Bukkit.getServer().getPluginManager().registerEvents(this, this);
 
    }
 
    @EventHandler
        public void onPlayerWalkEvent(PlayerMoveEvent event) {
        Player player = event.getPlayer();
        player.getLocation().add(0,-1,0).getBlock();
        block.setType(Material.GRASS);
    }
}

For some reason though, It does not like

Code:java

block

in

Code:java

block.setType(Material.GRASS);

Please Help!!! i dont know how to fix the block. thank you

LCT10 Laxer21117

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

You never defined block. The compiler doesn't know what block is.

 

Learn java please!
You did not state what block is. You put down

Code:java

 player.getLocation().add(0,-1,0).getBlock();

not stating what that was, you should use this:

Code:java

Block block = player.getLocation().add(0,-1,0).getBlock();

 

braincramp. thanks. i do know java btw i was just braincramping like crazy because its really late and im getting really tired. thanks doe

 

mkezar, using the player move event is EXTREMELY resource intensive and should not be used unless absolutly necessary. Creating a seperate thread that runs every 20 ticks would likely be more appropriate.

 

Why import net.minecraft.server.v1_7_R3.Material when you can import org.bukkit.Material?

o3o

 

Not really, you should know that there is also a considerable amount of code that runs inside CraftBukkit executed every single time a player moves and all PlayerMoveEvent does is allow plugins to hook into this. It is true that reflection is used to call methods in event listeners, but if you have no code there, the amount of time spent doing this will be nearly zero. Usually the issue is not in listening to PlayerMoveEvent itself but actually that the developer gets careless and does all kinds of stuff which actually becomes an issue.

You can also check if the code is actually a trouble point by doing some actual profiling (/timings) and see how much time the event actually wastes for the number of players with which you test.

OP's code does not do too much or waste resources at all and if I remember correctly if a block is already of a certain type CraftBukkit won't waste time sending out a block change to set it again.

 

i fixed it all. thanks

 

mkezar When you're doing the player move event, I highly recommend checking they are atually moving a whole block. You can do this by adding this code at the top of the onPlayerWalkEvent method:

Code:java

        if (event.getTo().getBlock() == event.getFrom().getBlock())
            return;