get random String from List

Hi guys,
i want to get a random String from a StringList but it dont work.
can anyone help me?

and btw sry for my bad english.

Code:java

 @Override
public boolean onCommand(CommandSender sender, Command command, String label, String[] args) {
Inventory inv=null;
 
if(command.getName().equalsIgnoreCase("test")){
Player p = (Player) sender;
File ZombieFile = new File("plugins/ProjectRPG/Lib/MobNames.yml");
FileConfiguration ZombieConfig = YamlConfiguration.loadConfiguration(ZombieFile);
List<String> namesArray = new ArrayList<String>();
namesArray = ZombieConfig.getStringList("List.Zombies");
Zombie z = (Zombie) p.getWorld().spawnEntity(p.getLocation(), EntityType.ZOMBIE);
int random = new Random().nextInt(namesArray.size() -1);
String ZombieName = namesArray.get(random);
int randomInt = new Random().nextInt(100 -1);
int ZombieLevel = randomInt;
 
 
z.setCustomNameVisible(true);
z.setTarget(p);
z.setPassenger(p);
z.getEquipment().setHelmet(new ItemStack(Material.LEATHER_HELMET));
z.setCustomNameVisible(true);
 
z.setCustomName(ZombieName + " Lvl. " + ZombieLevel);
 
 
return true;
}
return false;
}

 

I'm sorry but your code was just too ugly looking not to format/fix for you.

Code:java

@Override
    public boolean onCommand(CommandSender sender, Command command, String label, String[] args) {
        if (command.getName().equalsIgnoreCase("test")) {
            if (!(sender instanceof Player)) {
                sender.sendMessage(ChatColor.RED + "You must be a player to use this command!");
                return true;
            }
            Random r = new Random();
 
            Player p = (Player) sender;
            File zombieFile = new File(getDataFolder().getAbsolutePath() + File.separator + "Lib" + File.separator + "MobNames.yml");
            if (!zombieFile.exists()) {
                sender.sendMessage(ChatColor.RED + File.separator + "Lib" + File.separator + "MobNames.yml doesn't exist :(");
                return true;
            }
            FileConfiguration zombieConfig = YamlConfiguration.loadConfiguration(zombieFile);
            List<String> namesArray = zombieConfig.getStringList("List.Zombies");
 
            if (namesArray.isEmpty()) {
                sender.sendMessage(ChatColor.RED + "There are no names in your name array :(");
                return true;
            }
 
            Zombie z = (Zombie) p.getWorld().spawnEntity(p.getLocation(), EntityType.ZOMBIE);
            String zombieName = namesArray.get(r.nextInt(namesArray.size() - 1));
 
            z.setCustomName(zombieName + " Lvl. " + r.nextInt(99)); // [name] Lvl. <0-98>
 
            z.setTarget(p);
            z.setPassenger(p);
            z.getEquipment().setHelmet(new ItemStack(Material.LEATHER_HELMET));
            z.setCustomNameVisible(true);
 
            return true;
        }
        return false;
    }

 

If it doesn't work try to do some debugging, if there is a stacktrace you should post that as well.


Try setting zombieName with this.

Code:

Random random = new Random();
String zombieName = namesArray.get(random.nextInt(namesArray.size())

 

Hi, I found a way to get a random String from the List.
thx for your help guys

Code:java

    @Override
    public boolean onCommand(CommandSender sender, Command command, String label, String[] args) {
    if (command.getName().equalsIgnoreCase("test")) {
    if (!(sender instanceof Player)) {
    sender.sendMessage(ChatColor.RED + "You must be a player to use this command!");
    return true;
    }
    Random r = new Random();
 
    Player p = (Player) sender;
    File zombieFile = new File("plugins/ProjectRPG/Lib/MobNames.yml");
    if (!zombieFile.exists()) {
    sender.sendMessage(ChatColor.RED + File.separator + "Lib" + File.separator + "MobNames.yml doesn't exist :(");
    return true;
    }
    FileConfiguration zombieConfig = YamlConfiguration.loadConfiguration(zombieFile);
    List<String> namesArray = new ArrayList<>();
    for(String zName : zombieConfig.getStringList("Names.Zombies")){
        namesArray.add(zName);
    }
 
    if (namesArray.isEmpty()) {
    sender.sendMessage(ChatColor.RED + "There are no names in your name array :(");
    return true;
    }
 
    Zombie z = (Zombie) p.getWorld().spawnEntity(p.getLocation(), EntityType.ZOMBIE);
    //String zombieName = namesArray.get(r.nextInt(namesArray.size() - 1));
    String zombieName = namesArray.get(r.nextInt(namesArray.size()));
 
    z.setCustomName(zombieName + " Lvl. " + r.nextInt(100)); // [name] Lvl. <0-99>
 
    z.setTarget(p);
    z.setPassenger(p);
    z.getEquipment().setHelmet(new ItemStack(Material.LEATHER_HELMET));
    z.setCustomNameVisible(true);
 
    return true;
    }
    return false;
    }