Solved Getting Horse Information

Hi, I am trying to get the store information about horses when you hit them with a snowball. So if you hit a black horse with a snowball, it will rename the snowball with the information about that horse. I am new to writing plugins so I get a lot of errors. This is all I have so far:

Code:java

    @EventHandler
    public void onEntityDamageByEntity(EntityDamageByEntityEvent event){
        Entity e = event.getEntity();
        Entity Damager = event.getDamager();
 
        if (e instanceof Horse){
            String variant = e.this.getVariant();
            String jump = e.this.getJumpStrength();
        }
    }

I get inside the if statement that say : "e cannot be resolved to a type"
I don't know how to target a specific horse. Thanks!

 

e.this => e

 

andstu e.this is not syntactically correct... Cast e to Horse and use that for the variant and jump strength

 

fireblast709 and@Zarkopafilis provided :

Code:java

@EventHandler
public void onEntityDamageByEntity(EntityDamageByEntityEvent event){
Entity e = event.getEntity();
Entity Damager = event.getDamager();
 
if (e instanceof Horse){
Horse h = (Horse) e;
String variant = h.getVariant();
String jump = h.getJumpStrength();
}
}

And I hope that's the solution to your problem,
~DevilMental

 

It says that variant can't be a string and it has to be variable type "Variant". Is there any way that I could change the variable type "Variant" to be a string?

 

*Horse h = (Horse) e;

 

andstu

Can a variant be a string?

 

ZodiacTheories If you mean: "Can I get a variant from string?" then yes.

 

It gives me an error if I say:

Code:java

String variant = h.getVariant();

So I was hoping there was a way to convert it.

 

daavko

I know, I was trying to get andstu to think but nvm

 

ZodiacTheories When I'm online, you can't ask others (but only you)

 

andstu
You just use the .toString() method from Variant

~DevilMental

 

andstu
The code DevilMental is incorrect. The horse variant is not a string but a variant, which is what your IDE is trying to tell you. Change the String type to Variant. I believe JumpStrength is a double (might be an integer). So you have to change String accordingly there as well.

Edit: DevilMental (Sorry for double tag) What is the purpose in converting a Variant and integer/double to a string? The starting code OP provided does nothing to suggest he requires a string, and your code only served to confuse him. By the way, it is unwise to try and invocate .toString() on a number of some kind, but instead use String.valueOf()

 

AoH_Ruthless That's just what I said, and the double is automaticly casted to String when initialized by a variable.
AoH_Ruthless Sorry my mistake so for the new code :
andstu

Code:java

    @EventHandler
    public void onEntityDamageByEntity(EntityDamageByEntityEvent event){
    Entity e = event.getEntity();
    Entity Damager = event.getDamager();
 
    if (e instanceof Horse){
    Horse h = (Horse) h;
    Variant v = h.getVariant();
    double jump = h.getJumpStrength();
    }
    }

~DevilMental

 

DevilMental
No, we did not say the same thing, but instead opposite. You are suggesting to OP to invocate .toString() on his variant variable. However, the OP doesn't require the variant in string format... So why go through the hassle and convert to String? Why not just make the variable with the Variant type?

 

AoH_Ruthless Made a mistake, sorry (jet lag from New York to France)

 

DevilMental
Apology isn't required, we're all friends here

 

AoH_Ruthless I needed a string so that I could store that information onto a snowball. I am trying to make a sort of pokeball plugin.

EDIT: Is the Variant variable type usable as a string? So I could name an item using a variant variable? DevilMental

 

andstu So you could get the name of the variant by

Code:java

// Considering Variant v;
v.name();
//And getting from a string
Varient fromString = Variant.valueOf(varientString);

Tag me if you need me
~DevilMental

 

Sorry for all the questions DevilMental . I can't find a way to set or find the speed of a horse. Is that because there isn't a way?

Code:java

double health = h.getMaxHealth(); //The error says this is ambiguous is that ok?

Is this error ok? Thanks for all of your help.

I don't think any of this is working. I don't know if my logger isn't working (did I do something wrong with that?), or if it just doesn't work... I thought this was the best way to have it drop a snowball but that doesn't appear to be working either. Here is my code so far:

Code:java

import java.util.logging.Logger;
 
import org.bukkit.Material;
import org.bukkit.entity.Entity;
import org.bukkit.entity.Horse;
import org.bukkit.entity.Horse.Variant;
import org.bukkit.entity.LivingEntity;
import org.bukkit.entity.Player;
import org.bukkit.entity.Snowball;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.EntityDamageByEntityEvent;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.ItemMeta;
 
public class PokeballListener implements Listener{
    public final Logger logger = Logger.getLogger("Minecraft");
 
    @EventHandler
    public void onEntityDamageByEntity(EntityDamageByEntityEvent event){
        Entity e = event.getEntity();
        Entity Damager = event.getDamager();
        if (Damager instanceof Snowball) {
        if (e instanceof Horse){
            Horse h = (Horse) e;
            Variant variant = h.getVariant();
            String v = variant.name();
            this.logger.info("Horse type " + v);
            double jump = h.getJumpStrength();
            this.logger.info("Jump Strength " + jump);
            boolean tamed = h.isTamed();
            this.logger.info("Is Tamed? " + tamed);
            //double health = h.getMaxHealth(); //The error says this is ambiguous is that ok?
            //how to find speed of a horse?
                String name = h.getCustomName();
            if (name == null) {
                name = "Horse";
            }
            this.logger.info("Name: " + name);
            ItemStack snow = new ItemStack(Material.SNOW_BALL);
            ItemMeta m = snow.getItemMeta();
            m.setDisplayName((String) name + "\n" + (String) v +"\n"+ jump +"\n" + tamed/* +"\n"+ health*/);
            snow.setItemMeta(m);
            h.getInventory().addItem(snow);
        }
        }
    }
 
 
}

AoH_Ruthless
DevilMental

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

andstu
Build against bukkit, not craftbukkit (that will remove the ambiguity). You also need to mess around with attributes to modify or retrieve horse speed.

 

AoH_Ruthless

Thanks for the tip about the ambiguity. Could that be why nothing is working or I\s there something wrong with my logger? Because when I hit a horse with a snowball, nothing happens so I don't even know where to start debugging.

 

andstu
Some weird things with your display name setter line

• You are casting String to name .. it's already a string.
• You are casting String to v, it too is a string.
• 'tamed' is a boolean value, not a string. You can't concatenate boolean values. Use Boolean.toString(boolean) -Scratch that, I forgot the compiler automatically concatenates it by invoking .toString()

 

AoH_Ruthless DevilMental Where could I download "Bukkit"? I can only find the craftbukkit builds. Also I don't think that the onEntityDamageByEntity event is being activated because nothing is being logged to the console. It doesn't even log when I shoot it with an arrow... Am I using the wrong event? Thanks. Here is my updated code:

Code:java

package me.atlightning11.Pokeball;
 
import java.util.logging.Logger;
 
import org.bukkit.Material;
import org.bukkit.entity.Entity;
import org.bukkit.entity.Horse;
import org.bukkit.entity.Horse.Variant;
import org.bukkit.entity.Snowball;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.EntityDamageByEntityEvent;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.ItemMeta;
 
public class PokeballListener implements Listener{
public final Logger logger = Logger.getLogger("Minecraft");
 
@EventHandler
public void onEntityDamageByEntity(EntityDamageByEntityEvent event){
this.logger.info("ENTITY DAMAGED");
Entity e = event.getEntity();
 
Entity Damager = event.getDamager();
 
 
if (Damager instanceof Snowball) {
if (e instanceof Horse){
Horse h = (Horse) e;
Variant variant = h.getVariant();
String v = variant.name();
this.logger.info("Horse type " + v);
double jump = h.getJumpStrength();
this.logger.info("Jump Strength " + jump);
boolean tamed = h.isTamed();
this.logger.info("Is Tamed? " + tamed);
//double health = h.getMaxHealth(); //The error says this is ambiguous is that ok?
//how to find speed of a horse?
String name = h.getCustomName();
if (name == null) {
name = "Horse";
}
this.logger.info("Name: " + name);
ItemStack snow = new ItemStack(Material.SNOW_BALL, 1);
ItemMeta m = snow.getItemMeta();
m.setDisplayName(name + "\n" + v +"\n"+ jump +"\n" + tamed/* +"\n"+ health*/);
snow.setItemMeta(m);
org.bukkit.World world = h.getWorld();
world.dropItemNaturally(h.getLocation(), snow);
}
}
}
 
 
}
 

 

andstu http://dl.bukkit.org/downloads/bukkit/

 

andstu Did you register your events? You are using the right event for checking damage

 

andstu The ambiguity can be removed by :

Code:java

Damageable d = (Damageable) h;
// then you can
d.getHealth();
d.getMaxHealth();
// Etc...

Also in your code, you set the displayname of the snowball with the information separated by \n but I think the \n are ignored. The bukkit.jar can be found at http://dl.bukkit.org/downloads/bukkit
The speed of a horse (I think) is constant. And about the logger, instead of taking th Minecraft Logger, take the logger from the principal class (that extends JavaPlugin), by :

Code:java

MainClass.getLogger(); // Replace MainClass by your
                      // main class that extends
                      // JavaPlugin

Hope that helps, tag me if you need help again
~DevilMental

 

DevilMental You were right about it ignoring the "\n" Do you know if there is a way for me to add linebreaks in the names? That was the only way that I could think of. Again Thanks for all your help.

 

andstu Add the information in a List<String>, and set this string as the item's lore. Then, when triggered, get the information from the lore, to spawn the same kind of horse

Hope that helps,
~DevilMental

 

AoH_Ruthless Would this work to find the speed of a horse?

Code:java

 
AttributeInstance s = ((EntityInsentient)((CraftLivingEntity)h).getHandle()).getAttributeInstance(GenericAttributes.d);
            double speed = s.getValue();
//h is the horse that got hit with a snowball