Going Insane. Cant find the issue!

So my code as you see is supposed to work as a Duel Pvp plugin. Now I can get the command stuff to work and adding players to the Queue list array but nothing after that. If you have the time to can you please tell me what is going on.

DOWNLOAD LINK: <Edit by Moderator: Redacted mediafire url>
REQUIRES BarAPI: [HERE]

CRAFTBUKKIT VERSION: [HERE]
CODE:

Code:java

package net.dualpvp.main;
 
 
import java.util.ArrayList;
import java.util.Random;
import me.confuser.barapi.BarAPI;
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Location;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.PlayerDeathEvent;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin implements Listener
{   
//-------------------------------------------------------------------------   
ArrayList <Player> duellist = new ArrayList<Player>();
ArrayList <Player> queuelist = new ArrayList<Player>();
ArrayList <Player> duelone = new ArrayList<Player>();
ArrayList <Player> dueltwo = new ArrayList<Player>();
//-------------------------------------------------------------------------
Player r1;
Player r2;
//-------------------------------------------------------------------------
ChatColor red = ChatColor.RED;
ChatColor green = ChatColor.GREEN;
ChatColor blue = ChatColor.BLUE;
ChatColor white = ChatColor.WHITE;
ChatColor gray = ChatColor.GRAY;
ChatColor daqua = ChatColor.DARK_AQUA;
ChatColor dgray = ChatColor.DARK_GRAY;
//-------------------------------------------------------------------------
Location spawn = new Location(Bukkit.getWorld("world"), 0, 40, 0);
Location duel1loc1 = new Location(Bukkit.getWorld("world"), 0, 60, 0);
Location duel1loc2 = new Location(Bukkit.getWorld("world"), 0, 60, 0);
Location duel2loc1 = new Location(Bukkit.getWorld("world"), 0, 80, 0);
Location duel2loc2 = new Location(Bukkit.getWorld("world"), 0, 80, 0);
//-------------------------------------------------------------------------
String dp = ChatColor.AQUA + " • " + ChatColor.RESET;
 
public void onEnable(){
    System.out.println("---------------------");
    System.out.println("DuelPvP Main Enabled!");
    System.out.println("Current Version: 1.3 ");
    System.out.println("---------------------");
    getServer().getPluginManager().registerEvents(this, this);}
 
public void onDisable(){
    System.out.println("----------------------");
    System.out.println("DuelPvP Main Disabled!");
    System.out.println("Current Version: 1.3  ");
    System.out.println("----------------------");}
 
@EventHandler
public void onPlayerJoinEvent(PlayerJoinEvent event){
    event.setJoinMessage(dp + ChatColor.GRAY + event.getPlayer().getDisplayName() + " has joined DuelPVP!");}
 
 
@Override
public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args)
{
    Player p = (Player)sender;
    if (cmd.getName().equalsIgnoreCase("randomduel")) {
        if(queuelist.contains(p)){
        sender.sendMessage(dp + red + "You are already queued for a duel!");
            if (duelone.isEmpty() && queuelist.size() > 2 || dueltwo.isEmpty() && queuelist.size() > 2){
                DuelAreaEmpty();}}
        if(!queuelist.contains(p)){
        sender.sendMessage(dp + gray + "You have been queued for a duel!");
        queuelist.add(p);
            if (duelone.isEmpty() && queuelist.size() > 2 || dueltwo.isEmpty() && queuelist.size() > 2){
                DuelAreaEmpty();}
    }return true; }
    return false;
}
 
@EventHandler
public void onPlayerDeath(PlayerDeathEvent event){
    if(event.getEntity() instanceof Player){
        Player player = event.getEntity();
        Player killer = player.getKiller();
        String KillBlurt = red + player.getDisplayName() + gray + " was defeated by " + green + player.getKiller().getDisplayName();
        if (duelone.contains(player) && duelone.contains(killer))
        {
            duelone.remove(player);
            duelone.remove(killer);
            player.teleport(spawn);
            killer.teleport(spawn);
            player.sendMessage(dp + "You have been defeated. You have lost " + red + "10" + gray + " points!");
            killer.sendMessage(dp + "You have one the battle. You gained " + green + "20" + gray + " points!");
            for(Player p : Bukkit.getOnlinePlayers()){BarAPI.setMessage(p, KillBlurt);}
        }
        else if (dueltwo.contains(player) && dueltwo.contains(killer))
        {
            dueltwo.remove(player);
            dueltwo.remove(killer);
            player.teleport(spawn);
            killer.teleport(spawn);
            player.sendMessage(dp + "You have been defeated. You have lost " + red + "10" + gray + " points!");
            killer.sendMessage(dp + "You have one the battle. You gained " + green + "20" + gray + " points!");
            for(Player p : Bukkit.getOnlinePlayers()){BarAPI.setMessage(p, KillBlurt);}
 
        }   
    }
}
 
public void DuelAreaEmpty()
    {
        r1 = queuelist.get(new Random().nextInt(queuelist.size()));
        queuelist.remove(r1);
        if (duelone.size() <= 1){
            duelone.add(r1);
            DuelOneTeleport();}
        else if (dueltwo.size() <= 1){
            dueltwo.add(r1);
            DuelTwoTeleport();
        }
 
        r2 = queuelist.get(new Random().nextInt(queuelist.size()));
        queuelist.remove(r2);
        if (duelone.size() <= 1){
            duelone.add(r2);
            DuelOneTeleport();}
        else if (dueltwo.size() <= 1){
            dueltwo.add(r2);
            DuelTwoTeleport();}
    }
 
public void DuelOneTeleport()
    {       
        r1.teleport(duel1loc1);
        r2.teleport(duel1loc2);
        r1.sendMessage(dp + "You have joined the 1v1 duel");
        r2.sendMessage(dp + "You have joined the 1v1 duel");
        r1.sendMessage(dp + red + "OBJECTIVE:" + gray + " Fight " + white + r2.getDisplayName() + gray + "!");
        r2.sendMessage(dp + red + "OBJECTIVE:" + gray + " Fight " + white + r1.getDisplayName() + gray + "!");
    }
 
public void DuelTwoTeleport()
    {
        r1.teleport(duel2loc1);
        r2.teleport(duel2loc2);
        r1.sendMessage(dp + "You have joined the 1v1 duel");
        r2.sendMessage(dp + "You have joined the 1v1 duel");
        r1.sendMessage(dp + red + "OBJECTIVE:" + gray + " Fight " + white + r2.getDisplayName() + gray + "!");
        r2.sendMessage(dp + red + "OBJECTIVE:" + gray + " Fight " + white + r1.getDisplayName() + gray + "!");
    }
 
 
}
 
 
 
 
 
 
 
 
 
 
 
 
 

Thank You! I really appreciate it!

Bump

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

ChrisStarr32
1. An arraylist is constructed without a space
so where you do ArrayList <Player>
should have no space

2. NEVER EVER NEVER EVER NEVER NEVER NEVER store player instances in any sort of Map. This will only ever lead to memory leaks. Alternatively, use a string as the player username, or if you are saving to a config file e.t.c., use player.getUUID()

3. When using the random() method, you could call the same player twice, making him duel himself. Use [arraylist].get(0), and .get(1), to get the first ones on the queue, this also means the ones who queue to duel first will be in the duel first.

4. The PlayerDeathEvent, e.getEntity() is a player, so you dont need to check for if they are a player.

5. Dont bump threads within 24 hours please

My suggestion is to add debug to your code (either using Bukkit.broadcastMessage() or this.getLogger().info()) to see where your code jams up,and then reply here with the stage it stops. Also it is good to post any errors in a spoiler in your thread, but I assume this isnt giving off any errors.

 

zero debug messages...