Solved Having problems with a for loo

I just don't know how to split the list into different strings of player names.
for example this is what i want it to do

Code:

owner
 
player1
 
player2
 
player3

what it does

Code:

owner
 
player1
 
player1
 
player1

This is my code

Code:java

 
for(Player player:Bukkit.getOnlinePlayers()){
if(plugin.permission.playerInGroup(player, string))
{
p.sendMessage(player.getName());
event.setLine(1, player.getName());
event.setLine(2, player.getName());
event.setLine(3, player.getName());
}
}
 

I know why it replaces the second and third lines i just don't know how to stop it

 

try break; ?

 

davidp027
If i break out of the code wont that just ignore the other lines that set the lines?

 

Pacothegint Firstly, I'm not sure how this is supposed to work if more than three players in the specified group are online. You wouldn't have enough room on the sign for that. But if three or fewer of the defined group are online, make a counter to keep track of how many lines you've gone over, so you can know which individual line to set (instead of setting all of them to each player you iterate over, like you're currently doing, hence the repeating player1).

Code:java

int lineCount = 1;
for(Player player : Bukkit.getOnlinePlayers()) {
    if(plugin.permission.playerInGroup(player, string)) {
        if (i > 3)
            break; // Break out of the loop so you don't get an exception if you try setting line 5 (line 4, in terms of arrays), since that line won't exist on the sign.
        p.sendMessage(player.getName());
        event.setLine(lineCount, player.getName());
        lineCount++;
    }
}

 

pookeythekid
wow how did i not think of that. Thanks for the help though.

 

Pacothegint No problem.