Solved [Help] .hasPermission problem

So I was adding a chat formatting feature to my server/plugin and when I debugs it, it displayed that Bukkit went into every if statement even when it is not true, so if you know where I got wrong, please help me thank you.

Code:

Code:java

if (p.hasPermission("CheeseEss.chat.player")) {
                String playerprefix = plugin.getConfig().getString("chat_format.group_prefix.player");
                playerprefix = playerprefix.replaceAll("&", "§");
                String playername = plugin.getConfig().getString("chat_format.group_name_color.player");
                playername = playername.replaceAll("&", "§");
                String playerchat = plugin.getConfig().getString("chat_format.group_chat_color.player");
                playerchat = playerchat.replaceAll("&", "§");
                String playerchatsign = plugin.getConfig().getString("chat_format.group_chatsign.player");
                playerchatsign = playerchatsign.replaceAll("&", "§");
                e.setFormat(playerprefix + playername + "%s" + playerchatsign + playerchat + "%s");
            }
            if (p.hasPermission("CheeseEss.chat.helper")) {
                String helperprefix = plugin.getConfig().getString("chat_format.group_prefix.helper");
                helperprefix = helperprefix.replaceAll("&", "§");
                String helpername = plugin.getConfig().getString("chat_format.group_name_color.helper");
                helpername = helpername.replaceAll("&", "§");
                String helperchat = plugin.getConfig().getString("chat_format.group_chat_color.helper");
                helperchat = helperchat.replaceAll("&", "§");
                String helperchatsign = plugin.getConfig().getString("chat_format.group_chatsign.helper");
                helperchatsign = helperchatsign.replaceAll("&", "§");
                e.setFormat(helperprefix + " " + helpername + "%s" + helperchatsign + helperchat + "%s");
            }
            if (p.hasPermission("CheeseEss.chat.builder")) {
                String builderprefix = plugin.getConfig().getString("chat_format.group_prefix.builder");
                builderprefix = builderprefix.replaceAll("&", "§");
                String buildername = plugin.getConfig().getString("chat_format.group_name_color.builder");
                buildername = buildername.replaceAll("&", "§");
                String builderchat = plugin.getConfig().getString("chat_format.group_chat_color.builder");
                builderchat = builderchat.replaceAll("&", "§");
                String builderchatsign = plugin.getConfig().getString("chat_format.group_chatsign.builder");
                builderchatsign = builderchatsign.replaceAll("&", "§");
                e.setFormat(builderprefix + " " + buildername + "%s" + builderchatsign + builderchat + "%s");
            }
            if (p.hasPermission("CheeseEss.chat.mod")) {
                String modprefix = plugin.getConfig().getString("chat_format.group_prefix.mod");
                modprefix = modprefix.replaceAll("&", "§");
                String modname = plugin.getConfig().getString("chat_format.group_name_color.mod");
                modname = modname.replaceAll("&", "§");
                String modchat = plugin.getConfig().getString("chat_format.group_chat_color.mod");
                modchat = modchat.replaceAll("&", "§");
                String modchatsign = plugin.getConfig().getString("chat_format.group_chatsign.mod");
                modchatsign = modchatsign.replaceAll("&", "§");
                e.setFormat(modprefix + " " + modname + "%s" + modchatsign + modchat + "%s");
            }
            if (p.hasPermission("CheeseEss.chat.admin")) {
                String adminprefix = plugin.getConfig().getString("chat_format.group_prefix.admin");
                adminprefix = adminprefix.replaceAll("&", "§");
                String adminname = plugin.getConfig().getString("chat_format.group_name_color.admin");
                adminname = adminname.replaceAll("&", "§");
                String adminchat = plugin.getConfig().getString("chat_format.group_chat_color.admin");
                adminchat = adminchat.replaceAll("&", "§");
                String adminchatsign = plugin.getConfig().getString("chat_format.group_chatsign.admin");
                adminchatsign = adminchatsign.replaceAll("&", "§");
                e.setFormat(adminprefix + " " + adminname + "%s" + adminchatsign + adminchat + "%s");
            }
            if (p.hasPermission("CheeseEss.chat.owner")) {
                String ownerprefix = plugin.getConfig().getString("chat_format.group_prefix.owner");
                ownerprefix = ownerprefix.replaceAll("&", "§");
                String ownername = plugin.getConfig().getString("chat_format.group_name_color.owner");
                ownername = ownername.replaceAll("&", "§");
                String ownerchat = plugin.getConfig().getString("chat_format.group_chat_color.owner");
                ownerchat = ownerchat.replaceAll("&", "§");
                String ownerchatsign = plugin.getConfig().getString("chat_format.group_chatsign.owner");
                ownerchatsign = ownerchatsign.replaceAll("&", "§");
                e.setFormat(ownerprefix + " " + ownername + "%s" + ownerchatsign + ownerchat + "%s");
            }

 

By default every permission is True for everyone unless set otherwise. Add your permission nodes to your plugin.yml and set the default for them(true, false, OP).

 

Gamecube762 Thank you

 

If I may...

Code:java

String permPar = "CheeseEss.chat."
String rankStr = "";
if (p.hasPermission(permPar + "player")) {
    rankStr = "player";
} else if (p.hasPermission(permPar + "helper")) {
    rankStr = "helper";
} else if (p.hasPermission(permPar + "builder")) {
    rankStr = "builder";
} else if (p.hasPermission(permPar = "mod")) {
    rankStr = "mod";
} else if (p.hasPermission(permPar = "admin")) {
    rankStr = "admin";
} else if (p.hasPermission(permPar = "owner")) {
    rankStr = "owner";
}
 
if (!rankStr.isEmpty()) {
    String prefix = plugin.getConfig().getString("chat_format.group_prefix." + rankStr).replaceAll("&", "§");
    String name = plugin.getConfig().getString("chat_format.group_name_color." + rankStr).replaceAll("&", "§");
    String chat = plugin.getConfig().getString("chat_format.group_chat_color." + rankStr).replaceAll("&", "§");
    String sign = plugin.getConfig().getString("chat_format.group_chatsign." + rankStr).replaceAll("&", "§");
    e.setFormat(prefix + " " + name + " " + "%s" + sign + chat + "%s");
}

I'm sure there are even better ways to optimize that, but the above is definitely much better than what you're using, now.

 

FerusGrim Thanks this would actually optimize my plugin a lot, since there are less variables and it is easier for other people to read Thank you