Solved help with /msg and /reply

hi i am trying to code messaging and replying to the last person who messaged you
code:

Code:java

if (cmd.getName().equalsIgnoreCase("message")
                    || cmd.getName().equalsIgnoreCase("msg")
                    || cmd.getName().equalsIgnoreCase("tell")
                    || cmd.getName().equalsIgnoreCase("whisper")
                    || cmd.getName().equalsIgnoreCase("w")){
                Player player1 = (Player) sender;
                if (args.length > 1){
                    Player player2 = Bukkit.getPlayer(args[0]);
                    if (player2 == null){
                        player1.sendMessage(ChatColor.GRAY + "Player not found.");
                    }
                    else{
                        StringBuilder str = new StringBuilder();
                        for (int i = 1; i < args.length; i++){
                            str.append(args[i]).append(" ");
                        }
                        String message = str.toString();
                        player1.sendMessage(ChatColor.GRAY + player1.getName() + " --> " + player2.getName() + ": " + message);
                        player2.sendMessage(ChatColor.GRAY + player1.getName() + " --> " + player2.getName() + ": " + message);
                        map.put(player2.getName(), player1.getName());
                    }
                }
                else{
                    player1.sendMessage(ChatColor.DARK_RED + "Usage: /msg <playername> <message>");
                }
            }
            if (cmd.getName().equalsIgnoreCase("reply") ||
                    cmd.getName().equalsIgnoreCase("r")){
                Player player1 = (Player) sender;
                if (args.length > 1){
                    Player player2 = Bukkit.getPlayer(map.get(player1.getName()));
                    if(player2 == null || !player2.isOnline()){
                        player1.sendMessage(ChatColor.GRAY + "Player not found.");
                    }
                    else{
                        StringBuilder str = new StringBuilder();
                        for (int i = 1; i < args.length; i++){
                            str.append(args[i]).append(" ");
                        }
                        String message = str.toString();
                        player1.sendMessage(ChatColor.GRAY + player1.getName() + " --> " + player2.getName() + ": " + message);
                        player2.sendMessage(ChatColor.GRAY + player1.getName() + " --> " + player2.getName() + ": " + message);
                        map.remove(player2.getName());
                        map.remove(player1.getName());
                        map.put(player2.getName(), player1.getName());
                    }
                }
                else{
                    player1.sendMessage(ChatColor.DARK_RED + "Usage: /msg <playername> <message>");
                }
            }[/i][/i]

the problem is when someone messages another guy and the other guy does /r <the message>
it sends both of the players a blank message, and if the message is more than one word long it says there is an internal error...
how can i fix this?

can anyone help

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Just two minor thing I noticed, in line 32, if the player is offling, he will be null. That means that calling the "isOnline"-method would cause a NullPointerException.
And if the message starts from the first character on, in line 37, you have to start from the FIRST (or "zeroth") argument - for(int i = 0; ...)

What does the stacktrace say, when you get an internal error?

 

I have a method for this, it's fairly simple.

Code:java

    /*
     * @param sender - The person who sent the message
     * 
     * @param receiver - The person who receives the message
     * 
     * @param msg - The arguments
     * 
     * @param reply - If the command is /reply or not.
     */
    protected void message(CommandSender sender, CommandSender receiver, String[] msg, boolean reply){
        String m = "";
        for (int i = (reply ? 0 : 1); i < msg.length; i++) {
            m = m + msg[i] + ' ';
            if(sender.hasPermission("mcrp.chat.color"))m = ChatColor.translateAlternateColorCodes('&', m);
        }
        sender.sendMessage("§6[§a" + sender.getName() + " -> §7" + receiver.getName() + "§6] §7" + m);
        receiver.sendMessage("§6[§7" + sender.getName() + "§a -> " + receiver.getName() + "§6] §7" + m);
    }[/i]

Example usage in a /message command

Code:java

// Command stuff
// target != null
message(sender, target, args, false);

Example usage in a /reply command

Code:java

// Same stuff
message(sender, target, args, true);

 

felixfritz
oh. i'm stupid.

vtg_the_kid
I did what you said, and the message shows up, but I still have another problem. When p1 messages p2, and p2 replies to p1, it works, but then if p3 messages p2, and p2 does /reply it makes p2 reply to p1. How can I fix this?
Code:

Code:java

if (cmd.getName().equalsIgnoreCase("message")
                    || cmd.getName().equalsIgnoreCase("msg")
                    || cmd.getName().equalsIgnoreCase("tell")
                    || cmd.getName().equalsIgnoreCase("whisper")
                    || cmd.getName().equalsIgnoreCase("w")){
                Player player1 = (Player) sender;
                if (args.length > 1){
                    Player player2 = Bukkit.getPlayer(args[0]);
                    if (player2 == null){
                        player1.sendMessage(ChatColor.GRAY + "Player not found.");
                    }
                    else{
                        StringBuilder str = new StringBuilder();
                        for (int i = 1; i < args.length; i++){
                            str.append(args[i]).append(" ");
                        }
                        String message = str.toString();
                        player1.sendMessage(ChatColor.GRAY + player1.getName() + " --> " + player2.getName() + ": " + message);
                        player2.sendMessage(ChatColor.GRAY + player1.getName() + " --> " + player2.getName() + ": " + message);
                        map.put(player2.getName(), player1.getName());
                    }
                }
                else{
                    player1.sendMessage(ChatColor.DARK_RED + "Usage: /msg <playername> <message>");
                }
            }
            if (cmd.getName().equalsIgnoreCase("reply") ||
                    cmd.getName().equalsIgnoreCase("r")){
                Player player1 = (Player) sender;
                if (args.length > 0){
                    Player player2 = Bukkit.getPlayer(map.get(player1.getName()));
                    if(player2 == null || !player2.isOnline()){
                        player1.sendMessage(ChatColor.GRAY + "Player not found.");
                    }
                    else{
                        StringBuilder str = new StringBuilder();
                        for (int i = 0; i < args.length; i++){
                            str.append(args[i]).append(" ");
                        }
                        String message = str.toString();
                        player1.sendMessage(ChatColor.GRAY + player1.getName() + " --> " + player2.getName() + ": " + message);
                        player2.sendMessage(ChatColor.GRAY + player1.getName() + " --> " + player2.getName() + ": " + message);
                        map.remove(player2.getName());
                        map.remove(player1.getName());
                        map.put(player2.getName(), player1.getName());
                    }
                }
                else{
                    player1.sendMessage(ChatColor.DARK_RED + "Usage: /r <message>");
                }
            }[/i][/i]

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Haven't tested it, but it might work if add the lines 43 and 44 as well before line 20. Also, I don't know, if I was clear enough before, but checking for !player2.isOnline() is going to cause a NullPointerException since Bukkit.getPlayer is going to return null, if player hasn't been found (line 32). In line 9, you did it correctly for some reason

 

felixfritz
oh that's because in line 32 i was checking if the player left before the guy /reply him, but I realized checking for null does that
i'm testing the stuff you said right now

it works sort of, but it stills says there is an internal error when i try to do /r when nobody has messaged me
current code:

Code:java

if (cmd.getName().equalsIgnoreCase("message")
                    || cmd.getName().equalsIgnoreCase("msg")
                    || cmd.getName().equalsIgnoreCase("tell")
                    || cmd.getName().equalsIgnoreCase("whisper")
                    || cmd.getName().equalsIgnoreCase("w")){
                Player player1 = (Player) sender;
                if (args.length > 1){
                    Player player2 = Bukkit.getPlayer(args[0]);
                    if (player2 == null){
                        player1.sendMessage(ChatColor.GRAY + "Player not found.");
                    }
                    else{
                        StringBuilder str = new StringBuilder();
                        for (int i = 1; i < args.length; i++){
                            str.append(args[i]).append(" ");
                        }
                        String message = str.toString();
                        player1.sendMessage(ChatColor.GRAY + "<" + player1.getName() + " -> "
                        + player2.getName() + "> " + message);
                        player2.sendMessage(ChatColor.GRAY + "<" + player1.getName() + " -> "
                                + player2.getName() + "> " + message);
                        map.remove(player2.getName());
                        map.remove(player1.getName());
                        map.put(player2.getName(), player1.getName());
                    }
                }
                else{
                    player1.sendMessage(ChatColor.DARK_RED + "Usage: /msg <playername> <message>");
                }
            }
            if (cmd.getName().equalsIgnoreCase("reply") ||
                    cmd.getName().equalsIgnoreCase("r")){
                Player player1 = (Player) sender;
                if (args.length > 0){
                    Player player2 = Bukkit.getPlayer(map.get(player1.getName()));
                    if(player2 == null){
                        player1.sendMessage(ChatColor.GRAY + "Player not found.");
                    }
                    else{
                        StringBuilder str = new StringBuilder();
                        for (int i = 0; i < args.length; i++){
                            str.append(args[i]).append(" ");
                        }
                        String message = str.toString();
                        player1.sendMessage(ChatColor.GRAY + "<" + player1.getName() + " -> "
                                + player2.getName() + "> " + message);
                        player2.sendMessage(ChatColor.GRAY + "<" + player1.getName() + " -> "
                                + player2.getName() + "> " + message);
                        map.remove(player2.getName());
                        map.remove(player1.getName());
                        map.put(player2.getName(), player1.getName());
                    }
                }
                else{
                    player1.sendMessage(ChatColor.DARK_RED + "Usage: /r <message>");
                }
            }[/i][/i]

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Code:java

 
                    Player player2 = Bukkit.getPlayer(map.get(player1.getName()));
                    if(player2 == null){
                        player1.sendMessage(ChatColor.GRAY + "Player not found.");
                    }
 

I think it might be because player1 is null in the map, doesn't exist, so check if the player1 is even in the hashmap.

 

Yeah, check first if the map contains the name of the player.

Code:java

if(!map.containsKey(player1.getName())) {
    player1.sendMessage(ChatColor.RED + "No one to reply to.");
    return;
}

 

Wolfey felixfritz k thanks
now everything works except
when you msg someone, and you do /reply, it doesn't reply to them
/reply only works if someone else messages you
how do i make it so it works even if you message someone else

 

Try putting this in your /msg code:

Code:java

 
map.put(player1.getName(), player2.getName());
 

 

Wolfey
oh lol i'm so bad at this
thanks dude

 

No problem!