Help with subcommands

I need help with subcommands,
I am trying to achieve this: /al enable/disable <player>
To enable/turn on, disable/turn off an effect for the specified player

Here is what I have come up with so far, I can't figure it out.

Player s = (Player) sender;
Player t = (Bukkit.getServer().getPlayer(args[0]));
// player as string
// "t"
String sname = s.getName();

String tname = t.getName();

if (cmd.getName().equalsIgnoreCase("al")) {
if (s instanceof Player) {
if (args.length == 0 || args.length < 2) {
s.sendMessage("Incorrect usage");
if (args[0].equalsIgnoreCase("enable")
|| args[0].equalsIgnoreCase("disable")) {
if (args[0].equalsIgnoreCase("enable")
&& args.length == 2) {
//code to affect player
if (args[0].equalsIgnoreCase("disable)
//code to affect player

(sorry unable to use syntax)

Thanks in advance.

 

First off, check if sender is player, args[0] exists, and that target isn't null before casting.
Second, remove the duplicate enable/disable checks, these are useless since you check them both anyway.
Third, save a collection of players with the setting enabled.

 

if (args[0].equalsIgnoreCase("disable"), You forgot the last ".

 

How about /al toggle <player> ?

 

Necrodoom ChipDev
Here is my original code:

Code:java

    @SuppressWarnings("deprecation")
    @Override
    public boolean onCommand(CommandSender sender, Command cmd, String label,
            String[] args) {
        Player s = (Player) sender;
        Player t = (Bukkit.getServer().getPlayer(args[0]));
        String sname = s.getName();
        String tname = t.getName();
        if (cmd.getName().equalsIgnoreCase("al")) {
            if (s instanceof Player) {
                if (args.length == 0 || args.length < 2) {
                    s.sendMessage("Incorrect usage");
                    if (args[0].equalsIgnoreCase("enable")
                            || args[0].equalsIgnoreCase("disable")) {
                        if (args[0].equalsIgnoreCase("enable")
                                && args.length == 2) {
                            s.sendMessage("Proper usage /al enable <player>");
                            t.addPotionEffect(
                                    new PotionEffect(
                                            PotionEffectType.WATER_BREATHING,
                                            100000, 1), true);
                            t.addPotionEffect(new PotionEffect(
                                    PotionEffectType.NIGHT_VISION, 100000, 1),
                                    true);
                            s.sendMessage("AquaticLife has been enabled for player "
                                    + tname);
                            t.sendMessage(sname
                                    + " has enabled AquaticLife for player "
                                    + tname);
                            if (args[0].equalsIgnoreCase("disable")
                                    && args.length == 2) {
                                t.addPotionEffect(new PotionEffect(
                                        PotionEffectType.WATER_BREATHING,
                                        100000, 1), true);
                                t.addPotionEffect(new PotionEffect(
                                        PotionEffectType.NIGHT_VISION, 100000,
                                        1), true);
                                s.sendMessage("AquaticLife has been enabled for player "
                                        + tname);
                                t.sendMessage(sname
                                        + " has enabled AquaticLife for player "
                                        + tname);
                            }
                        }
                    }
                }
            }
        }
        return false;
    }
}

Here is my new code:

Code:java

    @SuppressWarnings("deprecation")
    @Override
    public boolean onCommand(CommandSender sender, Command cmd, String label,
            String[] args) {
        if (cmd.getName().equalsIgnoreCase("l")) {
            Player p = (Player) sender;
            if (p.hasPermission("pmc.ligtning"));
            p.sendMessage(ChatColor.AQUA + "[AquaticLife]" + ChatColor.RED
                    + "Proper Use /al (enable/disable) <player>");
        } else {
            if (cmd.getName().equalsIgnoreCase("al")) {
                if (args.length == 1) {
                    if (args[0].equalsIgnoreCase("enable"));
                    Player p = (Player) sender;
                    if (p.hasPermission("pmc.reload"));{
                        Player t = (Bukkit.getServer().getPlayer(args[0]));
                        String pname = p.getName();
                        String tname = t.getName();
                        if (t.hasPermission("al.effect.waterbreathing"));
                        t.addPotionEffect(new PotionEffect(
                                PotionEffectType.WATER_BREATHING, 100000, 1, true), true);
                        if (t.hasPermission("al.effect.nighvsion"));
                        t.addPotionEffect(new PotionEffect(
                                PotionEffectType.NIGHT_VISION, 100000, 1, true), true);
                        p.sendMessage("AquaticLife has been enabled for player " + tname);
                        t.sendMessage(pname + " has enabled AquaticLife for player " + tname);
                    }
                } else {
                    if (args[0].equalsIgnoreCase("disable"));
                    Player p = (Player) sender;
                    if (p.hasPermission("al.command.disable"));{
                        Player t = (Bukkit.getServer().getPlayer(args[0]));
                        String pname = p.getName();
                        String tname = t.getName();
                        if (t.hasPermission("al.effect.waterbreathing"));
                        t.addPotionEffect(new PotionEffect(
                                PotionEffectType.WATER_BREATHING, 0, 0, true), true);
                        if (t.hasPermission("al.effect.nighvsion"));
                        t.addPotionEffect(new PotionEffect(
                                PotionEffectType.NIGHT_VISION, 0, 0, true), true);
                        p.sendMessage("AquaticLife has been disabled for player " + tname);
                        t.sendMessage(pname + " has disabled AquaticLife for player " + tname);
                    }
                }
            }
        }
        return false;
    }
}

I don't know how to check if the target is dull as I'm a newbie , it's probably the most obvious thing.
I thought it would be easier using (Bukkit.getServer().getPlayer(args[0]) for an extra argument instead of adding a whole list of players

 

Null*
if(getServer().getPlayer(args[0] != null) {
}

 

Aplenator
You didn't even read what 1Rogue Necrodoom or ChipDev said, indicate that you didn't understand what they are saying, or show any better code.

In fact, your code is even worse.

• You misspelled "al" in your command name.
• You have semicolons following if-statements.