Help with villager trading (I need some NMS pros)

Hello guys,

sorry for my bad english in advance because im from Germany. I´m currently writing a plugin which should change everything of a villager. But there is one thing which is impossible for me: making that the villager handles multiple players.

In vanilla minecraft:
If someone is trading with the villager, the GUI wont event open

In my edit: via CustomBukkit (I think you dont support that :/ but I dont understand NMS)
If someone is trading with the villager, the GUI opens for I think ca. 10 ticks and closes then at both players


How can I do it that if someone is trading with the villager the GUI opens / or stays opened for both players?



I didnt post the sources I already edited because I dont know if I am allowed to do that





Greetings,
D4rkDeveloper

 

You can listen to the PlayerInteractEntityEvent and see if the player click's on a villager, and the open your custom gui.
Du kannst auf das PlayerInteractEntityEvent hören, wenn der Spieler dann auf einen Villager klickt öffnest du das Inventar.

 

Hey,

thank you for your fast answer. I knew about that possibility (Google told me) but I wanted to code via NMS or Custom Bukkit, not over a plugin.


Greetings,
D4rkDeveloper

 

Here if found this this maybe will work, its from Fedmand (Link to the plugin)
Here is a tutorial on how you need to setup the Inventory Link

Code:java

import java.lang.reflect.Field;
import net.minecraft.server.v1_7_R3.EntityVillager;
import net.minecraft.server.v1_7_R3.ItemStack;
import net.minecraft.server.v1_7_R3.MerchantRecipe;
import net.minecraft.server.v1_7_R3.MerchantRecipeList;
import org.bukkit.craftbukkit.v1_7_R3.entity.CraftVillager;
import org.bukkit.craftbukkit.v1_7_R3.inventory.CraftItemStack;
import org.bukkit.entity.Villager;
import org.bukkit.inventory.Inventory;
 
public class Trades
{
  public static void setTrades(Villager v, Inventory inv)
  {
    EntityVillager villager = ((CraftVillager)v).getHandle();
    try
    {
      Field recipes = villager.getClass().getDeclaredField("bu");
      recipes.setAccessible(true);
 
      MerchantRecipeList list = new MerchantRecipeList();
 
      for (int i = 0; i < 9; i++) {
        if ((inv.getItem(i) != null) && (inv.getItem(i + 18) != null)) {
          if (inv.getItem(i + 9) != null) {
            ItemStack item1 = CraftItemStack.asNMSCopy(inv
              .getItem(i));
            ItemStack item2 = CraftItemStack.asNMSCopy(inv
              .getItem(i + 9));
            ItemStack item3 = CraftItemStack.asNMSCopy(inv
              .getItem(i + 18));
            list.a(new MerchantRecipe(item1, item2, item3));
          } else {
            ItemStack item1 = CraftItemStack.asNMSCopy(inv
              .getItem(i));
            ItemStack item3 = CraftItemStack.asNMSCopy(inv
              .getItem(i + 18));
            list.a(new MerchantRecipe(item1, item3));
          }
        }
      }
 
      recipes.set(villager, list);
    }
    catch (Exception exc) {
      exc.printStackTrace();
    }
  }
}

 

Thank you for your fast answer. I think that code should work but If I´m implementig that in my custom bukkit, how would I do it?

EntityVillager on GitHub/mc-dev


Greetings,
D4rkDeveloper

 

D4rkDev Since im not an NMS Pro i woud do it like that that you ad the stuff when you spawn the Villager

 

Hey,

thanks for your help since now . I think I will wait here for someone who knows NMS and Bukkit very good and.. yea

Greetings,
D4rkDeveloper

 

>Bump<

 

>Bump<

 

You could create a new EntityVillager whenever some player interacts with one of your custom villagers and copy the trades into that new villager and then force the player to open the trading menu of that new villager. That's how Shopkeepers is doing it: https://github.com/nisovin/Shopkeep...hopkeepers/compat/v1_7_R4/NMSHandler.java#L25

 

+blablubbabc thank you so much!!! Do you know how I can implement that into a custom Bukkit

 

<Bump>

 

Bump.

 

D4rkDev just get their MerchantRecipeList, clear it, and add in new MerchantRecipes. It ain't rocket science.