Solved How to remove recipes?

How does one remove a recipe?
getServer().resetRecipes() and getServer().clearRecipes() remove the recipes of all plugins if I'm correct.

Somewhere I found that I should the recipeIterator(), but I think I'm not using it correctly as there was no good example to be found.

Code:

public void removeRecipe(Recipe recipe){   
        while(getServer().recipeIterator().hasNext()){
            Recipe recp = getServer().recipeIterator().next();
           
            if(recp.equals(recipe)){
                getServer().recipeIterator().remove();
            }
           
        }

Now that I think of it... I try to use this to remove a ShapedRecipe, maybe that's the problem.

The thing is, the loop runs forever for some reason. Can anyone tell me how to remove (Shaped) recipes properly?

Shameless self-bump :3

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

This is the NoCraft plugin which allows you to disable recipes, maybe you should look into it.
https://github.com/BR-/NoCraft/blob/master/src/me/br_/minecraft/bukkit/nocraft/NCMain.java

From the look of it though it uses NMS coding, which I try not to touch myself.

 

Maybe this works;
If you know how to add a recipe,
Add one in the shape you want to disable,
RESULT = New ItemStack(Material.AIR);

 

In my experience the first recipe always overrides the second one.

 

Spectre93 there isn't a method to directly remove a recipe, but as you noted, you can use recipeIterator() from Server to iterate over all known recipes. Where you're going wrong is creating a new Iterator on every pass of your while loop, so hasNext() will always be returning true.

PHP:

Iterator<Recipe> iter = getServer().recipeIterator();
while (iter.hasNext()) {
  Recipe r = iter.next();
  // May not be safe to depend on == here for recipe comparison
  // Probably safer to compare the recipe result (an ItemStack)
  if (r == unwantedRecipe) {
    iter.remove();
  }
}


 

How stupid of me! Thank you very much!

For everyone interested in the solution:

PHP:

public void removeRecipe(ShapedRecipe inputRecipe){
        Iterator<Recipe> it = getServer().recipeIterator();
        while(it.hasNext()){
            Recipe itRecipe = it.next();
            if(itRecipe instanceof ShapedRecipe){
                ShapedRecipe itShaped = (ShapedRecipe) itRecipe;
             
                Map<Character, ItemStack> m = itShaped.getIngredientMap();
                Map<Character, ItemStack> n = inputRecipe.getIngredientMap();
             
                if(m.values().containsAll(n.values())){
                    String[] list = itShaped.getShape();
                    String listString = list[0] + list[1] + list[2];
                 
                    String[] list2 = inputRecipe.getShape();
                    String listString2 = list2[0] + list2[1] + list2[2];
                 
                    for(int i = 0; i < listString.length(); i++){
                        if(!m.get(listString.charAt(i)).equals(n.get(listString2.charAt(i)))){
                            getLogger().fine("Recipe not found.");
                            return;
                        }
                    } 
                    it.remove();
                    getLogger().fine("Recipe removed!");
                }
            }
        }
    }

This code can be easily adjusted to fit non-ShapedRecipes as well.
You may use this piece of code on one condition: if you have any improvements, let me know.

 

Code:java

@Override
public void onEnable() {
 
Iterator<Recipe> it = getServer().recipeIterator();
Recipe recipe;
while(it.hasNext())
{
recipe = it.next();
if (recipe != null && recipe.getResult().getType() == Material.BREAD)
{
it.remove();
}
}
}

I think its much easier to just test if the outcome of the recipe is the same material as what you want to block like did up there^.
Bread has three different shaped recipes(I think) and this saves time and code. Just like desht said.