How would I go about making this code shorter

Currently working on a Prison type plugin, and there are 4 classes (D, C, B, A). Each class has there own mining area, where they can break blocks and sell them, and every so often the blocks will respawn, allowing the players to start mining again.

So i'm doing this from scratch, without any WorldGuard, but just seeing the code for ONE of the classes IF checks makes me think I have some very poor code.

I am using vectors to define the breakable regions

A current solution I've been looking at is storing the vectors in a HashMap like so : minVector, maxVector and looping through them. But I don't want to save hashmaps.

Currently here is my initial check method

Code:java

public boolean inMine(Player p, Block b, Vector min, Vector max){
Vector v = new Vector(p.getLocation().getX(), p.getLocation().getY(), p.getLocation().getZ());
Vector x = new Vector(b.getLocation().getX(), b.getLocation().getY(), p.getLocation().getZ());
if(v.isInAABB(min, max) && x.isInAABB(min, max)){
return true;
}else{
return false;
}
}

This is untested, but im positive it will work all good and dandy.

Now for the long part

Code:java

if(inMine(e.getPlayer(), e.getBlock(), new Vector(ConfigManager.getInt("Mines.ClassD.MinX"), ConfigManager.getInt("Mines.ClassD.MinY"), ConfigManager.getInt("Mines.ClassD.MinZ")),
new Vector(ConfigManager.getInt("Mines.ClassD.MaxX"), ConfigManager.getInt("Mines.ClassD.MaxY"), ConfigManager.getInt("Mines.ClassD.MaxZ"))));

And basically, to check if a player is in any of the mines, its going to be that ^ multiplied by 4.

Laugh away, its 2AM and I currently can't think of any effective/efficient alternatives.

 

How about if ConfigManager had methods like this?

Code:java

getDMin() {
return new Vector(config.getInt("Mines.ClassD.MinX"),
                  config.getInt("Mines.ClassD.MinY"),
                  config.getInt("Mines.ClassD.MinZ"));
}

 

I too looked at this option, but thats still 8 individual Vector methods ill need, which seems unnecessary.

 

How about this?

Code:java

getMin(String m) {
return new Vector(config.getInt("Mines.Class" + m + ".MinX"),
                   config.getInt("Mines.Class" + m + ".MinY"),
                   config.getInt("Mines.Class" + m + ".MinZ"));
}
 
 
//Use:
ConfigManager.getMin("D")

 

Brilliant work, i think that will work just fine.
Thanks!

 

Code:java

//Code above here
return v.isInAABB(min, max) && x.isInAABB(min, max);

 

That would go in the boolean method?

 

http://jd.bukkit.org/rb/apidocs/org/bukkit/util/Vector.html#isInAABB(org.bukkit.util.Vector, org.bukkit.util.Vector)
it returns a boolean right?

Code:java

boolean willBeFalse = false && true;
boolean willBeTrue = false || true;
boolean thisBoolean = someBoolean && otherBoolean;

 

Affirmative teej107
Thanks for pointing that out, not sure how I missed it.

 

tommyhoogstra
It seems like your corner Vectors don't change in runtime, so why don't you simply load them on startup and save them in some variables instead of creating a new instance every time you need it?

 

It would be better to create a Mine object.