[INACTIVE][ADMIN/DEV] TCP interface for Bukkit - v1.2 [617]

Not connecting for me, build 50 says it's listening shows me connecting but in putty nothing happens.

I compiled this with build 61. Can you try it with that please?

Ok, I fail. When parsing the properties file, it was looking for 'pasword' instead of 'password'. Re-uploaded.

I suggest not using this plugin unless you have the latest build


I used it on build 44 and the server had massive lagg, Everything in console was doubled. and there where invisible monsters. people took steps and randomly got damage ( No Mobs on server).


Only use the latest build, For your sake and your users.

Otherwise great plugin.

I'm wondering if there are any .Net programmers around that could give me a little advise, this is vb.net, everything works until i go to send data; I never receive the authenticated method, it works in putty, so i'm clearly not sending the data properly, heres the source.

Code:

Imports System.Net.Sockets
Imports System.Text
 
Public Class Form1
    Dim ClientSocket As New System.Net.Sockets.TcpClient
    Dim serverSteam As NetworkStream

    Private Sub Button1_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Button1.Click
        Dim serverStream As NetworkStream = ClientSocket.GetStream
        Dim buffSize As Integer
        Dim Message As String = ""
   
        Dim inStream(10024) As Byte
        buffSize = ClientSocket.ReceiveBufferSize
        serverStream.Read(inStream, 0, buffSize) 'This waits for an input so would have to be in it's own thread.
        Dim b As String = System.Text.Encoding.BigEndianUnicode.GetString(inStream)
 
        MsgBox("Data from server: " & (b)) 'This works, gets the responce "welcome to bukkit please autheticate"

        Dim outstream As [Byte]() = System.Text.Encoding.BigEndianUnicode.GetBytes("pass password")
        serverStream.Write(outstream, 0, outstream.Length)
        serverStream.Flush()

        ReDim inStream(10024)
        buffSize = ClientSocket.ReceiveBufferSize
        serverStream.Read(inStream, 0, buffSize) 'the code freezes here, which means the above isn't getting sent.. =[
        b = System.Text.Encoding.BigEndianUnicode.GetString(inStream)

        MsgBox(b)

    End Sub

    Private Sub Button2_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Button2.Click
        ClientSocket.Connect("127.0.0.1", 6790) 'connect to the server
    End Sub
 
End Class

It already has password protection. Maybe you can suggest another way to secure this?

Gonna make a GUI in Visual Basic so you can track the killer's IP address?

Tried it, if correct password = PuTTY exiting.

It only closes a connection under the following conditions:
You use the quit command, duh.
You get the password wrong.
Bukkit loses connection to you.

Is it possible to get access to the save-all and stop commands.
Under a Linux server I have been finding that if I stop the server during a shutdown or its force killed the save activity does not happen. If there was a remote connection option for save and shutdown I can alter my init script to send the save then shutdown commands so everything saves and exits cleanly.

Well I was hoping to use it to make a basic chat bot to test the possbilities of this tcp plugin (this was litterly something I threw together.) I've notcied, if i loop the receive part, it *does* work, but receives weird chracters, so probablly an encoding issue somewhere..
will continue playing till i get it working.

[edit]
I've refined and tested, i'm now receiveing correctly, I'm just not sending. I'm not getting autheticated, if I try and send the password i get disconnected, because something isn't sending correctly. if i don't send the password, I can still receive the events, I just can't send any requests (bad bug btw, try connecting and not providing a password, you still get all the chats etc)

I have a request, could I have a debug build where you post to the console exactly what data is being received by your plugin (from connected ports) during all phases including authentication, that way I can try and get this working, and maybe release something.

[edit #2]

Isolated your bug for you.

If you authenticate once, all clients connecting afterwards are automatically authenticated to the server, which is why I could receive things without having to log in.

still want that debug build though, because I'm still not sending packets to you right (or you're not dealing with them correctly, or something, but having a debug on the server would make it 1000 times easier)

[Edit #3]
I figured out why it "wasn't" sending, it's because it required you to send the equiv of "\n" before it'll evaluate your line, which makes sense as It was designed for putty, but now it gives me "Wrong Password" even though the password is right.. Still waiting on that debug

I'm currently working on a project that needs multiple php process to be able to share a job queue, to do that I have a broker script that accepts tcp connections on the internal ip address to add/get jobs from the queue. For auth I have a challenge system. First the CLIENT asks the server to prove it is the server they want to talk to by sending a challenge, this challenge gets hashed with a mutually known key and passed back. If this matches the clients own idea of the hash then the client asks for a login key - this is a random hash that is created for that specific request and held in memory. To login the client now has to hash this login key with another mututally shared password key and send it back. this way the clients and server are sure of who they are talking to and the passwords never get sent over the socket. Traffic is not encrypted on mine because its only ever on the local interface but like EvilSeph said, you should think about doing that, too.

I'll have a go at adding encryption.

An alternative route is to only accept connections on a particular IP, that could be configured. E.g. 127.0.0.1
If you do add encryption, could you make it optional maybe?

Of course.
--- merged: Jan 17, 2011 8:05 PM ---
ShivalWolf, I do not think those commands can be called from within a plugin.

Danny, the bug you reported in edit two should be fixed now. The second one is not a bug, that's deliberate. You must send a new line character before it'll read as a line.

Edit: Sorry I messed that up. Uploading in a sec...
Edit 2: Try now.

No encryption. Couldn't find an easy way to do it.

It is a shame that those commands can't be reached by a plugin. I may have to look myself.

As for encryption unless you wanted to break basic access via putty yeah you would have alot of trouble. When you add encryption you would need a client that worked with that encryption. You could try using SSL but then you would need a way to talk SSL to the plugin.

Hmmm this plugin has me thinking of actually trying to write a plugin. I will have to wait till after work though. tcp/udp socket bound to localhost and some form of web interface comes to mind.

Obviously if I did get encryption working I'd supply a client to replace PuTTY that is compatible with my encryption.

I have used this (or similar) http://www.exampledepot.com/egs/javax.net.ssl/server.html - allows you to create a java SSL socket using a self signed certificate.
May help you Not sure if its compatible with bukkit however but it might be a place to start.

Added pm command, updated files.

Added invprobe and invremove commands, commented unused code.

Hi, i have a problem, whenever i disconnect it does not seem to close the session, cus when i loggin next time i get the outputs 2 times, so if some1 type a chat message i will se it twice.
And now i see it 5 times, seems to get worse every time i reconnect, the quit command does not seem to help.
What shoud i do? Can i restart the plugin whitout restarting my server?

this looks very promising. would be awesome if this plugin could add full remote console functionallity to bukkit.
as far as encryption goes: i agree that sending a plain txt password is not the best idea, but that way it is fairly easy to build your own client and securing it is not really rocket science. just let it listen on localhost and for the outside world put up a ssl tunnel.

I think I know which bug you were talking about, and that was fixed already. Try re-downloading it.

Either Bukkit itself or the General plugin allows you to enable/disable/reload plugins on-the-fly.
--- merged: Jan 19, 2011 3:52 PM ---

This is something I haven't been able to do yet - no Bukkit dev has talked to me on the subject.

Yes, that's a good way around the plain text thing.

On the subject of encryption, did you know that IRC clients send your commands (i.e. nickserv identify) via plain text unless you're using SSL? Most people aren't. Minecraft also seems to send your account password over plain HTTP to minecraft.net.

May I make an observation here?

Instead of a RAW TCP connection (and all the issues that come with that), why not consider a RESTful or XMLRPC interface? This would make handling requests a bit easier as well as handling encryption (via SSL) quite simple. The hardest part in this case would be to come up with a decent basic set of commands that can be sent to the interface that would be considered useful.

I still have problem whith the chat and other stuff in the console being presented to me twice and sometimes even more if i reconnect whitout using quit command. And yes i have updated.
Also is it possible to be multiple users to be logged in on the thing? Cus i want my mods to use this to be able to kick greifers.

Sorry, I have no experience with that.

I think I've fixed it. Compiled against CraftBukkit snapshot #106 this time.

Yes, more than one connection can be opened to the server.
Edit: Wait... wut. I typed in a command in one connection and it came up in another. xD
2nd edit: I see what's going wrong, but I don't know how to fix it.
3rd edit: Oh, it involved using "this."... Lol. Anyway, new version going up.