[INACTIVE][ADMIN/DEV] TCP interface for Bukkit - v1.2 [617]

I had a few suggestions.

1. When building a response string (like invprobe for example) use StringBuilder (or StringBuffer if you need thread synchronization on a single string) because it will greatly decrease memory and cpu usage. Doing 8 string concats is slow!

2. I know it is a lot of work but try looking at Java's NIO package for doing the networking. Again, a much more performant implementation of networking - also if you are going to do this, you should do some reading on IOCP.

3. If you want to allow for easier programming against this and better performance you should try to first queue up all string data and do one send instead of sending a whole bunch of lines - you should also consider sending the data in a standard format, like JSON... for example when 'getplayers' is requested you generate an array that is easy to parse rather than sending a ton of lines of "player name=". Parhaps something like " Players = { Joe, Frank, Bill, Susie } "

1. I don't see how that would decrease RAM or CPU usage at all.

2. I'll take a look.

3. I do agree on buffering things like the getplayers and invprobe command outputs then sending it all in one go. As for JSON, I can't find Java's equivalent of PHP's json_encode function.

playercount, port and maxplayers commands added.
You do not need to be authenticated to use those commands.
getplayers changed so you do not need to be authenticated.
Note that using a wrong command while not authenticated still causes a disconnect.
Removed the "Plugin enabled" on startup.

Hi,
very nice feature ! i have try it with a php script and it's work !
I can now work on a PHP web admin
It is possible to add server commands (like reload ? etc.)
Thank you very much
Regards

I've looked into the possibility of things like that and as far as I can see, that's not possible without making the server create a new socket to drdanick's Server Remote Toolkit.

Fixed invadd command, added eventtoggle command.

Cool, got this running on my server.

Feature request: Can you echo commands made over TCP onto the console? It would help testing things, and also make sure that no one's using the TCP without being known/detected. :3

I did comment out the line which was doing that (was using it for debug), but I'll add it back in next version for ya.

I'm just waiting for drdanick's permission to add support for his Remote Toolkit's restart and forcerestart commands.

Hey DerpinLlama,
Just a follow up to your comment about string concat vs builder:
http://kaioa.com/node/59

The take away is this:

Code:

When to use StringBuilder and StringBuffer
This one is easy to remember: use 'em whenever you assemble a String in a loop. 

So I should use this:

Code:

					StringBuffer output = new StringBuffer("");
					for(int i = 0; i <= 35; i++){
						output.append("inventory_item player=").append(split[1]).append(" slot=").append(i).append(" type=").append(items[i].getTypeId()).append(" amount=").append(items[i].getAmount()).append("\r\n");
					}
					sendText(output.toString().trim());

Instead of this:

Code:

					String output = "";
					for(int i = 0; i <= 35; i++){
						output += "inventory_item player=" + split[1] + " slot=" + i + " type=" + items[i].getTypeId() + " amount=" + items[i].getAmount() + "\r\n";
					}
					sendText(output.trim());

?

Exactly

Edit:
I am not trying to be a jerk or anything, I honestly want to help people out! I hope you don't take offense to any of my comments.

I especially like this project because I think it could be a really cool way of creating an interface for any language you want to use - or write an Android app, or whatever. And because this could have multiple connections at once I think performance is pretty important.

Nono, I understand completely. You want to help and I'm grateful for that.

Gotta question, you say to type ( pass <password> ) but i wasn't sure where so i tried putty and, well no text shows up and then i tried my MC server console and it isn't read as a valid command. I need some help so if some could come up with like an idiot proof tutorial on what to do or just answer me that would be fantastic. Thx for your time.

That does not sound like a bug I can reproduce.

As part of my new project, BukkitAdmin, there will be a PHP server wrapper to interact with this plugin.

You can checkout the progress here -> https://github.com/BukkitAdmin/BukkitAdmin/blob/master/minelink.php
--- merged: Jan 29, 2011 4:55 AM ---
Hi!

Testing it out some more. Had a few little requests.

1. Could you possibly add more options for like enable/disable it sending chat back to you and such
2. JSON would be awesome for all returned data

1. Use the eventtoggle command.
2. I was looking into that but I couldn't find a method that encodes a variable as a JSON string.

Ah didn't see eventtoggle. Thanks.

As for JSON in java, is this of help? http://www.json.org/java/

You could also cheat and just return stuff like the JSON would be, but not actually use JSON if you get what im saying.

You mean generate the JSON myself? Yeah, that's what I've decided I'd do.

Hey I've made a JSON version and added other improvments (new pid command) and such.

Source and JAR attached.

Uhm yeah. I have no intention to add in JSON where not necessary. Only the things that can return more than 2 lines will be getting JSON added. Still good work though.

Edit: I think I'm gonna have invprobe output something like this:

Code:

{"inventory_items": {
	"name": "DerpinLlama",
	"slots": [
		{"num": 0, "type": 0, "amount": 0}
		{"num": 1, "type": 0, "amount": 0}
		{"num": 2, "type": 0, "amount": 0}
		{"num": 3, "type": 0, "amount": 0}
		{"num": 4, "type": 0, "amount": 0}
		{"num": 5, "type": 0, "amount": 0}
	]
}}

Ok?

2nd edit:

PHP:

                else if(line.length() >= 9 && line.substring(0, 9).equals("invprobe ")){
                    String[] split = line.split(" ");
                    if(plugin.getServer().getPlayer(split[1]) == null){
                        sendText("ERR Player not online.");
                        continue;
                    }
                    PlayerInventory playerInventory = plugin.getServer().getPlayer(split[1]).getInventory();
                    ItemStack[] items = playerInventory.getContents();
                    StringBuffer output = new StringBuffer("{\"inventory_items\":{\"name\":\"");
                    output.append(split[1]);
                    output.append("\",\"slots\":[");
                    for(int i = 0; i <= 35; i++){
                        output.append("{\"num\": ").append(i).append(", \"type\": ").append(items[i].getTypeId()).append(", \"amount\": ").append(items[i].getAmount()).append("}}");
                    }
                    output.append("]}}");
                    sendText(output.toString().trim());
                    sendText("OK");
                }

Nice!

Can we have an option for all JSON though please? Every result I get back I run through json_decode().

Also, maybe options for default event on/off? Thanks alot

You want an option for JSON to be used for all outputs?

What do you mean by your last line? >_<

By the last line, I mean like in the properties file, you can set the events join, chat, quit on/off by default.

I see. I'll add that in I guess.
--- merged: Jan 30, 2011 11:04 PM ---
What do you think of changing the sending method to do this:

Code:

			if(sendAllJson){
				if(text.substring(0, 3).equals("ERR")){
					text = "{\"error\":true,\"message\":\"" + text + "\"}";
				}
				else if(text.equals("Welcome to Bukkit, please authenticate.")){
					text = "{\"ready_for_auth\":true}";
				}
				else if(text.equals("OK")){
					text = "{\"ok\":true}";
				}
				else{
					text = "{\"message\":\"" + text + "\"}";
				}
			}

???

Awesome!

Also, maybe an event toggle? (eventtoggle json on/off)

However, still have it like chat/quit/join where you can set a default.

Thanks

Version 1.0:

Configs will now look a bit like this:

*hugs DerpinLlama profusely*

Does this work with build 168+ ?

If so, I am gonna use this to make a program for my server. Cheers

Should do. I'm not aware of it breaking at that build. Test it if you like.

The reason I ask, is because 168 changed the way commands are handled which broke many plugins... Just wondered if it broke this too. I will try it shortly, and post back my findings


EDIT:
Putty is giving me this error:
"Network Error: Connection Refused"

I am not entirely sure why...
CB #166