[INACTIVE][DEV] BukkitContrib Alpha 0.1.7 [1000]

also in Javadocs it says you have AppearanceManager.getCloakURL() but you do not have it...

I get the following error, when I reload the server, while an Inventory is opened (also got this error in older versions of BukkitContrib):

Using CB#819

Code:

2011-06-06 14:18:10 [INFO] Stopping server
2011-06-06 14:18:10 [SEVERE] java.lang.ClassCastException: net.minecraft.server.ContainerChest cannot be cast to net.minecraft.server.ContainerPlayer
2011-06-06 14:18:10 [SEVERE]     at org.bukkitcontrib.player.ContribCraftPlayer.<init>(ContribCraftPlayer.java:61)
2011-06-06 14:18:10 [SEVERE]     at org.bukkitcontrib.player.ContribCraftPlayer.updateBukkitEntity(ContribCraftPlayer.java:355)
2011-06-06 14:18:10 [SEVERE]     at org.bukkitcontrib.player.ContribCraftPlayer.getContribPlayer(ContribCraftPlayer.java:403)
2011-06-06 14:18:10 [SEVERE]     at org.bukkitcontrib.player.SimpleAppearanceManager.resetGlobalCloak(SimpleAppearanceManager.java:156)
2011-06-06 14:18:10 [SEVERE]     at org.bukkitcontrib.player.SimpleAppearanceManager.resetAllCloaks(SimpleAppearanceManager.java:181)
2011-06-06 14:18:10 [SEVERE]     at org.bukkitcontrib.player.SimpleAppearanceManager.resetAll(SimpleAppearanceManager.java:189)
2011-06-06 14:18:10 [SEVERE]     at org.bukkitcontrib.player.SimpleAppearanceManager.onPluginDisable(SimpleAppearanceManager.java:251)
2011-06-06 14:18:10 [SEVERE]     at org.bukkitcontrib.BukkitContrib.onDisable(BukkitContrib.java:31)
2011-06-06 14:18:10 [SEVERE]     at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:127)
2011-06-06 14:18:10 [SEVERE]     at org.bukkit.plugin.java.JavaPluginLoader.disablePlugin(JavaPluginLoader.java:771)
2011-06-06 14:18:10 [SEVERE]     at org.bukkit.plugin.SimplePluginManager.disablePlugin(SimplePluginManager.java:269)
2011-06-06 14:18:10 [SEVERE]     at org.bukkit.plugin.SimplePluginManager.disablePlugins(SimplePluginManager.java:262)
2011-06-06 14:18:10 [SEVERE]     at org.bukkit.craftbukkit.CraftServer.disablePlugins(CraftServer.java:123)
2011-06-06 14:18:10 [SEVERE]     at net.minecraft.server.MinecraftServer.stop(MinecraftServer.java:260)
2011-06-06 14:18:10 [SEVERE]     at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:341)
2011-06-06 14:18:10 [SEVERE]     at net.minecraft.server.ThreadServerApplication.run(SourceFile:422)
2011-06-06 14:18:10 [SEVERE] Error occurred while disabling BukkitContrib v0.0.4 (Is it up to date?): org.bukkit.craftbukkit.entity.CraftPlayer cannot be cast to org.bukkitcontrib.player.ContribCraftPlayer
java.lang.ClassCastException: org.bukkit.craftbukkit.entity.CraftPlayer cannot be cast to org.bukkitcontrib.player.ContribCraftPlayer
    at org.bukkitcontrib.player.ContribCraftPlayer.getContribPlayer(ContribCraftPlayer.java:404)
    at org.bukkitcontrib.player.SimpleAppearanceManager.resetGlobalCloak(SimpleAppearanceManager.java:156)
    at org.bukkitcontrib.player.SimpleAppearanceManager.resetAllCloaks(SimpleAppearanceManager.java:181)
    at org.bukkitcontrib.player.SimpleAppearanceManager.resetAll(SimpleAppearanceManager.java:189)
    at org.bukkitcontrib.player.SimpleAppearanceManager.onPluginDisable(SimpleAppearanceManager.java:251)
    at org.bukkitcontrib.BukkitContrib.onDisable(BukkitContrib.java:31)
    at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:127)
    at org.bukkit.plugin.java.JavaPluginLoader.disablePlugin(JavaPluginLoader.java:771)
    at org.bukkit.plugin.SimplePluginManager.disablePlugin(SimplePluginManager.java:269)
    at org.bukkit.plugin.SimplePluginManager.disablePlugins(SimplePluginManager.java:262)
    at org.bukkit.craftbukkit.CraftServer.disablePlugins(CraftServer.java:123)
    at net.minecraft.server.MinecraftServer.stop(MinecraftServer.java:260)
    at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:341)
    at net.minecraft.server.ThreadServerApplication.run(SourceFile:422)

EDIT:
To specify a bit:
The error occurs, when having a Chest/Furnace/Workbench opened while reloading. Not when a normal playerinventory (key E/I) is opened

Check the API spoiler - use the static craftplayer method.

Ehm.. This error even occurs, when BukkitContrib is the only plugin in the plugin-folder. So I believe it's something in the source of BukkitContrib.

EDIT:
To specify a bit:
The error occurs, when having a Chest/Furnace/Workbench opened while reloading. Not when a normal playerinventory (key E/I) is opened

ContribPlayer player = ContribCraftPlayer.getContribPlayer(event.getPlayer()); - did you try that? I haven't actually used this myself unfortunately.

Once again:
This error IS NOT occuring because of a use of another plugin using BukkitContrib.

This error is coming from BukkitContrib all alone. (even when no other plugins are installed)

Oh and By the way Afforess:

This API is freaking AWESOME! Thanks for your work on that! I'm already using your API to develop some plugins!

Looks like a casting error in his code. This

Code:

return (ContribCraftPlayer)((CraftPlayer)player).getHandle().getBukkitEntity();

should be

Code:

return ((ContribCraftPlayer)((CraftPlayer)player).getHandle()).getBukkitEntity();

Same here, it seems, that .setGlobalXxx is not changing your view of skin/cloak .. we'll see, what Afforess will say

Just to note to you @Afforess - Heroes is working great with the inventory hooks and using BukkitContrib as a soft dependency. I've only had one report of inventory shaking - but I'm not sure what caused it.

Did the update to BukkitContrib Change any inventory events?

@Afforess Can you change the .7z SP mod download to a .zip? Not that I couldn't open it, but I'm not a big fan of rars and 7zs

Yep, I am already aware, I warned someone else in a different thread, and already have a fix ready for 0.0.5.

Doesn't BukkitContrib.getAppearanceManager().getCloakUrl(viewingPlayer, target) work?

I'm not sure, it may be impossible to change texture packs mid game (ATM, the MC texture pack switcher works while the game is off)

I can certainly look into it though.

Correct - Skins/Cloaks are only for appearance ATM. I'm not even sure you can see a cloak you are wearing in-game.

I'll look at allowing skins to be set for the player though.

I've been using it okay so far, but I'll add extra parenthesis for clarity.

Casting should work fine BTW, the static method is slower (casting is faster than a function call), and all bukkit entities are replaced as soon as they are created for players.

0.0.4 add an additivity parameter that exposes if an inventory click was left/right mouse click, but no actual changes.

I've rather fond of 7z. It's one of the best compressors, and is open source. What's not to like?

@Afforess Well the whole me being on a Mac thingy...

Oh.

*pull's out Mr. T action figure.*
*pulls string*
"I pity the fool"

@Afforess Ok, just thought it was a bug

Hello, Afforess
I've got two problems with Contrib. So:
client-side mod is not working with EssentialChat, something is wrong, if format of chat is set by EssChat (formatting can be turned off, and still you can use EssChat + client-side). But bigger problem is:
I succesfully made plugin, which change your skin, but it's not working together with AuthDB (there is no actuall sourcecode). Here is my code:

Code:

    public class MainFunction implements Runnable {
        @Override
        public void run() {
            Player[] online = Bukkit.getServer().getOnlinePlayers();
            for (Player player: online){
                    BukkitContrib.getAppearanceManager().setGlobalSkin((HumanEntity) player,
                            "http://****/"+ player.getName().toLowerCase() + ".png");
            }
        }
    } 

Using CB#823, Contrib v0.0.4, AuthDB v2.2.0...
Repro: skin is set by .setGlobalSkin only if you're logged as guest. If you're registered already, appearance of other players are not changed.

@Afforess Lol, I should get a new pc soon, but the current one I have just says incorrect command line every time I try to use 7zip, so I just use WinRAR

First off, you don't need to cast a player to a human entity. Players are already a human entity.

Now, let me make sure I'm understanding the problem:

If you are using AuthDB & BukkitContrib, AppearanceManager().setGlobalSkin() is not working (e.g no visible change after calls) at all.

Well, the fact that it works fine with guests & works fine without AuthDB leads me to believe some of the packet/chat processing done by AuthDB is conflicting. And without source code for their plugin, I can not fix it. Perhaps @CraftFire will trust me enough to give me a copy of the source code for AuthDB? If not, don't use AuthDB. I dislike plugins that hide their source anyway (even if there are reasons).

Need to add 7zip to the path or whatever the mac equivalent is.

@Afforess Just confirming, there is no way to display the cloaks for the person wearing them...

Correct.

@Everyone

I've added a "planned" changelog for future releases. Changing skins/cloak for the active player is on them.

About casting to human entity.. I tried some other ways how to get it working with AuthDB and that cast left there. Thanks

Yes, you're understanding really well. No visible changes... I watched decompiled code of AuthDB (you can too), but I didnt get something problematic. But I really don't know Contrib as you do.

AuthDB is probably only authorization plugin using MySql.. that's reason why to use that.
Btw: where is src for contrib, if you dont like... you know.

I'll add a link to the OP as well:

https://github.com/Afforess/BukkitContrib

Also would like to note, if the exception with /reload is bothering anyone, you can compile the src on github, it already has the fix.

Alpha 0.0.5 will probably not be until wend.

Coloring works for titles btw

Does it? Awesome, less work for me. Mind posting a screenshot to pique my curiosity?

Here it is. I used ChatColor.RED.toString() + player.getName()

Suggestion:
A GUI Framework for the client side plugin? This would make some plugins really awesome.

@captainawesome7
there is a 7zip app for the mac with gui:
http://sixtyfive.xmghosting.com/products/7zx/
works very well on mine

@narrowtux thank you!

Yeah - definitely worth looking into long term, in addition to a way to have clients download custom entites/blocks/items dynamically.

Still would need BukkitContrib client to download them, but at least they wouldn't be hardcoded.

@alta189

Very cool!