[INACTIVE][ECON] LocalShops - Please Close this Thread

You just updated while I was typing in the other thread. Here were my thoughts in the other thread.

I'll give the new one a try. Thanks.

I like your ides and have already built the plugin so that they can be implemented later. I just want to get the bugs worked out of this initial release first. One major goal in the future is using chests to buy and sell instead of commands. Just drag and drop.

Love that you're bringing this back from the grave.

Could you possibly implement this in DynamicMarket or just add dynamical shop values, please? I miss DMWrapper.

[SEVERE] org.anjocaido.groupmanager.GroupManager.getPermissionHandler()Lcom/nijiko/permissions/PermissionHandler; (Is it up to date?)
java.lang.NoSuchMethodError: org.anjocaido.groupmanager.GroupManager.getPermissionHandler()Lcom/nijiko/permissions/PermissionHandler;
at net.centerleft.localshops.LocalShops.onEnable(LocalShops.java:77)
at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:140)
at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:426)
at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:187)
at org.bukkit.craftbukkit.CraftServer.loadPlugin(CraftServer.java:79)
at org.bukkit.craftbukkit.CraftServer.loadPlugins(CraftServer.java:60)
at net.minecraft.server.MinecraftServer.e(MinecraftServer.java:187)
at net.minecraft.server.MinecraftServer.a(MinecraftServer.java:174)
at net.minecraft.server.MinecraftServer.d(MinecraftServer.java:120)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:227)
at net.minecraft.server.ThreadServerApplication.run(SourceFile:366)

2011-03-02 16:17:33 [SEVERE] null
org.bukkit.command.CommandException: Unhandled exception executing command 'shop' in plugin LocalShops v1.0b
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:21)
at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:77)
at org.bukkit.craftbukkit.CraftServer.dispatchCommand(CraftServer.java:176)
at net.minecraft.server.NetServerHandler.c(NetServerHandler.java:638)
at net.minecraft.server.NetServerHandler.chat(NetServerHandler.java:601)
at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:595)
at net.minecraft.server.Packet3Chat.a(SourceFile:24)
at net.minecraft.server.NetworkManager.a(SourceFile:230)
at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:70)
at net.minecraft.server.NetworkListenThread.a(SourceFile:100)
at net.minecraft.server.MinecraftServer.h(MinecraftServer.java:338)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:253)
at net.minecraft.server.ThreadServerApplication.run(SourceFile:366)
Caused by: java.lang.NullPointerException
at net.centerleft.localshops.Commands.createShop(Commands.java:61)
at net.centerleft.localshops.LocalShops.onCommand(LocalShops.java:127)
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:19)
... 12 more
2011-03-02 16:17:33 [SEVERE] Could not pass event PLAYER_MOVE to LocalShops
java.lang.NullPointerException
at net.centerleft.localshops.PlayerData.addPlayerToShop(PlayerData.java:22)
at net.centerleft.localshops.ShopsPlayerListener.onPlayerMove(ShopsPlayerListener.java:65)
at org.bukkit.plugin.java.JavaPluginLoader$8.execute(JavaPluginLoader.java:165)
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:59)
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:225)
at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:115)
at net.minecraft.server.Packet10Flying.a(SourceFile:126)
at net.minecraft.server.NetworkManager.a(SourceFile:230)
at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:70)
at net.minecraft.server.NetworkListenThread.a(SourceFile:100)
at net.minecraft.server.MinecraftServer.h(MinecraftServer.java:338)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:253)
at net.minecraft.server.ThreadServerApplication.run(SourceFile:366)

Can you add the possibility to change the size of the shop. It doesn't have to be a command just give an entry in the shop file and that will suffice.

Great Plugin, I am glad to see you are supporting the recommended build like other plugins are suppose to be doing.

@Juze How does a dynamic shop work? What feature would make this better?

@sfastin please download the latest .jar and give it a try again. If you are still having errors, please let me know what craftbukkit build you have, which GroupManager version you're on, and what command you are trying. Thanks!

@Tomato That's coming. Once the bugs are worked out a little.

well if i try to do /shop ingame, it says: looks like you need some help and then when i try to like /shop create, nothing happens. please help!

Ahh, sorry. The in game help isn't finished yet. Please see the commands at the top of this page for now.

To create a shop do this:

/shop create ShopName (The shop name needs to have no spaces in it)

well, but if you enter the command, isn't it going to return you a message?

I need to fix that. Thanks for spotting it.

Can you make it use NPCs? So when you rightclick the NPC, the text "you have entered the shop...."
Also, can you make the text customizable? I run a swedish-only server and it would be nice with swedish text
Thanks!

True... I can see how custom text would be very helpful. Are English commands still going to be okay for you?

Edit: I'm not planning on adding NPCs. I think there are other plugins that allow you to add NPCs and it would be better to let them do that and then just run both plugins.

well, it would be nice if you could make them customizable aswell! but if you fix the messages i'm happy as a pig!

Custom messages will be easier. Custom commands would be much more complicated.

I'll see what I can do. Hopefully have something for you in the next week.

@Jonbas
Dynamic prices would be a good feature. For example, when you buy 10 diamonds from the shop, the price goes up by 1% in shop. Take a look at DynamicMarket.

Okay, I'll look into it.

nice, thanks!

If you do go dynamic, please have an option to turn it off. I use this as a static shop for the whole server and dislike the dynamic part for that shop.

I'll think about dynamic pricing, but I don't know if it makes a lot of sense for this plugin. The guys that are working on DynamicMarket have put a lot of work into there stuff and it wouldn't make any sense to re-create it. It's possible that we could talk about having our plugins work together in the future, but no promisses.

Major difference with LocalShops from DynamicMarket is that each shop has it's own stock and the shops are tied to iConomy bank accounts. So any time a item is purchased or sold, the player that owns the shop is buying or selling that block.

@Jonbas
Ah, it's fine. Just missing those local shops that restrict it to an area.

Maybe you can add a feature when you step into the shop zone you hear a note. (Just an diea)

That's a great idea! Like door chimes on a real shop.

Indeed! Maybe a different sound when you leave it.
--- merged: Mar 2, 2011 7:09 PM ---
Could it be possible to set up an option for the price to create a shop?

Yes, it's on my list for next version.

If you need more ideas. I have loads.

Got a book of million dollar ideas is how I say it, but yeah those are some good ones Phantom. Maybe let's make a list of your ideas somewhere.

All commands appear to work properly except for buying from and selling to shops, which give no feedback and don't appear to actually do anything. Running Permissions 2.51, CB #440, latest version of LocalShops.

The feedback is a problem. Have you set the buy and sell price for the item after you add it to the shop? It's actually a 3 step process to sell something in the shop.

/shop add (to add the item your holding)
/shop set buy itemName [price] <optional bundlesize>
/shop set sell itemName [price] <optional bundlesize>

if you don't set the buy or sell price, it defaults to 0 and the shop won't buy or sell that item. Sorry for the poor command help. That's my first priority this weekend.
--- merged: Mar 3, 2011 1:01 AM ---
Also, it could be a permissions thing. Do you have access to localshops.buysell?