Solved Joining arena help

when I try to join the Arenas, I get an Invalid Arena ID and Invalid Arena message. I'm using AgentTrolls Arena class. Here is my code:
ArenaManager

Code:java

import org.bukkit.Bukkit;
import org.bukkit.Location;
import org.bukkit.entity.Player;
import org.bukkit.inventory.ItemStack;
 
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
 
public class ArenaManager{
 
    //save where the player teleported
    public Map<String, Location> locs = new HashMap<String, Location>();
    //make a new instance of the class
    public static ArenaManager am = new ArenaManager();
    //a few other fields
    Map<String, ItemStack[]> inv = new HashMap<String, ItemStack[]>();
    Map<String, ItemStack[]> armor = new HashMap<String, ItemStack[]>();
    //list of arenas
    List<Arena> arenas = new ArrayList<Arena>();
    int arenaSize = 0;
 
    static KoTH plugin;
    public ArenaManager(KoTH arenaPVP) {
        plugin = arenaPVP;
    }
 
    public ArenaManager(){
 
    }
 
    //we want to get an instance of the manager to work with it statically
    public static ArenaManager getManager(){
        return am;
    }
 
    //get an Arena object from the list
    public Arena getArena(int i){
        for(Arena a : arenas){
            if(a.getId() == i){
                return a;
            }
        }
        return null;
    }
 
    //add players to the arena, save their inventory
    public void addPlayer(Player p, int i){
        Arena a = getArena(i);//get the arena you want to join
        if(a == null){//make sure it is not null
            p.sendMessage("Invalid arena!");
            return;
        }
 
        a.getPlayers().add(p.getName());//add them to the arena list of players
        inv.put(p.getName(), p.getInventory().getContents());//save inventory
        armor.put(p.getName(), p.getInventory().getArmorContents());
 
        p.getInventory().setArmorContents(null);
        p.getInventory().clear();
 
        locs.put(p.getName(), p.getLocation());
        p.teleport(a.spawn);//teleport to the arena spawn
    }
 
    //remove players
    public void removePlayer(Player p){
        Arena a = null;//make an arena
        for(Arena arena : arenas){
            if(arena.getPlayers().contains(p.getName())){
                a = arena;//if the arena has the player, the arena field would be the arena containing the player
            }
            //if none is found, the arena will be null
        }
        if(a == null || !a.getPlayers().contains(p.getName())){//make sure it is not null
            p.sendMessage("Invalid operation!");
            return;
        }
 
        a.getPlayers().remove(p.getName());//remove from arena
 
        p.getInventory().clear();
        p.getInventory().setArmorContents(null);
 
        p.getInventory().setContents(inv.get(p.getName()));//restore inventory
        p.getInventory().setArmorContents(armor.get(p.getName()));
 
        inv.remove(p.getName());//remove entries from hashmaps
        armor.remove(p.getName());
        p.teleport(locs.get(p.getName()));
        locs.remove(p.getName());
 
        p.setFireTicks(0);
    }
 
    //create arena
    public Arena createArena(Location l){
        int num = arenaSize + 1;
        arenaSize++;
 
        Arena a = new Arena(l, num);
        arenas.add(a);
 
        plugin.getConfig().set("Arenas." + num, serializeLoc(l));
        List<Integer> list = plugin.getConfig().getIntegerList("Arenas.Arenas");
        list.add(num);
        plugin.getConfig().set("Arenas.Arenas", list);
        plugin.saveConfig();
 
        return a;
    }
 
    public Arena reloadArena(Location l) {
        int num = arenaSize + 1;
        arenaSize++;
 
        Arena a = new Arena(l, num);
        arenas.add(a);
 
        return a;
    }
 
    public void removeArena(int i) {
        Arena a = getArena(i);
        if(a == null) {
            return;
        }
        arenas.remove(a);
 
        plugin.getConfig().set("Arenas." + i, null);
        List<Integer> list = plugin.getConfig().getIntegerList("Arenas.Arenas");
        list.remove(i);
        plugin.getConfig().set("Arenas.Arenas", list);
        plugin.saveConfig();
    }
 
    public boolean isInGame(Player p){
        for(Arena a : arenas){
            if(a.getPlayers().contains(p.getName()))
                return true;
        }
        return false;
    }
 
    public void loadGames(){
        arenaSize = 0;
 
        if(plugin.getConfig().getIntegerList("Arenas.Arenas").isEmpty()){
            return;
        }
 
        for(int i : plugin.getConfig().getIntegerList("Arenas.Arenas")){
            Arena a = reloadArena(deserializeLoc(plugin.getConfig().getString("Arenas." + i)));
            a.id = i;
        }
    }
 
    public String serializeLoc(Location l){
        return l.getWorld().getName()+","+l.getBlockX()+","+l.getBlockY()+","+l.getBlockZ();
    }
    public Location deserializeLoc(String s){
        String[] st = s.split(",");
        return new Location(Bukkit.getWorld(st[0]), Integer.parseInt(st[1]), Integer.parseInt(st[2]), Integer.parseInt(st[3]));
    }
}

Arena class

Code:java

import org.bukkit.Location;
 
import java.util.ArrayList;
import java.util.List;
 
public class Arena {
 
    //you want some info about the arena stored here
    public int id = 0;//the arena id
    public Location spawn = null;//spawn location for the arena
    List<String> players = new ArrayList<String>();//list of players
 
    //now let's make a few getters/setters, and a constructor
    public Arena(Location loc, int id) {
        this.spawn = loc;
        this.id = id;
    }
 
    public int getId() {
        return this.id;
    }
 
    public List<String> getPlayers() {
        return this.players;
    }
    public int getPlayerSize(){
        return this.players.size();
    }
}
 

Commands class:

Code:java

@Override
    public boolean onCommand(CommandSender sender, Command cmd, String label, String args[]) {
        if (!(sender instanceof Player)) {
            sender.sendMessage("Whoa there buddy, only players may execute this!");
            return true;
        }
        if (cmd.getName().equalsIgnoreCase("koth")) {
            String sub = args[0];
 
            Player p = (Player) sender;
 
            if (sub.equalsIgnoreCase("create")) {
                if (p.hasPermission("KoTH.create")) {
                    ArenaManager.getManager().createArena(p.getLocation());
                    p.sendMessage("Created arena at " + p.getLocation().toString());
 
                    return true;
                }
            }
            if (sub.equalsIgnoreCase("join")) {
                if (args.length != 2) {
                    p.sendMessage("Insufficient arguments!");
                    return true;
                }
                int num = 0;
                try {
                    num = Integer.parseInt(args[0]);
                } catch (NumberFormatException e) {
                    p.sendMessage("Invalid arena ID");
                }
                ArenaManager.getManager().addPlayer(p, num);
 
                return true;
            }
            if (sub.equalsIgnoreCase("leave")) {
                ArenaManager.getManager().removePlayer(p);
                p.sendMessage("You have left the arena!");
 
                return true;
            }
            if (sub.equalsIgnoreCase("remove")) {
                if (p.hasPermission("KoTH.remove") || p.hasPermission("KoTH.*"))
                    if (args.length != 1) {
                        p.sendMessage("Insuffcient arguments!");
                        return true;
                    }
                int num = 0;
                try {
                    num = Integer.parseInt(args[0]);
                } catch (NumberFormatException e) {
                    p.sendMessage("Invalid arena ID");
                }
                ArenaManager.getManager().removeArena(num);
 
                return true;
            }
 
            return false;
        }
        return false;
    }

 

tl;dr
EDIT: Does the arena actually exist? The code looks like it will work.

 

rbrick yes it works, I have a file where all the info is saved, but cannot teleport to any arenas.
EDIT: fixed, I forgot to change the args[0] to args[1] in the join command

 

drpk for God's sake remove that static instance and the empty constructor. Currently you are just asking for a NullPointerException.

 

Oh yeah... The GitHub code is outdated, look on the forum post. Gotta remind myself to update it.