KIlls Scoreboard help!

So I setup a scoreboard and it's working fine BUT I don't know how to set the score for it, when I set it to killCount.setScore(Kills.get(p.getName())); Minecraft gives me tons of errors. Here's my code, please help.

Code:

 
public static HashMap<String, Integer> kills = new HashMap<String, Integer>();
 
public static void updateScoreboard(final Player p) {
Bukkit.getScheduler().scheduleSyncRepeatingTask(Wrapper.instance,
new Runnable() {
public void run() {
 
Scoreboard scoreboard = Bukkit.getScoreboardManager().getNewScoreboard();
Objective obj = scoreboard.registerNewObjective("scoreboard", "dummy");
obj.setDisplaySlot(DisplaySlot.SIDEBAR);
obj.setDisplayName(ChatColor.RED + p.getName());
 
Score killCount = obj.getScore(Bukkit.getOfflinePlayer(ChatColor.GOLD + "Kills:"));
//HELP ! killCount.setScore();
 
 
 
p.setScoreboard(scoreboard);
 
 
}
 
}, 0, 10);
 
}
 
@EventHandler
public void onPlayerJoin(PlayerJoinEvent e) {
Player p = (Player) e.getPlayer();
 
updateScoreboard(p);
}
 
@EventHandler
public void onPlayerDeath(EntityDeathEvent e) {
 
Player p = (Player) e.getEntity();
Player killer = p.getKiller();
 
kills.put(killer.getName(), kills.get(killer.getName()) + 1);
 
 
}
 
 

 

Post the error log here with a tag or on pastebin.

 

MrInspector I have a scoreboard also display players money and its working fab, this is the only thing giving me errors.

MrInspector when the player joins, it throws a nullpointerexception

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

I uh need the error log to see where the NPE is coming from

 

MrInspector http://gyazo.com/a548a0b3a0fea79fdea4bbe60bcec6b7

 

xCalib0r
Could you post your code as Java code?

-Dahwn

 

bump

anyone?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

What is line 35 from your code?

Also, I highly recommend rewriting the whole method from scratch, since it is very inefficient. You should always take youtube tutorials with a grain of salt, because I know a lot of them to grossly misuse the Bukkit API and Java in general.

 

coasterman10 what line is 35?

 

xCalib0r The stacktrace is telling us that the error is on the 35th line of code. Does your IDE have line numbers enabled?

 

It will probably be updateScoreboard(p); but obviously it is the method causing this.

Code:java

public static HashMap<String, Integer> kills = new HashMap<String, Integer>();
 
private Scoreboard scoreboard;
private Objective obj;
private Score killCount;
 
onEnable method; //I would instantiate it in your on enable and outside the onEnable create the variables.
Scoreboard scoreboard = Bukkit.getScoreboardManager().getNewScoreboard();
Objective obj = scoreboard.registerNewObjective("scoreboard", "dummy");
obj.setDisplaySlot(DisplaySlot.SIDEBAR);
obj.setDisplayName(ChatColor.RED + p.getName());
 
Score killCount = obj.getScore(Bukkit.getOfflinePlayer(ChatColor.GOLD + "Kills:"));
killCount.setScore(*Insert score here*);
}
 
@EventHandler
public void onPlayerJoin(PlayerJoinEvent e) {
Player p = e.getPlayer();
 
p.setScoreboard(scoreboard);
}
 
@EventHandler
public void onPlayerDeath(PlayerDeathEvent e) {
Player p = e.getPlayer();
if(e.getEntity().getKiller() instanceof Player){
    Player killer = e.getEntity().getKiller();
 
    kills.put(killer.getName(), kills.get(killer.getName()) + 1);
}
}

This code should be a lot cleaner and efficient. Wether it works or not I don't know, I wasn't trying to make it.

 

itzrobotix updatescoreboard was being called in onEnable so it's essentially the same thing, though this is what I want to know. What do I put in setscore to display the score. I did kills.get(p.getName())) and thats what caused it all.

1. killCount.setScore(*Insert score here*);

O ya one thing, when the player dies their's also ONE MORE null pointer exception, and that's this.

Code:java

 
kills.put(killer.getName(), kills.get(killer.getName()) + 1);
 

I think I fixed it with a simple check though

Code:java

 
if(killer instanceof Player) {
kills.put(killer.getName(), kills.get(killer.getName()) + 1);
}
 

still don't know what to put in setScore.

bump

anyon?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

xCalib0r
Look at what itzrobotix posted: the killCount is your scoreboard object. Now you have to set it's score to how many kills the person has:

Code:java

killCount.setScore("your int score here");

Try that as your integer:

Code:java

kills.get(p.getName()).intValue();

It works for me!

-Dahwn

 

I fixed a lot of the code for you... Also the nullpointer may be caused by the fact you are setting there score by getting it in the hashmap, but if they are not in the hashmap it will return null.
So change the code to this;

Code:java

if(kills.get(killer.getName() != null){
//Insert code here
return;
}
else kills.put(killer.getName(), 1); return;

 

Guys how do I make sure it's ALWAY updating? You know for credits and stuff.

Still getting null pointer exception, FULL CODE:

ScoreboardManager:

Code:java

 
public class ScoreboardManager implements Listener {
 
public static HashMap<String, Integer> kills = new HashMap<String, Integer>();
 
public static void updateScoreboard(final Player p) {
Bukkit.getScheduler().scheduleSyncRepeatingTask(Wrapper.instance,
new Runnable() {
public void run() {
 
Scoreboard scoreboard = Bukkit.getScoreboardManager().getNewScoreboard();
Objective obj = scoreboard.registerNewObjective("scoreboard", "dummy");
obj.setDisplaySlot(DisplaySlot.SIDEBAR);
obj.setDisplayName(ChatColor.RED + p.getName());
 
Score killCount = obj.getScore(Bukkit.getOfflinePlayer(ChatColor.GOLD + "Kills:"));
 
killCount.setScore(kills.get(p.getName()).intValue());
 
p.setScoreboard(scoreboard);
 
 
}
 
}, 0, 10);
 
}
 
@EventHandler
public void onPlayerJoin(PlayerJoinEvent e) {
Player p = (Player) e.getPlayer();
 
updateScoreboard(p);
}
 
@EventHandler
public void onPlayerDeath(EntityDeathEvent e) {
 
Player p = (Player) e.getEntity();
Player killer = p.getKiller();
 
if (kills.get(killer.getName()) != null) {
kills.put(killer.getName(), kills.get(killer.getName()) + 1);
return;
} else {
kills.put(killer.getName(), 1);
return;
}
 
 
}
 
 
}
 

MAIN CLASS (onEnable):

Code:java

 
AutoBroadcastManager.AutoBroadcastMessage();
for (Player p : Bukkit.getOnlinePlayers()) {
ScoreboardManager.updateScoreboard(p);
}
 

anyone?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Stacktrace? It's important to know where the NPE is originating.

 

Try adding this line on your onPlayerJoin:

Code:java

kills.put(p.getName(), 0);

I suspect you did not put your player into your HashMap, that is why it is giving a NULL.

Also, don't use player names anymore. It has been deprecated since 1.7.5 as Mojang is releasing a way to change player names. Use player UUID instead.

 

deathline75
You can use player names for sessions like the killstreaks but not if you want to save data for example in a MySQL database or config file!

-Dahwn

 

Dahwn
Oh. Then I think it should be fine. Thanks for the info!

 

deathline75 nope, still getting the null pointer exception and the scoreboard isn't even showing up.

Code:java

 
public class ScoreboardManager implements Listener {
 
public static HashMap<String, Integer> kills = new HashMap<String, Integer>();
public static Scoreboard scoreboard = Bukkit.getScoreboardManager().getNewScoreboard();
 
 
public static void updateScoreboard(final Player p) {
Objective obj = scoreboard.registerNewObjective("stats", "dummy");
obj.setDisplaySlot(DisplaySlot.SIDEBAR);
obj.setDisplayName(ChatColor.RED + p.getName());
 
 
Score killCount = obj.getScore(Bukkit.getOfflinePlayer(ChatColor.GOLD + "Kills:"));
 
killCount.setScore(kills.get(p.getName()).intValue());
 
p.setScoreboard(scoreboard);
 
}
 
@EventHandler
public void onPlayerJoin(PlayerJoinEvent e) {
Player p = (Player) e.getPlayer();
 
kills.put(p.getName(), 0);
updateScoreboard(p);
}
 
@EventHandler
public void onPlayerDeath(EntityDeathEvent e) {
 
Player p = (Player) e.getEntity();
Player killer = p.getKiller();
if (e.getEntity().getKiller() instanceof Player) {
kills.put(killer.getName(), kills.get(killer.getName()) + 1);
}
}
 
}
 

The error is this guys : killCount.setScore(kills.get(p.getName())); when I take it out and just put 0 the scoreboard shows.

It has something to do with the hashmap for sure :/

bump

EDIT by Moderator: merged posts, please use the edit button instead of double posting.