[MECH] (CB 1438+) - Extend Day - Make Day (or Night) Last Longer

Try the "inofficial" build: http://forums.bukkit.org/threads/extend-day-beta-make-day-last-longer.413/page-4#post-38990

http://500motivators.com/plog-content/thumbs/motivate/me/large/63-you-sir-are-fucking-awesome.jpg

I love you man. I'm not gay but this is the first time this plugin works on my server and my players and me are very happy about that. You're great

I'm currently using this version but still getting the Server.getTime error, except that it's prefaced with "Exception in thread "Thread-8"". The thread number increases by 1 each time the error is thrown. Latest version of CraftBukkit.
--- merged: Feb 3, 2011 8:47 PM ---
Never mind, it appears to be ok now. Thanks!

If there were "Server.getTime" errors then you used an old ExtendDay version, because now it's World.getTime

To the people passing my code around without following its license: Stop, and please delete/remove all download links to alternative version. I don't want to confuse the issue and I basically use the same reason Notch give:I don't want people bugging me about your "unofficial" versions, especially if the license I put my code under is not being followed.

I'm updating all time based plugins to use the new api. Dropbox's is updated already so none of you has any reason to continue confusing the issue.

-.-

Bukkit is released under GPL
do you even know what this means? ( it means you have to release your code under GPL, too)

and btw, calling bukkit api from another thread is NOT SAFE , as the bukkit API is not (yet) thread-safe
i recommend adopting my timer fix

'
I'm aware of the GPL, especially since I was a part of the draft community that created version 3.

If a non-technical user gets a "unofficial" version of the plugin they will come to me and bug me about it, and out of respect I ask any other plugin developer not to put mer in that position. This is what separates the people on the forum with a "Plugin Developer" tag from the people who dont have it but still can develop plugins; its about respect.

And for the record, I don't HAVE to do anything, I don't have to release plugins I created. I dont have to provide anything I code to the community. I choose to do so because I care.. so please, give a little respect back in return.

if you use bukkit you have to release the source, read the GPL

it would only work with craftbukkit as that is released under LGPL

and stop crying around actually i used my time to fix your problems, so show a little respect

and here's a little to do list:

- use the plugin folder returned by bukkit to save the config file
- don't go back in time, but jump forward / skip the night (reported by a user, i did not verify it yet)
- don't call bukkit api from another thread
- use the logger class, dont output directly to System.out

if you want me to remove the links you have to cry to a mod , or actually be a bit nicer to me

Redecouverte your attempting to confuse the issue, and I am against that.

I really did not want to get into this, but the GPL does nothing to give you the right to use my username, alias, or the name of my plugin so by distributing my code against my wishes using my chosen name of the plugin, you are hurting the community, and sending angry people my way for your bugs and your version of my codes issues, and yes breaking the GPL. Its like if I chose to use the name "Minecraft" for a minecraft clone; I could get sued, people would come to me blaming me for bugs in Notches code, etc.

That is the situation here. Also, I released all my plugins/code AGPL with a BSD restriction on removing my alias as the author (they are both GPL compatible, and thus that is allowed), so technically you have not followed my license, or the GPL itself.

Our feverdream who art in the nether,
Hallowed be Thy plugin.
Thy java come.
Thy will be done on earth, as it is in Minecraft.
Give us today our daily extend day.
And forgive us our mods.
As we forgive those who flame against us.
And lead us not into crashes,
But deliver us cake.
For Thine is the source code,
The name rights and the GPL,
Forever,
Amen

rofl.

Dude I don't expect people to treat me as a god or anything, I'm not and I honestly dont want you to think so. But lets be clear: ALL DEVELOPERS, from plugin developers, to Bukkit Developers (some of who do both plugins and bukkit work) to Notch himself deserve to be treated with a but of respect. Actually, all people should be treated with respect, but thats not a point many people want to hear so let just stick with developer if that is all people can handle.
--- merged: Feb 5, 2011 12:30 AM ---
In case you missed it.. yes, the plugin has been updated.

you are still calling setTime() and stuff from another thread, this will randomly cause exceptions

This has never created an exception in any of my tests. Please provide a stack-trace.

the chance for this varies from system to system and is highly random

one just don't modifies non-thread safe objects from another thread, thats a very basic rule

a stack trace would also make no sense here

you may wan to read that:
http://www.artima.com/designtechniques/threadsafety.html

I'm well aware of the issues with threads; I asked you for a stack trace because I don't use threads in my plugin, AT ALL, and I think you may be using a version id ont support that was created by another person.

This sounds like a bug in Bukkit, not my plugin.

sure you are

Code:

      this.tick = new Timer();
      this.tick.schedule(ss, 0L, this.rate);

see
http://download.oracle.com/javase/1.5.0/docs/api/java/util/Timer.html

--- merged: Feb 5, 2011 1:01 AM ---

well, that person must have hacked your github, i have taken it from there

Doh. your right for some reason I forgot I was using that class, may have been thinking of murder.

So what your saying is they broke time, again? I have updated the plugin to use a world reference verses what I was doing before.. let me know if it helps.

well, it has nothing to do with setTime() directly, that's all fine with your latest update

ist just that the bukkit api classes are not thread-safe (yet), and that timer class uses its own thread to execute the run() functions of your class

it works like 95% of time time, but that depends on system details (multi core system/java implementation/etc)
its just the normal thread-safety issue

if you look in the source i have posted, you'll see that it queues a console command from the timer's thread , and modifies the time with setTime() on the command callback, which solves this issue

Can you do me a favor and remove the source and links you have posted in my thread? For a new person, it will confuse them.

Respectfully, I will not be looking at your code. I want this plugin to remain "mine" and if I use your code, that will no longer be teh case.. even if you did use my code originally.

one might argue 95% are good enough, and i dont wanna force you to anything, i just wanted to point that out
--- merged: Feb 5, 2011 1:13 AM ---
i have already done that, and feel free to take my code, you can even sell it

I dont even have access to your code so I could not if i wanted to.

Please update your posts in the thread, its created confusion for some people and Im getting pinged about it.

lol, i have posted links to the source code, its still there
and as i said before i have already done that
--- merged: Feb 5, 2011 1:22 AM ---
okay, so if you are not going to fix this problem, i will release my own plugin for this, i need a stable version for my server

Wtf? Now your just being disrespectful.

I never said I was not going to fix the problem. I have given you an update I think fixes the issue; But you have not told me if it works or not.

what kind of update?
you are still calling setTime() and stuff from that timer thread
--- merged: Feb 5, 2011 1:30 AM ---
looking at your "fix" only tells me that you did not understand the actual issue:

it is of no importance whether you call setTime() through a variable or not, the problem is: don't call it from another thread
--- merged: Feb 5, 2011 1:33 AM ---
+++++++++

okay forget the issue, i just analyzed the implementation of setTime() and getTime(), as long as you only call setTime() and getTime() chances are very low it crashes, it just might corrupt the server time in a few cases

Just because I havent updated my github yet doesn't mean I haven't updated the download links file.

Fine, I took a look at your version on a seperate computer from my sources.. and its noodle code. To make it worse, it actually calls Minecraft code and imports minecraft directly. I felt so dirty looking at it, I need to go take a shower. No plugin should ever directly import minecraft. Use bukkit! Its not just a technical layer, its a legal layer, and not using it in plugins hurts us all.

Like i said originally: THIS IS A BUKKIT BUG. Please report it to the correct people and it will get fixed.
--- merged: Feb 5, 2011 1:38 AM ---
If your looking at the code for setTime/etc submit a patch to bukkit,
--- merged: Feb 5, 2011 1:53 AM ---
Code updated to correctly trap the thrown exception and explain the issue.

The Bukkit team has clearly stated their position on this...plugin authors are not required to use GPL or even release their source code. Please stop harassing the people who make using Bukkit worthwhile.

http://forums.bukkit.org/threads/what-license-is-the-bukkit-project-under.154/

Further, taking people's code and rereleasing it obliges you to follow the terms of the GPL as well. What this basically means is that after "fixing" feverdream's plugins for him, Redecouverte, you have to provide your forked source. And if feverdream wants to merge your changes back in... well, that's his prerogative.

Bukkit is released in the GPL. The Bukkit teams official stance on this is plugin developers don't have to do squat and are not forced to release source code; I do it anyway because I'm a nice guy.

I also only release my code under a AGPL license and BSD license mix that is COMPLETELY COMPATIBLE with the GPL, meaning all my source code is under the GPL, the AGPL, and the BSD license. This is perfectly legal, and means that in addition to the obligations created by it being GPL - having to give out code - you also have to:

• Keep my "coded by" stuff in the code.
• Add something to the effect of "this uses Feverdream's code" to our coded by/credits.
• If you use my code/plugins on your server, and somebody uses your server, they have the same entitlement to the source you do. You cant for example sell access to a service that uses my plugins, and not give out the code for that service. You have to.
• Remember that your code must be released under this mix as well.

The guy who had modified and distributed my plugin without permission or even following the licence fully had a version of the code that actively imports and uses Notches code by calling minecraft - yes, Notches Code - directly; I'm against this as it does everything the craftbukkit team is trying to do by making bukkit a interface to gain legal protections and that hurts EVERYBODY using Craftbukkit. I also dont consider people taking my plugin code and not even using the bukkit interface to be "cool".

Just so people know, I just attempted to file a bug report with bukkit to get the interface fixed so this rare bug that hardly ever hits anybody will no longer be an issue at all, but they seem to be having issues with permissions on it at this time. I'm sure it will be fixed soon, but until then this issue did not affect many people and it doesn't do anything at all even if did it now that I have updated the plugin to mitigate the risk.

Redecouverte, I really appreciate your contributions that kept ExtendDay working during feverdream's absence. I do hope to see your own plugin released soon.

Regardless does this extend night as well? I'm getting mixed signals or not reading everyone clearly.