Need help! Trying to build a block manipulation plugin

Hello,

I new to programming. I just learned java a week ago. This is my second try in making a plugin. I've been following many Java tutorials as well as Bukkit plugin tutorials themselves.

Code:java

package me.phoenix;
 
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.permissions.Permission;
import org.bukkit.plugin.PluginManager;
import org.bukkit.plugin.java.JavaPlugin;
 
public class BlockListener extends JavaPlugin {
 
    public Permission playerPermissionBedrock = new Permission("place.blockedbedrock");
    public Permission playerPermissionTNT = new Permission("place.blockedtnt");
 
    @Override
    public void onEnable() {
        getLogger().info("Grief protection V. 1.1 by SkyZ Developpers!");
        new antiblock(this);
        PluginManager pm = getServer().getPluginManager();
        pm.addPermission(playerPermissionBedrock);
        pm.addPermission(playerPermissionTNT);
    }
 
    @Override
    public void onDisable() {
        getLogger().info("DISABLING CUSTOM GRIEF PROTECTION");
 
 
    }
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
 
        if (cmd.getName().equalsIgnoreCase("blocklistener") && sender instanceof Player) {
 
            Player player = (Player) sender;
 
            player.sendMessage(ChatColor.GOLD + "Private plugin made by Phoenix566 :)");
 
            return true;
    }
 
    return false;   
 
 
    }       
 
 
 
 
    public boolean onCommand2(CommandSender sender, Command cmd, String label, String[] args) {
 
        if (cmd.getName().equalsIgnoreCase("bannedblocks") && sender instanceof Player) {
 
            Player player = (Player) sender;
 
            player.sendMessage(ChatColor.GREEN + "Banned Blocks: " + ChatColor.RED + "TNT, Bedrock");
 
            return true;
 
    }   
 
    return false;
 
    }
 
 
 
}

And this..

Code:java

package me.phoenix;
 
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.BlockPlaceEvent;
 
 
public class antiblock implements Listener {
 
 
 
    public antiblock(BlockListener plugin) {
    plugin.getServer().getPluginManager().registerEvents(this, plugin);
 
 
  }
 
  @EventHandler
  public void onBlockPlace(BlockPlaceEvent e) {
 
      Player player = e.getPlayer();
 
      if (e.getBlock().getType() == Material.BEDROCK);
          if (!player.hasPermission("place.blockedbedrock")) {
              e.setCancelled(true);
              player.sendMessage(ChatColor.RED + "Sorry, but you lack permission to place " + ChatColor.BLUE + ChatColor.BOLD + e.getBlock().getType().toString());
 
 
          }         
 
      if (e.getBlock().getType() == Material.TNT);
          if (!player.hasPermission("place.blockedtnt")) {
              e.setCancelled(true);
 
 
 
  }
 
 
  }     
 
}
 
 
 
 
 

Here are the issues. After exporting it and placing it on my plugins folder, it has no errors whatsoever. The first command, /blocklistener, works fine. However, I was not able to execute the /bannedblocks command which gives a list of banned blocks. It sends back a white text: "/bannedblocks", the command itselt, and shows no list that I'm expecting.

Second issue, the plugin instead, bans all blocks. What's wrong with my code? All I want is to ban TNT and Bedrocks to players that lack the permissions. Please go easy on me, as I am new to these things.

Thanks

 

1) The onCommand method is called whenever a command from your plugin is executed, onCommand2 however, is not. Put the "bannedblocks" command part inside onCommand as well.
An alternative is registering a CommandExecutor for the command.

2) You used a semi-collon after the if statement, this will make it execute the code below regardless of the condition of your if statement, add a body instead:

Code:

if (e.getBlock().getType() == Material.BEDROCK) {
    //Your code inside here. This will execute if the condition is true
}

 

onCommand is an overridden method. It will be called whether you have it or not. onCommand2 isn't being called. Since you are overriding a method, put the @Override annotation above the overridden methods. It's there for the developers' convenience. Bukkit does so many things for you that it would be better to just learn Java first, then the Bukkit API.

 

I was able to get the Bedrock code working, thanks. However, the same cannot be said for the TNT code. I am still able to place TNT down. Here's the edited code:

Code:java

package me.phoenix;
 
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.BlockPlaceEvent;
 
 
public class antiblock implements Listener {
 
 
 
    public antiblock(BlockListener plugin) {
    plugin.getServer().getPluginManager().registerEvents(this, plugin);
 
 
    }
 
 
 
 
  @EventHandler
  public void onBlockPlace(BlockPlaceEvent e) {
 
      Player player = e.getPlayer();
 
      if (e.getBlock().getType() == Material.BEDROCK) {
          if (!player.hasPermission("place.blockedbedrock")) {
              e.setCancelled(true);
              player.sendMessage(ChatColor.RED + "Sorry, but you lack permission to place " + ChatColor.BLUE + ChatColor.BOLD + e.getBlock().getType().toString());
 
 
          }         
 
      if (e.getBlock().getType() == Material.TNT) {
          if (!player.hasPermission("place.blockedTNT")) {
              e.setCancelled(true);
          }
      }
 
      }
 
  }
 
}

What else have I done wrong with my code?

Thanks

 

Bump