Need help with bug

Hi all,
I have encountered a problem with my plugin, a NullPointerException in the following snippet. It is on the line "if (loc.add(countX.counter, countY.counter, countZ.counter) != null) {", which is in itself checking whether its a null. I have no clue of how to fix this, and any help would be appreciated.

Code Snippet:

Code:java

public static HashSet<Block> getBlocksInRange (Location loc, int range) {
        HashSet<Block> toBeReturned = new HashSet<Block>();
        HashSet<Counter> countersX = new HashSet<Counter>();
        HashSet<Counter> countersY = new HashSet<Counter>();
        HashSet<Counter> countersZ = new HashSet<Counter>();
        boolean stop = false;
        int n = 0;
        while (!stop) {
            Counter counter = new Counter();
            counter.counter = n;
            countersX.add(counter);
            countersY.add(counter);
            countersZ.add(counter);
            n += 1;
            if (n == (range+1)) {
                stop = true;
            }
        }
        for (Counter countX : countersX) {
            for (Counter countY : countersY) {
                for (Counter countZ : countersZ) {
                    if (((Integer) countY.counter) != null && ((Integer) countX.counter) != null && ((Integer)countZ.counter) != null) {
                        if (loc.add(countX.counter, countY.counter, countZ.counter) != null) {
                            if (loc.add(countX.counter, countY.counter, countZ.counter).getBlock() != null) {
                                toBeReturned.add(loc.add(countX.counter, countY.counter, countZ.counter).getBlock());
                            }
                        }
                        if (loc.subtract(countX.counter, countY.counter, countZ.counter) != null) {
                            if (loc.subtract(countX.counter, countY.counter, countZ.counter).getBlock() != null) {
                                toBeReturned.add(loc.subtract(countX.counter, countY.counter, countZ.counter).getBlock());
                            }
                        }
                    }
                }
            }
        }
        return toBeReturned;
    }

 

Well since you tested in the line above if the counters were null and it returned they weren't, the only thing that could be null and provoke an exception on this line is your loc argument. You have to make sure it is not null before manipulating it.

The exception is thrown because you try to call the add() method of your loc object, and on that line you are checking if the return value of add() is null, not the object itself.

 

It is probably because "loc" is null. You can't use Location#add method when the location itself is null.
Edit: Ninja'd

 

Bug = squashed! I was calling getBlocksInRange() in a static initializer with a location that was defined below it! I'm suprised Eclipse didn't detect it...