Need help with getTypeId()

Hey guys,
I am making my own sort of Essentials plugin called ManyCommands. I recently was playing around and decided to create something so if you left or right click with a bone in your hand you shoot an arrow! I just want to figure out what other method to use so that these aren't deprecated. Here is my code so far:

Code:java

    @EventHandler
    public void onPlayerUse(PlayerInteractEvent evt) {
        Player player = evt.getPlayer();
        if(player.getItemInHand().getTypeId()==352)player.shootArrow();
    }

Currently the .getTypeId(), and the shootArrow are underlined in yellow with a strikethrough as deprecated. I was wondering if any of you knew an alternative to this, it will help me out lots!
Thanks,
Dylan.

 

using item ids are not handy to use! Just use getType() and Material.

if(player.getItemInHand().getType()== Material.BONE_MEAL)player.shootArrow();
and I think the player.shootArrow(); doesn't work but you can try it

 

Do getType(), your test becomes (Material.Bone.compareTo(player.getItemInHAnd().getType())==0)
And I think it is launchProjectile(Arrow.class) instead of shootArrow()

 

Hartorn
Why Material.BONE.compareTo(player.getItemInHand().getType())==0 instead of Material.BONE == player.getItemInHand().getType()?

 

Barnyard_Owl :
True, no reason to do that, since it is enum.

 

I added this

Code:java

    @EventHandler
    public void onPlayerUse(PlayerInteractEvent evt) {
        Player player = evt.getPlayer();
        if(player.Material.BONE.compareTo(player.getItemInHand().getType())==0);
    }

And the Material is underlined red saying "Material cannot be resolved or is not a field"
I'm sorry if I am doing it wrong, I have started up coding again and I end up getting the weirdest mistakes when people tell me to add something.

 

It's not player.Material... Material is an enum. It's just Material.BONE.

 

Okay,

Code:java

    @EventHandler
    public void onPlayerUse(PlayerInteractEvent evt) {
        Player player = evt.getPlayer();
        if(Material.BONE.compareTo(player.getItemInHand().getType())==0);
    }

I have added that and imported and It's fine now, how would I now make it shoot an arrow? I have used player.shootArrow() in previous attempts and it works but its deprecated, and I tried the advice from Hartorn but it underlined it all pretty much. Do I need to create anything else? I am still a beginner in Java making my way but I just need guidance haha.

 

Minermax7
Try player.launchProjectile(Arrow.class).

EDIT : Check out the documentation
http://jd.bukkit.org/rb/doxygen/d4/...Entity.html#adbb30d3502cbb9493c772e881878f71d

 

How could I be able to set the lore of the item?
So like if I do /launcher it would give me a bone named something like "Troller" for example?

 

ItemStack bone = new ItemStack(Material.BONE, 1);
ItemMeta meta = bone.getItemMeta();
meta.setLore(Arrays.asList("lore1", "lore2"));
meta.setDisplayName("Troller");
bone.setItemMeta(meta);

 

With something like this.

Code:

ItemMeta  meta =player.getItemInHand().getItemMeta();
List<String> lore = new ArrayList<String>();
lore.add(ChatColor.RED + "Troller");
meta .setLore(lore);
player.getItemInHand().setItemMeta(meta );

Edit : Was too slow ^^

 

MOMOTHEREAL When I try your code, I run the command ingame and nothing happens, no text or anything comes up and I don't get any items...

Code:java

            if(cmd.getName().equalsIgnoreCase("alauncher")) {
                ItemStack bone = new ItemStack(Material.BONE, 1);
                ItemMeta meta = bone.getItemMeta();
                meta.setLore(Arrays.asList("lore1", "lore2"));
                meta.setDisplayName("Troller");
                bone.setItemMeta(meta);
            }

 

Because you just created an itemStack but never put it anywhere (in the world, in player's inventory, etc). You have to put it somewhere for it to exist, otherwise its just a thought that gets forgotten when the method is finished executing.

 

Just replace

Code:

  ItemStack bone = new ItemStack(Material.BONE, 1);

by

Code:

  ItemStack bone =player.getItemInHand();

 

BillyGalbreath Ok, sorry for bugging you. But where could I put the code to get the players inventory and that?

 

Minermax7 Add player.getInventory().addItem(bone);