Solved Players in a Chest GUI

I'm making a Spectator plugin and I would like to make a chest GUI with all players in it, I don't know how to make it :/

Is anyone have an idea ?

I already made this but it's not working :/

Code:java

    @EventHandler
    public void onInteract(PlayerInteractEvent e)
    {
        Player p = e.getPlayer();
        ItemStack i = p.getInventory().getItemInHand();
        ItemStack player = null;
 
        if(i.getType().equals(Material.NETHER_STAR)
                && i.hasItemMeta()
                && i.getItemMeta().getDisplayName().equalsIgnoreCase(ChatColor.GREEN + "Joueurs connectés " + ChatColor.GRAY + "(Clique Droit)"))
        {
 
            Inventory players = Bukkit.getServer().createInventory(null, 54, ChatColor.GREEN + "Joueurs Connectés");
 
            int op = Bukkit.getOnlinePlayers().length;
 
            for(Player pl : Bukkit.getOnlinePlayers())
            {
                player = new ItemStack(Material.SKULL);
                ItemMeta im = player.getItemMeta();
                im.setDisplayName(ChatColor.AQUA + pl.getName());
                player.setItemMeta(im);
 
                for(int in = 0; in <= op; in++)
                {
                    players.setItem(0, player);
                }
            }                   
 
            p.openInventory(players);           
        }
    }

 

You need to the cast the ItemMeta as a SkullMeta in this case:

Code:

SkullMeta im = (SkullMeta) player.getItemMeta();

This would be similar to ItemMeta, except with a set owner method, so in your case:
im.setOwner(pl.getName());

Also you may want to use better naming conventions as your ItemStack is named 'player', which can be confused for an actual player, the same with your inventory name.

You are also looping through a bunch of players replacing the ItemStack at slot 0 each time, so if you got this to work, there would only be one skullmeta in the "players" inventory.


And one more thing; you should replace your inventory variable with this, assigning the InventoryHolder to the player, otherwise it is returning null; preventing the player from opening the inventory
Inventory players = Bukkit.getServer().createInventory(p, 54, ChatColor.GREEN + "Joueurs Connectés");

 

DoctorDark
First, thanks for your answer

I tried this but I get an error :/

Code:java

 @EventHandler
public void onInteract(PlayerInteractEvent e)
{
Player p = e.getPlayer();
ItemStack item = p.getInventory().getItemInHand();
ItemStack pHead = null;
 
if(item.getType().equals(Material.NETHER_STAR)
&& item.hasItemMeta()
&& item.getItemMeta().getDisplayName().equalsIgnoreCase(ChatColor.GREEN + "Joueurs connectés " + ChatColor.GRAY + "(Clique Droit)"))
{
 
Inventory onlinePlayers = Bukkit.getServer().createInventory(p, 54, ChatColor.GREEN + "Joueurs Connectés");
 
int op = Bukkit.getOnlinePlayers().length;
 
for(Player pl : Bukkit.getOnlinePlayers())
{
pHead = new ItemStack(Material.SKULL);
SkullMeta im = (SkullMeta) pHead.getItemMeta();
im.setOwner(pl.getName());
pHead.setItemMeta(im);
 
for(int i = 0; i <= op; i++)
{
onlinePlayers.setItem(i, pHead);
}
}
 
p.openInventory(onlinePlayers);
}
}

Error: http://hastebin.com/efagevipiz.avrasm

 

maestro34

pHead =new ItemStack(Material.SKULL);

should be

pHead = new ItemStack(Material.SKULL_ITEM);

 

DoctorDark Thanks It's working But I have two heads in the inventory :/

 

Then make use of google, add debug lines to see what's going on in the loop etc.

 

DoctorDark I tried this, It's working but in the inventory when two people are online, the two skulls have the same name :/

Code:java

    @EventHandler
    public void onInteract(PlayerInteractEvent e)
    {
        Player p = e.getPlayer();
        ItemStack item = p.getInventory().getItemInHand();
        ItemStack pHead = null;
 
        if(item.getType().equals(Material.NETHER_STAR)
                && item.hasItemMeta()
                && item.getItemMeta().getDisplayName().equalsIgnoreCase(ChatColor.GREEN + "Joueurs connectés " + ChatColor.GRAY + "(Clique Droit)"))
        {
 
            Inventory onlinePlayers = Bukkit.getServer().createInventory(p, 54, ChatColor.GREEN + "Joueurs Connectés " + ChatColor.GRAY + "(" + Bukkit.getOnlinePlayers().length + "/" + Bukkit.getServer().getMaxPlayers() + ")");
 
            int op = Bukkit.getOnlinePlayers().length;
 
            for(Player pl : Bukkit.getOnlinePlayers())
            {
                pHead = new ItemStack(Material.SKULL_ITEM, 1, (short) 3);
                SkullMeta im = (SkullMeta) pHead.getItemMeta();           
                im.setOwner(pl.getName());
                im.setDisplayName(ChatColor.AQUA + im.getOwner());
                pHead.setItemMeta(im);                       
            }   
 
            for(int i = 1; i <= op; i++)
            {
                onlinePlayers.setItem(i - 1, pHead);
            }
 
            p.openInventory(onlinePlayers);           
        }
    }

 

remove the for loop and do something like

Code:java

int i = 0;
for (Player pl : Bukkit.getOnlinePlayers())
{
    ... //code
    onlinePlayers.setItem(i, pHead);
    i++;
}

If you have the for loop outside it will use the last pHead that was set, if you have it inside you will pretty much spam the same head several times, so its better to just set a variable outside the for each loop, and then use that in the foreach loop and at the end just increase it (same logic as a for loop but inside a foreach loop)

I am sure there is other ways to do this but, this should work atleast

 

tryy3 Tanks it's working