Plugin YAML - Main: error

Hey guys, I have just finished making my first nice plugin; cEssentials. After I exported it into the \plugins directory and ran the server, I was immediately sent an error message telling me "Couldn't find main class 'me.ClassyCoconut.cEssentials'". I was devastated by this text and instantly tried to find a solution to it. Alas, I couldn't find any fixes which is why I came here as my last hope.

Plugin.YML - http://hastebin.com/otaxiwugir.sm

Code:

name: cEssentials
main: me.ClassyCoconut.cEssentials
version: 1.0
commands:
  admin:
  teleport:
  vanish:
  ban:
  check:
  unban:
  clearchat:
  heal:
  clear:
  broadcast:
  kill:
  killall:
  inventory:
  message:
  reply:
  join:
  leave:
  fly:
  skull:
  help:

Main.class - http://hastebin.com/atuvaruxuq.avrasm

Code:java

package me.ClassyCoconut.cEssentials;
 
import java.io.File;
import java.util.ArrayList;
 
import me.ClassyCoconut.cEssentials.Commands.CommandAdmin;
import me.ClassyCoconut.cEssentials.Commands.CommandBan;
import me.ClassyCoconut.cEssentials.Commands.CommandBroadcast;
import me.ClassyCoconut.cEssentials.Commands.CommandCheck;
import me.ClassyCoconut.cEssentials.Commands.CommandClearChat;
import me.ClassyCoconut.cEssentials.Commands.CommandClearInventory;
import me.ClassyCoconut.cEssentials.Commands.CommandDeop;
import me.ClassyCoconut.cEssentials.Commands.CommandHeal;
import me.ClassyCoconut.cEssentials.Commands.CommandInvSee;
import me.ClassyCoconut.cEssentials.Commands.CommandJoin;
import me.ClassyCoconut.cEssentials.Commands.CommandKill;
import me.ClassyCoconut.cEssentials.Commands.CommandKillAll;
import me.ClassyCoconut.cEssentials.Commands.CommandLeave;
import me.ClassyCoconut.cEssentials.Commands.CommandMe;
import me.ClassyCoconut.cEssentials.Commands.CommandMessage;
import me.ClassyCoconut.cEssentials.Commands.CommandReply;
import me.ClassyCoconut.cEssentials.Commands.CommandSkull;
import me.ClassyCoconut.cEssentials.Commands.CommandTeleport;
import me.ClassyCoconut.cEssentials.Commands.CommandUnban;
 
import org.bukkit.Bukkit;
import org.bukkit.Material;
import org.bukkit.configuration.file.FileConfiguration;
import org.bukkit.configuration.file.YamlConfiguration;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.AsyncPlayerChatEvent;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.event.player.PlayerLoginEvent;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.SkullMeta;
import org.bukkit.plugin.PluginManager;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin implements Listener {
 
    public ArrayList<String> admin = new ArrayList<String>();
    public ArrayList<String> vanished = new ArrayList<String>();
 
    public void onEnable() {
        System.out.println("cEssentials was enabled!");
        PluginManager pm = Bukkit.getPluginManager();
        pm.registerEvents(this, this);
        connectCommands();
    }
 
    public void onDisable() {
        System.out.println("cEssentials was disabled!");
    }
 
    @SuppressWarnings("deprecation")
    @EventHandler
    public void onPlayerJoin(PlayerJoinEvent event) {
        Player player = event.getPlayer();
        for(String players : vanished) {
            Player vanishedPlayers = Bukkit.getPlayer(players);
            vanishedPlayers.hidePlayer(player);
        }
    }
 
    @EventHandler
    public void onLogin(PlayerLoginEvent event) {
        Player player = event.getPlayer();
        if(player.isBanned()) {
            FileConfiguration config = null;
            File file = new File("plugins" + File.separator + "cEssentials" + File.separator + "players" + File.separator + player.getName());
            config = YamlConfiguration.loadConfiguration(file);
            String banreason = config.getString("ban_reason");
            String bannedby = config.getString("ban_sender");
            event.disallow(PlayerLoginEvent.Result.KICK_BANNED, "§7You were banned for " + banreason);
 
        }
    }
 
    public void clearInv(Player p)
    {
    for(int j=0; j<38; j++)
    {
    p.getInventory().setItem(j, null);
    }
    p.getInventory().setHelmet(null);
    p.getInventory().setChestplate(null);
    p.getInventory().setLeggings(null);
    p.getInventory().setBoots(null);
    }
 
    public void connectCommands() {
        getCommand("admin").setExecutor(new CommandAdmin());
        getCommand("teleport").setExecutor(new CommandTeleport());
        getCommand("ban").setExecutor(new CommandBan());
        getCommand("check").setExecutor(new CommandCheck());
        getCommand("unban").setExecutor(new CommandUnban());
        getCommand("clearchat").setExecutor(new CommandClearChat());
        getCommand("heal").setExecutor(new CommandHeal());
        getCommand("clear").setExecutor(new CommandClearInventory());
        getCommand("broadcast").setExecutor(new CommandBroadcast());
        getCommand("kill").setExecutor(new CommandKill());
        getCommand("killall").setExecutor(new CommandKillAll());
        getCommand("inventory").setExecutor(new CommandInvSee());
        getCommand("reply").setExecutor(new CommandReply());
        getCommand("message").setExecutor(new CommandMessage());
        getCommand("skull").setExecutor(new CommandSkull());
        getCommand("deop").setExecutor(new CommandDeop());
        getCommand("me").setExecutor(new CommandMe());
        getCommand("join").setExecutor(new CommandJoin());
        getCommand("leave").setExecutor(new CommandLeave());
    }
}

Please, people of Bukkit, save my plugin.

 

Taken from http://wiki.bukkit.org/Plugin_YAML

 

Classy

Use the proper access modifier (private) and use proper case in your packages, that's awful to look at.

 

Could you give me a example of those two things? I have never heard of proper case. mythbusterma

EDIT: Nevermind I fixed it up

I just received errors with my main class after I tried to use the command /vanish. Can anyone help by telling me what I failed at in the main?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Could you post your error log please?

 

ColonelHedgehog http://gyazo.com/3d8365737922f4d3b8c83cb088491261

 

I'm guessing in your CommandAdmin class, you have a "Main" variable that you assigned a value of "new Main()" to? Can you post that class please?

 

ColonelHedgehog Sure,

Code:java

package me.ClassyCoconut.cEssentials.Commands;
 
import me.ClassyCoconut.cEssentials.Main;
 
import org.bukkit.GameMode;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
 
public class CommandAdmin extends Main implements CommandExecutor {
 
public boolean onCommand(CommandSender sender, Command cmd, String tag, String[] args) {
if(!(sender instanceof Player)) {
sender.sendMessage("§cYou can not use this command via Console!");
return true;
}
Player player = (Player) sender;
if(sender.hasPermission("cess.admin"));
if(admin.contains(player.getName())) {
player.showPlayer(player);
player.setGameMode(GameMode.SURVIVAL);
player.sendMessage("§7You are now in PLAY mode!");
admin.remove(player.getName());
} else {
player.setGameMode(GameMode.CREATIVE);
player.hidePlayer(player);
player.sendMessage("§7You are now in ADMIN mode!");
admin.add(player.getName());
}
return false;
}
 
}
 

 

Classy
CommandAdmin shouldn't extend Main, which is why it's saying "Plugin already initialized!"

 

AzureDev so should I just change that line to

EDIT: If I do this (Under this Text) the whole cmd won't work as it has an ArrayList in the Main class

1. public class CommandAdmin implements CommandExecutor{

 

Classy
Make a static method/variable for Main in the Main class and then implement it into CommandAdmin?

 

AzureDev How would I do that

 

AzureDev why recommend that if the only place he needs to use the array is in the command class. Move the array and the PlayerJoinEvent into that class as well.

 

Relicum True.

 

Relicum So would I just remove the Extends Main and place the array into it? btw I do not have a PlayerJoinEvent for CommandAdmin.

 

The reason why vanish doesn't work is you never assign it its executor, see the list in your Main class. Just because vanish is in your plugin.yml how does it know that its executor is the admin class ??

Also do not save the players using their names as player reference as they are no longer its unique identifier, use the UUID of the player as that is what its indexed under locally. Depending on what version of craftbukkit your using when you try and do player lookup by names it has to send a web request to mojang to get the UUID for that name, this can become a blocking method if mojang is busy.

Also the Arraylist is not syncronised and your run into loads of issues with concurrentmodification errors. As the bare minimum create the Arraylist like this.

Code:java

private List<UUID> players = Collections.synchronizedList(new ArrayList<>());

Google what it all means.

PS Also the if/else statement in the CommandsAdmin never returns true and will always fall through to the return false statement below it. This will cause you confusion as it will keep showing the command usage.

Regards

That is correct, but think about it if you could not access the array from CommandAdmin as it was in main if you move it into CommandsAdmin, how is the playerJoinEvent going to now access the array ???

Also I can't actually see what the difference between you Admin and Vanish command, as there is no logic specific to Vanish in CommandsAdmin. Yes you update the vanish status. But that's not a different command to admin. Can you explain the difference between the 2 ??

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Relicum

Why does that need to be synchronized, it's never used in more than one thread so what would cause it to need to be synchronized? All you're doing with that is slowing it down. Furthermore, requesting an online Player's UUID is never "blocking," it is always (nearly) instantaneous .

 

Relicum I have two different classes, CommandAdmin and CommandVanish. Also after I added Vanish to the list of executing cmds, It still hadn't worked.
This is the vanish code

Code:

package me.ClassyCoconut.cEssentials.Commands;
 
import java.util.ArrayList;
 
import org.bukkit.Bukkit;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
 
public class CommandVanish implements CommandExecutor {
   
    public ArrayList<String> vanished = new ArrayList<String>();
   
    public boolean onCommand(CommandSender sender, Command cmd, String tag, String[] args) {
        if(!(sender instanceof Player)) {
            sender.sendMessage("§cYou can not use this command via Console!");
            return false;
        }
        return false;
    }
    public void vanish(Player player) {
    if(player.hasPermission("cess.vanish"));
        if(isVanished(player)) {
            for (Player players : Bukkit.getOnlinePlayers()) {
                players.hidePlayer(player);
                vanished.add(player.getName());
                player.sendMessage("§7You are now invisible.");
            }
        } else {
            for (Player players : Bukkit.getOnlinePlayers()) {
                players.hidePlayer(player);
                vanished.remove(player.getName());
                player.sendMessage("§7You are now visible.");
            }
        }
    }
   
    public void vanishPlayer(Player player) {
    if(player.hasPermission("cess.vanish"));
        if (isVanished(player)) {
            player.sendMessage("§7You are already invisible.");
            return;
        }
        for (Player players : Bukkit.getOnlinePlayers()) {
            players.hidePlayer(player);
            vanished.add(player.getName());
        }
    }
       
 
    public void unvanishPlayer(Player player) {
    if(player.hasPermission("cess.vanish"));
        if (isVanished(player)) {
            player.sendMessage("§7You are already visible.");
            return;
        }
        for (Player players : Bukkit.getOnlinePlayers()) {
            players.hidePlayer(player);
            vanished.remove(player.getName());
            player.sendMessage("§7You are now invisible.");
        }
    }
   
    public boolean isVanished(Player player) {
        if(vanished.contains(player.getName()));
        return false;
    }
}

 

Classy

Because your "vanish" method is apparently not being invoked?

 

haha funniest thing I have heard in a long time, of course its blocking for a start when ever the login servers are down its blocking and its near instant "most" of the time give to cached conditions. When will you people learn, regardless of access time to lookup the UUID using the player name, this is adding latency, when if storing by uuid it can return the way in the fastest possible time due to it being an index.

How can you possible know what the rest of his code is doing in regards to that array. Also just because its "running" on the main thread doesn't stop to objects trying to access it at the same time. Do you homework.

 

mythbusterma Relicum How do I invoke it?

 

Classy

mythbusterma is correct your onCommand checks sender instance and that's it.

 

Relicum

The objects it's accessing are unmodifiable fields stored in the base player class that is created when the user joins the server, the only time the lookup is done is when the user joins the server. There is absolutely zero latency when accessing a field from a series of getters, only the time it takes to execute the instruction (possibly the time it takes to lookup the value in memory). If the login servers are down, it won't even let the player join the game, assuming the server isn't cracked. Also, as long as none of his objects are trying to access it from a different thread, then nothing will. Nobody writing the JVM was stupid enough to ignore thread safety to the point where you would need to synchronize lists for no reason.

 

Classy Do not use

Code:

§7

use

Code:java

(ChatColor.GRAY + " ");

instead. It is a bad habit get into. Good luck!

 

Says who? The ChatColor enum has always been a waste of time for me.

 

ColonelHedgehog Probably won't happen, but hypothetically, what if the underlying chat formatting format changed? All that would have to be updated would be the ChatColor enum, and assuming you used the enums ypu wouldn't have to change your code at all. Not such a waste of time now, is it? This is the whole point of abstraction. Further it makes your code a lot more readable.

 

Rocoty Beat me to it! Well said!

 

Most IDEs have a replace-all-in-project command. That's a very specific instance which will most likely never happen. Besides, wouldn't that mean the ChatColor enum would, in theory, have to be changed too?

 

ColonelHedgehog That's what I said, yes. The ChatColor enum would have to change, but not your code (assuming you use the ChatColor enum), or any other code for that matter. Because the ChatColor enum serves as a layer of abstraction between the chat format and your code. Using replace-all would still mean you'd have to recompile your code, which in most cases isn't desirable.

It basically means you wouldn't have to release new versions of your plugin so long as Bukkit follows up with the change. What the users of your plugin would have to do is simply to update Bukkit, and your plugin will work just as well as it's always done. But, yes. I agree ChatColor is a bad example.

 

And of course the flaw with Bukkit updating is that we're not sure it ever will. It takes way less time to update your plugin than it does for Bukkit to update.