Problem with my InvTeleporter! (PlayerDeathEvent)

Hello ,

I have a Problem with my teleporter.
The Teleporter (commandexecutor, or whatever) works fine but if someone dies the TeleportItem gets dropped and can be picked up. that should not happen... .

I hope someone can help me out with some examples, because this is the first time i'm making a Plugin.

Thanks.

Here ist the Line I need:

Code:java

    @EventHandler(priority = EventPriority.NORMAL)
    public void onDeath(PlayerDeathEvent e) {
        //i want to remove only the TeleporterItem in slot 8 which would get dropped on the ground so it cant be
        //picked up after death.
    }

Here is the full code: http://pastebin.com/PqK3kRej

 

ColdRaker getDrops(), get an Iterator, loop over the Iterator, call .remove() when you encounter an item that should not be dropped.

 

@fireblast709 thanks for the fast response i dont now how to do this right now but i will look over it and try it out^^

 

ColdRaker dropitemevent => check if dropped item is teleporter => cancel.

 

I already have the cancel event inside the code

Code:java

    @EventHandler(priority = EventPriority.NORMAL)
    public void onDrop(PlayerDropItemEvent e) {
        if(e.getItemDrop().getItemStack().getItemMeta().getDisplayName().equalsIgnoreCase("§3§lTeleporter")) {
            e.setCancelled(true);
        }
    }

doesnt work

This is what i got so far ... is this alright? and if it is, how do i remove the item now?

Code:java

    @EventHandler(priority = EventPriority.NORMAL)
    public void onDeath(PlayerDeathEvent e) {
        e.getDrops();
        List<String> DroppedItems = Arrays.asList(Bukkit.getName());
        Iterator<String> iterator = DroppedItems.iterator();
        if(iterator.next().contains("§3§lTeleporter")){
        }
    }

fireblast709 could you post a code example. Its the first time I use loops and iterators

So ich denke in jeder Zeile sind "Viele" Fehler. Wenn sich das mal jemand ansehen könnte wäre ich dankbar
ich denke ich habe auch vieles einfach eingefügt was ich so nicht benutzen kann :/

Code:

    @EventHandler(priority = EventPriority.NORMAL)
    public void onDeath(PlayerDeathEvent e) {
        e.getDrops();
        List<String> DroppedItems = Arrays.asList(Bukkit.getName());
        Iterator<String> iterator = DroppedItems.iterator();
        if(iterator.next().contains("§3§lTeleporter")){
            e.getDrops().remove("§3§lTeleporter");
        }
        else{
            return;
        }
    }

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

ColdRaker ok so, let me get this straight. "Get an Iterator" means "Get an Iterator of event.getDrops()" . (I'm sorry if I was unclear). Secondly, when googling "looping over an iterator" gave me this as the first hit. Then, check for a few things:

• Check if the ItemStack has meta (there is a method for this which you can find in the documentation)
• Get the ItemMeta
• Check if the ItemMeta has a displayname (once more, check the documentation ;3)
• Check if the displayname equals your String
• call Iterator#remove() if all of the above are true (and make sure you check them in that exact order)

 

fireblast709 great! thank you for the detailed explaination I think I can do it now. I will post the finished code later ^^

fireblast709 I don't understand how to get the last part to work. (while-part)
event. (e.) to aks for the meta,displayname etc (but i dont have an event, or I cant see one)
how can I implement the Iterator#remove() to remove the found item?

Code:

    @EventHandler(priority = EventPriority.NORMAL)
    public static void onDeath(PlayerDeathEvent e) {
        e.getDrops();
        List<String> DroppedItems = new ArrayList<>();
        DroppedItems.add("§3§lTeleporter");
        useWhileLoop(DroppedItems);
    }
 
    private static void useWhileLoop(Collection<String> aDroppedItems) {
        Iterator<String> DroppedItemsIter = aDroppedItems.iterator();
        while (DroppedItemsIter.hasNext()){
            if(e.getDrop().hasItemStack().hasItemMeta().getItemMeta().getDisplayName().equalsIgnoreCase("§3§lTeleporter")) {
            System.out.println(DroppedItemsIter.next());
           
            Iterator#remove()
            }
        }
    }

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

ColdRaker you still seem to miss a lot of what I explained... For example, your Iterator should be

Code:java

event.getDrops().iterator();

And you cannot chain all those method calls in that if statement. Also "Iterator#remove()" means "calling remove() on the Iterator instance"

 

okey thank you for the help. I think i should learn more about java at all