Pull Request Handling Improvements

Discussion in 'Bukkit News' started by EvilSeph, Mar 19, 2013.

     
  1. Offline

    EvilSeph Bukkit Team Lead Administrator

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    Minecraft account:
    MCUSERNAME
    A little over a week ago we announced some of the improvements across the Bukkit project on which we have been working. One of the issues we touched upon was the unacceptable delay the community has been experiencing when it came to getting their pull requests into the project - or, in some cases, even getting a response. Unfortunately, we reached a point where we were not equipped to handle the bulk of the pull requests we were receiving and the entire queue stalled as a result. The Bukkit project is no stranger to community contributions and the clear benefits of fully utilising them: many of the features Bukkit has to offer are thanks to contributions from the community, so addressing this bottleneck is extremely important for us.

    The Pull Request Handling Improvements Initiative
    The Pull Request Handling Improvements initiative consists of several big and important changes to the way we handle code contributions from the community. One key aspect of this initiative is that we now have a Pull Request Handling team dedicated to working with you to get your pull request into the project. This new team consists of individuals hand picked from the Bukkit community to be the bridge between the community and the core Bukkit team.

    The Pull Request Handling Team members are:
    @EdGruberman
    @evilmidget38

    These people listed above have joined the project in order to work closely with each pull request author to help you make sure your pull request meets our strict requirements.

    Our New Contributing Guidelines:
    The other key aspect of our push to improve our pull request handling process is our commitment to providing better documentation on getting involved with the project. Along with the new Get Involved tab (that we'll continue to expand upon) that can be found on this site, we have broken down every single requirement we have for code contributions in a new CONTRIBUTING.md. This CONTRIBUTING.md file is automatically linked by GitHub whenever a pull request is being created so every one knows exactly where to go to educate themselves on our contribution guidelines and requirements.

    In our new Contributing Guidelines, we not only go through every requirement we have, we've also included useful examples, a fancy flow chart and a Pull Request Format Template. Furthermore, if you would like to get a feel for the code formatting issues we keep an eye out for, we have this useful example here.

    Useful Links
    Important Note:
    We no longer want pull request authors to handling squashing and end result commits. We will be handling this internally ourselves as we work with you on your pull request.

    Thanks for your continued support and patience as we work on these awesome improvements to our project. This new initiative is just the beginning of the many extensive changes we'll be making across the project in order to address our deficiencies and in answer to the mistakes that we've made over the years. As we continue to learn from our mistakes and experiments, we think you'll be happy with the direction we'll be taking the project.

    This post has been edited 4 times. It was last edited by EvilSeph Jul 9, 2013.
  2.  
  3. Offline

    TnT Trinitrotoluene Maximus Administrator Bukkit Help

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    Minecraft account:
    MCUSERNAME
    Love it! I can't wait to see the Pull Request Handlers go nuts on those long standing PRs.

    This post has been edited 1 time. It was last edited by TnT Mar 19, 2013.
  4. Online

    mbaxter ʇıʞʞnq ɐ sɐɥ ı Administrator

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    Minecraft account:
    MCUSERNAME
    Big thanks to the above for volunteering :)
    1cec0ld, fredghostkyle1 and Gravity like this.
  5. Offline

    ThaSourceGaming

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    Minecraft account:
    MCUSERNAME
    Okay, Thank you!
  6. Offline

    tyzoid

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    Minecraft account:
    MCUSERNAME
    Awesome! Can't wait to see what comes of this.
  7. Offline

    --GJ--

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    Minecraft account:
    MCUSERNAME
    Thank you @EvilSeph and crew for the opportunity - I look forward to this.
  8. Offline

    AstramG

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    Minecraft account:
    MCUSERNAME
    Thanks for the notifying us!
  9. Offline

    drtshock BukkitDev Staff

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    Minecraft account:
    MCUSERNAME
    More volunteers :D
  10. Offline

    NuclearW

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    Minecraft account:
    MCUSERNAME
    Best of luck, you may find you need it!
    JazzaG likes this.
  11. Offline

    gomeow

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    Minecraft account:
    MCUSERNAME
    That example pull request made me laugh @evilmidget38

    Edit: oh yeah, good job!

    This post has been edited 1 time. It was last edited by gomeow Mar 19, 2013.
  12. Offline

    np98765

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    Minecraft account:
    MCUSERNAME
    Awesome! Thank you, volunteers :)
    fredghostkyle1 likes this.
  13. Offline

    chaseoes BukkitDev Staff

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    Minecraft account:
    MCUSERNAME
    Amazing to see pull request handling improvements! Community (yes, you!) - get involved more!
    Onionbro, fredghostkyle1 and drtshock like this.
  14. Offline

    LandonTheGeek

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    Minecraft account:
    MCUSERNAME
    @gomeow
    Hahaha! LOL!

    Good job Bukkit team for your awesome development team and new updates!
  15. Offline

    riking

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    Minecraft account:
    MCUSERNAME
    Thank you for including me on the team! I look forward to the next 6 months :)
    jorisk322, --GJ-- and -_Husky_- like this.
  16. Offline

    spaceemotion

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    Minecraft account:
    MCUSERNAME
    A great step for the bukkit team, a big (awesome) change for the server owners, plugin developers and minecraft lovers!
    Keep it up ;)
  17. Offline

    gomeow

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    Minecraft account:
    MCUSERNAME
    What happens after that?
  18. Offline

    jorisk322

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    Minecraft account:
    MCUSERNAME
    The end of the world.
    MrBluebear3 and fredghostkyle1 like this.
  19. Offline

    cartose777

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    Minecraft account:
    MCUSERNAME
    Thanks, for all you're doing Bukkit Team. Keep it up :)
  20. Offline

    Lolmewn BukkitDev Staff

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    Minecraft account:
    MCUSERNAME
    Awesome! Approve all the pull requests!
  21. Offline

    C0nsole

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    Minecraft account:
    MCUSERNAME
  22. Offline

    riking

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    Minecraft account:
    MCUSERNAME
    School, of course. :D
  23. Offline

    pcx436

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    Minecraft account:
    MCUSERNAME
    Thanks !
  24. Offline

    Shiva92

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    Minecraft account:
    MCUSERNAME
    yeah ! :D
    fredghostkyle1 likes this.
  25. Offline

    ysl3000

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    Minecraft account:
    MCUSERNAME
    RFC: MultiLineSupport for CustomNameEntity's
  26. Offline

    Johnanater

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    Minecraft account:
    MCUSERNAME
    Sooooooo....... ya.. :)
  27. Offline

    HappyBoyJr

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    Minecraft account:
    MCUSERNAME
    Good work, Bukkit team!

    This post has been edited 1 time. It was last edited by TnT Mar 24, 2013.
  28. Offline

    Pcd2010

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    Minecraft account:
    MCUSERNAME
    Thanks Bukkit Team!
  29. Offline

    storm345(forums)

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    Minecraft account:
    MCUSERNAME
    Its great that bukkit is continuing to expand. It is a great project and im glad it is well cared for. :)
  30. Offline

    Connor2weirdness

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    Minecraft account:
    MCUSERNAME
    I have not a clue what this post is about lol.
  31. Offline

    gomeow

    dev.bukkit.org profile:
    CFUSERNAME
    My Plugins (CFCOUNT)
    Minecraft account:
    MCUSERNAME
    Unless you code plugins/want to code for Bukkit, then this post is unimportant to you

Share This Page