Registering Events

I just wanted to know if I registered this event correctly because /mute broadcasts that the player is muted but it doesn't actually mute them.

Mute:

Code:java

package me.MirrorRealm.kadmin;
 
import java.util.HashMap;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.AsyncPlayerChatEvent;
 
public class Mute implements CommandExecutor, Listener{
    public final HashMap<Player, Player> mute = new HashMap<Player, Player>();
    @EventHandler
    public void onPlayerChatEvent(AsyncPlayerChatEvent event){
        Player target = event.getPlayer();
        if (mute.containsKey(target.getName())){
            event.setCancelled(true);
            target.sendMessage(ChatColor.RED + "You are muted.");
        }else{
            event.setCancelled(false);
        }
    }
    public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args) {
        Player player = (Player) sender;
        if (cmd.getName().equalsIgnoreCase("mute")){
            if (!(player.hasPermission("command.mute"))){
                player.sendMessage(ChatColor.RED + "You do not have permission");
                return true;
            }
            if (args.length == 0){
                player.sendMessage(ChatColor.RED + "/mute <name>");
                return true;
            }
            if (args.length >= 2){
                player.sendMessage(ChatColor.RED + "/mute <name>");
                return true;
            }
            Player target = Bukkit.getServer().getPlayer(args[0]);
            if (mute.containsKey(target)){
                mute.remove(target);
                Bukkit.broadcastMessage(target.getDisplayName() + ChatColor.GREEN + " was unmuted by " + player.getDisplayName() + ".");
                return true;
            }
            if (!(mute.containsKey(target))){
                mute.put(target, null);
                Bukkit.broadcastMessage(target.getDisplayName() + ChatColor.GREEN + " was muted by " + player.getDisplayName() + ".");
            }
        }
        if (cmd.getName().equalsIgnoreCase("unmute")){
            if (!(player.hasPermission("command.unmute"))){
                player.sendMessage(ChatColor.RED + "You do not have permission.");
                return true;
            }
            if (args.length == 0){
                player.sendMessage(ChatColor.RED + "/umute <name>");
                return true;
            }
            if (args.length >= 2){
                player.sendMessage(ChatColor.RED + "/unmute <name>");
                return true;
            }
            Player target = Bukkit.getServer().getPlayer(args[0]);
            if (target == null){
                player.sendMessage(ChatColor.RED + "Could not find player " + args[0]);
                return true;
            }
            if (mute.containsKey(target)){
            Bukkit.broadcastMessage(target.getDisplayName() + ChatColor.GREEN + " was unmuted by " + player.getDisplayName() + ".");
            mute.remove(target);
            }
            if (!(mute.containsKey(target))){
                player.sendMessage(ChatColor.GREEN + "Player " + target.getDisplayName() + " is not muted.");
                return true;
            }
        }
        return true;
    }
}

Main:

Code:java

package me.MirrorRealm.kadmin;
 
import org.bukkit.Bukkit;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin{
    public void onEnable(){
        Bukkit.getServer().getLogger().info("kAdmin has been enabled");
        getCommand("ban").setExecutor(new Ban());
        getCommand("broadcast").setExecutor(new Broadcast());
        getCommand("clear").setExecutor(new Clear());
        getCommand("feed").setExecutor(new Feed());
        getCommand("fly").setExecutor(new Fly());
        getCommand("speed").setExecutor(new Fly());
        getCommand("gamemode").setExecutor(new Gamemode());
        getCommand("heal").setExecutor(new Heal());
        getCommand("k").setExecutor(new K());
        getCommand("unban").setExecutor(new Unban());
        getCommand("tp").setExecutor(new Teleport());
        getCommand("cc").setExecutor(new ClearChat());
        getCommand("s").setExecutor(new S());
        getCommand("kill").setExecutor(new Kill());
        getCommand("suicide").setExecutor(new Kill());
        getCommand("mute").setExecutor(new Mute());
        getCommand("unmute").setExecutor(new Mute());
        Bukkit.getPluginManager().registerEvents(new Mute(), this);
    }
}

 

The problem is here:

Code:java

 
getCommand("mute").setExecutor(new Mute());
getCommand("unmute").setExecutor(new Mute());
Bukkit.getPluginManager().registerEvents(new Mute(), this);
 

Doing "new Mute()", as you hopefully know, creates a new instance of the Mute class. You are doing that three times here, so you are creating three different instances of Mute for each purpose. What that means is that, when you /mute someone, their name gets added to the HashMap that exists inside the first instance, but the event listener is the third instance and has its own hashmap, so it will never see any muted players.

Solution:

Code:java

 
Mute mute = new Mute();
getCommand("mute").setExecutor(mute);
getCommand("unmute").setExecutor(mute);
Bukkit.getPluginManager().registerEvents(mute, this);