removePotionEffect HELP!

hello i have maked a plugin that gives you speed but now i want to left click and remove the effect but it doesnt work please help me!
this is my code:

Code:java

package me.Matthijs.speedbone;
 
import java.util.ArrayList;
import java.util.List;
import java.util.logging.Logger;
 
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.ItemMeta;
import org.bukkit.plugin.PluginDescriptionFile;
import org.bukkit.plugin.PluginManager;
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.potion.PotionEffect;
import org.bukkit.potion.PotionEffectType;
 
public class SpeedBone extends JavaPlugin implements Listener{
    public final Logger logger = Logger.getLogger("Minecraft");
    public static SpeedBone plugin;
 
 
    @Override
    public void onEnable() {
        PluginDescriptionFile pdfFile = this.getDescription();
        this.logger.info(pdfFile.getName() + " V " + pdfFile.getVersion() + " [SpeedWand] Aan!");
        PluginManager pm = this.getServer().getPluginManager();
        getServer().getPluginManager().registerEvents(this, this);
        pm.addPermission(new Permissions().speedbone);
 
 
    }
 
    @Override
    public void onDisable() {
        PluginDescriptionFile pdfFile = this.getDescription();
        this.logger.info(pdfFile.getName() + " [SpeedBone] Uit!");
        getServer().getPluginManager().removePermission(new Permissions().speedbone);
    }
 
 
    public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args){
 
        if(commandLabel.equalsIgnoreCase("speedbone")){
            if(sender.hasPermission(new Permissions().speedbone)) {
                sender.sendMessage(ChatColor.RED + "Gebruikt!");
            } else{
                sender.sendMessage(ChatColor.RED + "Sorry maar dit kun jij niet doen!");
            }
            ItemStack speedbone = new ItemStack(Material.BONE, 1);
 
            ItemMeta im = speedbone.getItemMeta();
 
            im.setDisplayName(ChatColor.BLUE + "SpeedBone");
 
            List<String> lorelist = new ArrayList<String>();
            lorelist.add(ChatColor.DARK_RED + "Rechts klikken om speed te krijgen!");
            lorelist.add(ChatColor.DARK_RED + "Links klikken om speed te verwijderen");
            im.setLore(lorelist);
 
            speedbone.setItemMeta(im);
 
            Player player = (Player) sender;
 
            player.getInventory().addItem(speedbone);
        } else{
            if(commandLabel.equalsIgnoreCase("author")){
                Player player = (Player) sender;
                player.sendMessage(ChatColor.BLUE + "[url="http://www.youtube.com/onlydutchgamingnl"]www.youtube.com/onlydutchgamingnl[/url]");
            }
            return true;
        }
        return false;
    }
 
    @EventHandler
    public void onPlayerInteract(PlayerInteractEvent e){
        Player player = e.getPlayer();
 
        if(e.getAction() == Action.RIGHT_CLICK_AIR || e.getAction() == Action.RIGHT_CLICK_BLOCK) {
            if (player.getInventory().getItemInHand().getItemMeta().getDisplayName().equalsIgnoreCase("speedbone")) {
                player.addPotionEffect(new PotionEffect(PotionEffectType.SPEED, 100, 4));
                player.sendMessage(ChatColor.GOLD + "Je hebt nu Speed!");
 
            }
            if(e.getAction() == Action.LEFT_CLICK_AIR || e.getAction() == Action.LEFT_CLICK_BLOCK) {
                if (player.getInventory().getItemInHand().getItemMeta().getDisplayName().equalsIgnoreCase("speedbone")) {
                    player.removePotionEffect(PotionEffectType.SPEED);
                    player.sendMessage(ChatColor.GOLD + "Je bent nu je speed kwijt!");
    }
        }
 
 
 
 
 
        }
    }
}
 

 

You made the if leftClick statement inside of the right click statement, this way it will never excecute
move a closing bracket from under the leftclick statement above it.

 

? post the code please?

 

Schaakmatth
Follow the logic of your code. You placed the left click check in your right click check. Thus it will never run because it needs to pass the right click check first.
Put the check outside the block of the right click check.

 

im dutch and i can not speak really good ENGLISH SO PLEASE WRITE THE CODE!

 

I'm going to translate it now:
Kijk naar de logica van je code, je hebt je 'linker-klik' check in je 'rechter-klik' check gedaan. Op deze manier word de tweede check, dus die van de linker-klik, nooit uitgevoerd. Verplaats een } zodat je twee aparte 'blokken' hebt.

 

ok dankje maar ze doen het allebei niet als ik op me server kom en ik rechtsklik of linksklik er gebeurt niks? SuppaTim
hier is mijn nieuwe code

Code:java

    @EventHandler
    public void onPlayerInteract(PlayerInteractEvent e){
        Player player = e.getPlayer();
 
        if(e.getAction() == Action.RIGHT_CLICK_AIR || e.getAction() == Action.RIGHT_CLICK_BLOCK) {
            if (player.getInventory().getItemInHand().getItemMeta().getDisplayName().equalsIgnoreCase("speedbone")) {
                player.addPotionEffect(new PotionEffect(PotionEffectType.SPEED, 100, 3));
                player.sendMessage(ChatColor.GOLD + "Je hebt nu Speed!");
 
 
 
        if(e.getAction() == Action.LEFT_CLICK_AIR || e.getAction() == Action.LEFT_CLICK_BLOCK) {
            if (player.getInventory().getItemInHand().getItemMeta().getDisplayName().equalsIgnoreCase("speedbone")) {
                player.removePotionEffect(PotionEffectType.SPEED);
                player.sendMessage(ChatColor.GOLD + "Je hebt nu geen speed meer!");
 

 

You never closed the if statements, so the left click is still inside right click!

Code:java

 if(e.getAction() == Action.RIGHT_CLICK_AIR || e.getAction() == Action.RIGHT_CLICK_BLOCK) {
    if (player.getInventory().getItemInHand().getItemMeta().getDisplayName().equalsIgnoreCase("speedbone")) {
        player.addPotionEffect(new PotionEffect(PotionEffectType.SPEED, 100, 3));
        player.sendMessage(ChatColor.GOLD + "Je hebt nu Speed!");
    }
}
 
 
 
if(e.getAction() == Action.LEFT_CLICK_AIR || e.getAction() == Action.LEFT_CLICK_BLOCK) {
    if (player.getInventory().getItemInHand().getItemMeta().getDisplayName().equalsIgnoreCase("speedbone")) {
        player.removePotionEffect(PotionEffectType.SPEED);
        player.sendMessage(ChatColor.GOLD + "Je hebt nu geen speed meer!");
    }
}