Removing Items

Hello! So I need to remove items from a players inventory (ONLY 10) I have tried:
p.getInventory().remove(Material.DIAMOND, 10);
But I get this:
The method remove(int) in the type Inventory is not applicable for the arguments (Material, int)

Please help D: Any help appreciated!

 

Code:

if(p.getInventory().contains(new ItemStack(Material.DIAMOND, 10))){
    p.getInventory().remove(new ItemStack(Material.DIAMOND, 10));
}

 

TheMcScavenger
Thanks! Ill test it now and get back to you.

TheMcScavenger
It does not seem to be taking the diamonds from me :/

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Do you have the 10 diamonds in your inventory?

 

TheMcScavenger
Well I created a test for it and it passed so yep

 

PHP:

if (p.getItemInHand().getAmount() <= 1) {
  p.setItemInHand(null);
 } else {
  p.getItemInHand().setAmount(p.getItemInHand().getAmount() - 1);
 }

 

But that would only work, if the player hold diamonds in hand - not the solution CraftCreeper6 want, i think.

Can you show us your whole class please, CraftCreeper?

 

I know it does. I never said I will spoon feed him the whole code so I gave him a frame - he has to only
change few things.

 

How about:

Code:

if(p.getInventory().contains(Material.DIAMOND)){
    ItemStack[] inv = p.getInventory().getContents();
    for(ItemStack stack : inv){
        if(stack.getType().equals(Material.DIAMOND) && stack.getAmount() >= 10){
            if(stack.getAmount() > 10){
                stack.setAmount(stack.getAmount() - 10);
            }
            else if(stack.getAmount() == 10){
                p.getInventory().remove(stack);
            }
        }
    }
}

 

TheMcScavenger
This works perfectly, it takes the diamonds but every time I run the command now I get an Internal Error:
Stacktrace:
Caused by: java.lang.NullPointerException
at me.CraftCreeper6.All.Main.onCommand(Main.java:124) ~[?:?]
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:44) ~[cra
ftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
... 13 more

So of course it's a NullPointerExeption but how am I getting this? Line 124:
if(stack.getType().equals(Material.DIAMOND) && stack.getAmount() >= 10){

Any help appreciated

 

Try adding a null check:

Code:

if(p.getInventory().contains(Material.DIAMOND)){
    ItemStack[] inv = p.getInventory().getContents();
    for(ItemStack stack : inv){
        if(stack.getType() != null && stack.getType().equals(Material.DIAMOND) && stack.getAmount() >= 10){
            if(stack.getAmount() > 10){
                stack.setAmount(stack.getAmount() - 10);
            }
            else if(stack.getAmount() == 10){
                p.getInventory().remove(stack);
            }
        }
    }
}

 

TheMcScavenger
I am not sure why it is not working D:
But.. Could you possibly lead my through importing vault and taking money from accounts, that's if you know how of course. If not then maybe there is a thread that I cannot find? (I searched and searched...)

 

Don't forget to p.updateInventory()

 

MOMOTHEREAL
Don't think your getting it LOL
I am getting Internal Error for null even after updating it

 

Never needed it, don't need it now.

Hmmm, odd. I'll have another look at it later if nobody else can figure it out.