Scoreboard kills

Code:java

package me.wizard7611.TeamBattle;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.scoreboard.DisplaySlot;
import org.bukkit.scoreboard.Objective;
import org.bukkit.scoreboard.Score;
import org.bukkit.scoreboard.Scoreboard;
 
public class ScoreBoard extends JavaPlugin implements Listener{
 
    private Scoreboard board;
    private Objective o;
    private Score s;
 
    public void onEnable(){
        board = Bukkit.getServer().getScoreboardManager().getNewScoreboard();
 
        o = board.registerNewObjective("kills", null);
        o.setDisplayName("Kills");
        o.setDisplaySlot(DisplaySlot.SIDEBAR);
 
        s = o.getScore(Bukkit.getServer().getOfflinePlayer(ChatColor.GOLD + "Number: "));
    }
 
    @EventHandler
    public void onPlayerJoin(PlayerJoinEvent e){
        Player p = e.getPlayer();
 
        p.setScoreboard(board);
    }
}
 

I can't seem to know what would go next. I know it's something like

Code:java

public void onPlayer(something)

 

Why not just setting the player-kills as the criteria

Code:

Objective objective = board.registerNewObjective("test", "playerKillCount");

 

Do you want this to have all the players listed with the kills, or the players with the most scores displayed (easy)
Or do you want each player to have a unique scoreboard with the number of players they have killed (MUCH more complicated, but I have code that does almost exactly this that I can give you)

 

Quantum64 I just need the number of kills each play has gotten

my edited code:

Code:java

package me.wizard7611.TeamBattle;
 
import java.util.HashMap;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.OfflinePlayer;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.scoreboard.DisplaySlot;
import org.bukkit.scoreboard.Objective;
import org.bukkit.scoreboard.Score;
import org.bukkit.scoreboard.Scoreboard;
 
public class ScoreBoard extends JavaPlugin implements Listener{
 
    private Scoreboard board;
    private Objective o;
    private Score s;
    private HashMap<OfflinePlayer, Score> scores = new HashMap<OfflinePlayer, Score>();
 
    public void onEnable(){
        board = Bukkit.getServer().getScoreboardManager().getNewScoreboard();
 
        o = board.registerNewObjective("kills", null);
        o.setDisplayName("Kills");
        o.setDisplaySlot(DisplaySlot.SIDEBAR);
    }
 
    @EventHandler
    public void onPlayerJoin(PlayerJoinEvent e){
        Player p = e.getPlayer();
 
        p.setScoreboard(board);
 
        if (scores.get(p) == null) scores.put(p, o.getScore(Bukkit.getServer().getOfflinePlayer(ChatColor.GOLD + "Number:")));
    @EventHandler
    public void onPlayer-----------I'm still trying to find a value for this
    }
}

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

wizard7611
Use EntityDamageByEntityEvent and check if damage instanceof Player.

 

ok thanks

mattrick16 wait how should I code that?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Basically you are checking if the damager is a player them adding 1 to their kill count if the entity is a player and got killed.

 

couldnt you do a playerdeathevent and get the killer and add a kill to their score unless the killer is null? just a question

 

king_of_all96543 Idk that's why I'm here XD

 

wizard7611 Try what king_of_all96543 said.

 

Max_The_Link_Fan ok so this is what I have so far:

Code:java

package me.wizard7611.TeamBattle;
 
import java.util.HashMap;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.OfflinePlayer;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.PlayerDeathEvent;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.scoreboard.DisplaySlot;
import org.bukkit.scoreboard.Objective;
import org.bukkit.scoreboard.Score;
import org.bukkit.scoreboard.Scoreboard;
 
public class ScoreBoard extends JavaPlugin implements Listener{
 
    private Scoreboard board;
    private Objective o;
    private Score s;
    private HashMap<OfflinePlayer, Score> scores = new HashMap<OfflinePlayer, Score>();
 
    public void onEnable(){
        board = Bukkit.getServer().getScoreboardManager().getNewScoreboard();
 
        o = board.registerNewObjective("kills", null);
        o.setDisplayName("Kills");
        o.setDisplaySlot(DisplaySlot.SIDEBAR);
    }
 
    @EventHandler
    public void onPlayerDeath(PlayerDeathEvent e){
        Player p = e.getPlayer();
 
        p.setScoreboard(board);
 
        if (scores.get(p) == null) scores.put(p, o.getScore(Bukkit.getServer().getOfflinePlayer(ChatColor.GOLD + "Number:")));
    @EventHandler
    public void onEntityDamageBy(EntityEvent e);
    }
}

I'm really confused XD
I get errors at the

Code:java

e.getPlayer();

and also at the second public void since I don't know what that is supposed to be.

 

What errors? Null pointer?

 

Quantum64 I'm just confused what king_of_all96543 said

 

wizard7611 What's the error at e.getPlayer();

 

Max_The_Link_Fan it just says I need to change it because it's not recognized

 

I'm not sure why that is..

wizard7611 Change

Code:java

Player p = e.getPlayer();

to

Code:java

Player p = e.getEntity();

In your death event

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Max_The_Link_Fan yea but I still don't know what the second public void is in @EventHandler

 

wizard7611 What? What's the error?

 

Max_The_Link_Fan wizard7611
change

Code:

 @EventHandler
public void onEntityDamageBy(EntityEvent e);
}

to

Code:

 @EventHandler
public void onEntityDamageBy(EntityEvent e){
}

think that could be the problem

 

wizard7611 Change

Code:java

 @EventHandler
public void onEntityDamageBy(EntityEvent e){
}

to

Code:java

 @EventHandler
public void onEntityDamageBy(EntityDamageByEntityEvent e){
}

 

king_of_all96543 it says I have a syntax error on line 41 because I changed the syntax on line 43

see:

Code:java

package me.wizard7611.TeamBattle;
 
import java.util.HashMap;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.OfflinePlayer;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.EntityDamageByEntityEvent;
import org.bukkit.event.entity.EntityEvent;
import org.bukkit.event.entity.PlayerDeathEvent;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.scoreboard.DisplaySlot;
import org.bukkit.scoreboard.Objective;
import org.bukkit.scoreboard.Score;
import org.bukkit.scoreboard.Scoreboard;
 
public class ScoreBoard extends JavaPlugin implements Listener{
 
    private Scoreboard board;
    private Objective o;
    private Score s;
    private HashMap<OfflinePlayer, Score> scores = new HashMap<OfflinePlayer, Score>();
 
    public void onEnable(){
        board = Bukkit.getServer().getScoreboardManager().getNewScoreboard();
 
        o = board.registerNewObjective("kills", null);
        o.setDisplayName("Kills");
        o.setDisplaySlot(DisplaySlot.SIDEBAR);
    }
 
    @EventHandler
    public void onPlayerDeath(PlayerDeathEvent e){
        Player p = e.getEntity();
 
        p.setScoreboard(board);
 
        if (scores.get(p) == null) scores.put(p, o.getScore(Bukkit.getServer().getOfflinePlayer(ChatColor.GOLD + "Number:")));
    @EventHandler
    public void onEntityDamageBy(EntityDamageByEntityEvent e){
    }
}

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

wizard7611
There is no line 41.....

 

I mean line 42 and 44 sorry I forgot I imported it XD

 

sorry i dont know where the error would be i dont know much about scoreboards but i tried to help sorry

 

did you copy and paste it to see if you can fix it? All I have is a syntax error

 

wizard7611 not able to at the moment but i maybe able to try in a bit

 

king_of_all96543 k

 

wizard7611
If you make a completely different method for your scoreboard (not onEnable()), and register the objective as a playerKillCount rather than a null, and set the scoreboard for online players, you don't need to call it in any event.

Refer to the post at the top of the thread for more clarification on the objective registration. (Post is by 2016mfransen)