Scoreboards updating laggs server down

Hey, i have a really annoying problem...

I've made a plugin that shows the balance of the player in a scoreboard... Everything works except when i "pop" (how i call it) another player. Then i get an error in the console and the server would lagg out... The server is running on my own pc with 32 gb of ram... In the run.bat it is set to 2 gb... But when i look at the taskmanager while the server laggs out, 31,9 out of 32 gb of ram is used...

I can't seem to get this fixed...

Error:

Code:

org.bukkit.event.EventException
    at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:294) ~[craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
    at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
    at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:501) [craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
    at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:486) [craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
    at org.bukkit.craftbukkit.v1_7_R3.event.CraftEventFactory.callEvent(CraftEventFactory.java:98) [craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
    at org.bukkit.craftbukkit.v1_7_R3.event.CraftEventFactory.callEntityDamageEvent(CraftEventFactory.java:407) [craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
    at org.bukkit.craftbukkit.v1_7_R3.event.CraftEventFactory.handleEntityDamageEvent(CraftEventFactory.java:434) [craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
    at net.minecraft.server.v1_7_R3.EntityLiving.damageEntity(EntityLiving.java:658) [craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
    at net.minecraft.server.v1_7_R3.EntityHuman.damageEntity(EntityHuman.java:746) [craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
    at net.minecraft.server.v1_7_R3.EntityPlayer.damageEntity(EntityPlayer.java:452) [craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
    at net.minecraft.server.v1_7_R3.EntityArrow.h(EntityArrow.java:231) [craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
    at net.minecraft.server.v1_7_R3.World.entityJoinedWorld(World.java:1421) [craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
    at net.minecraft.server.v1_7_R3.World.playerJoinedWorld(World.java:1402) [craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
    at net.minecraft.server.v1_7_R3.World.tickEntities(World.java:1290) [craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
    at net.minecraft.server.v1_7_R3.WorldServer.tickEntities(WorldServer.java:481) [craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
    at net.minecraft.server.v1_7_R3.MinecraftServer.v(MinecraftServer.java:649) [craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
    at net.minecraft.server.v1_7_R3.DedicatedServer.v(DedicatedServer.java:260) [craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
    at net.minecraft.server.v1_7_R3.MinecraftServer.u(MinecraftServer.java:558) [craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
    at net.minecraft.server.v1_7_R3.MinecraftServer.run(MinecraftServer.java:469) [craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
    at net.minecraft.server.v1_7_R3.ThreadServerApplication.run(SourceFile:628) [craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
Caused by: java.lang.NullPointerException
    at com.zandor300.hubessentials.utils.CustomScoreboard.updateScoreboard(CustomScoreboard.java:80) ~[?:?]
    at com.zandor300.hubessentials.listeners.players.PlayerAttack.onPlayerAttack(PlayerAttack.java:57) ~[?:?]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_11]
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_11]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_11]
    at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_11]
    at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:292) ~[craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
    ... 19 more

CustomScoreboard class: http://pastebin.com/60qQ4ZuV
Crystal class: http://pastebin.com/6mVBpxvL
onPlayerAttack:

Code:java

    @EventHandler
    public void onPlayerAttack(EntityDamageByEntityEvent event) {
        if (!(event.getEntity() instanceof Player)) {
            event.setCancelled(true);
            return;
        }
        Player player = (Player) event.getEntity();
 
        if (event.getDamager() instanceof Arrow) {
            final Arrow arrow = (Arrow) event.getDamager();
            if (!(arrow.getShooter() instanceof Player))
                return;
            Player damager = (Player) arrow.getShooter();
 
            if (PvP.getPvP(player))
                return;
            if (PvP.getPvP(damager))
                return;
            if (!damager.canSee(player))
                return;
 
            damager.hidePlayer(player);
            Popper.getPop(damager).addScore(1);
            for (CustomScoreboard scoreboard : CustomScoreboard
                    .getAllScoreboards())
                scoreboard.updateScoreboard();
            player.playSound(player.getLocation(), Sound.ITEM_PICKUP, 1, 1);
 
            arrow.remove();
 
            Firework firework = (Firework) player.getWorld().spawn(
                    player.getLocation(), Firework.class);
            FireworkMeta fireworkMeta = firework.getFireworkMeta();
            fireworkMeta.addEffect(FireworkEffect.builder().flicker(false)
                    .trail(false).with(Type.BALL).withColor(Color.AQUA)
                    .withFade(Color.BLUE).build());
            fireworkMeta.setPower(0);
            firework.setFireworkMeta(fireworkMeta);
 
            damager.setLevel(Popper.getPop(damager).getScore());
 
        } else if (PvP.getPvP(player) == false) {
            event.setCancelled(true);
            return;
        }
    }

I hope someone can help me...

-Zandor300

 

This is a null pointer exception meaning a variable is null,specifically in scoreboard class line 80

Also why so many statics? And yes probably itis the get crystal returning null use debug code and print out variables to see what is null and why

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

I know what is wrong but i dont know how to fix.
But it does print the scoreboard with the balance...

 

Weird, have u tried the debug for alllll variables?

PS OMG that's a kick backside pc! Are you even maxing it out ever?
I have a amd fx8350 overclocked to 4.8 ghz 16 gb ram 2gb gpu (asus 7770 I belive) so untill now I'm 1/2 of your pc but I beat u on storage 3x2tb hdd's and a 240gb ssd with the os also have u overclocked? In my case it "busts into Flames" when used too much! I need to get to water cooling,
PPS I like ur profile photo

 

Not all but most of it... Gonna debug them all in a hour... Ill get back to you with the results if i still cant fix it...

When i play watchdogs my pc is very loud... But i dont use watercooling eather lolz

I've made a command with this code:

Code:java

 sender.sendMessage("getCrystal(): "
+ Crystal.getCrystal(args.getString(0)).toString());
sender.sendMessage("getPlayer().getName(): "
+ Crystal.getCrystal(args.getString(0)).getPlayer().getName());
sender.sendMessage("getBlance(): "
+ Crystal.getCrystal(args.getString(0)).getBalance());

Output:

Code:

[19:07:51] [Server thread/INFO]: getCrystal(): com.zandor300.core.enums.Crystal@5cdfe82b
[19:07:51] [Server thread/INFO]: getPlayer().getName(): Zandor300
[19:07:51] [Server thread/INFO]: getBlance(): 30

And that are all the variables in Crystal.class

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

That's odd :-( I can't see what's wrong, when I get to my pc (~4 days) ill check it out codewise

 

But there aren't any errors when a player joins becouse that's when i instanciate a new Crystal();

 

Ok, just to be sure I understand right, can you please give me a brief explanation of what this minigames it's about? What you wana do? What's crystals? You can also start a conversation with mew if you like it more

 

Zandor300
make sure you only call the scoreboardmanager after the onEnable() in the main has been called... otherwise it can cause exceptions

 

Then why is this guy creating the scoreboard inside the onEnable() method?

 

Zandor300
You can but if you do it at the beginning of the main class you can you will get an exception

 

But i'm calling it when a player joins so that souldn't be the problem...

Cycryl mine-care Still no suggestions? I'm pretty sure now, the problem is Crystal.class but i don't know why...

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Zandor300

Because, frankly, that guy is not only not qualified to program and certainly not qualified to teach others, but his is also a moron.

That being said, there really isn't any reason why you can't create a scoreboard in onEnable(), other than you won't have any players to show it to.

And seriously, we mean it, stop abusing statics.

 

mythbusterma
Since I am capable of using reflection and Packets in my plugins as well as the Bukkit API i wouldn't consider myself a bad coder.
In case I wasn't clear again:
YOU CANNOT INITIALIZE A SCOREBOARD BEFORE THE ONENABLE HAS BEEN CALLED.
so you can initialize it in the onenable, bu NOT before that. Got it? nice.

Zandor300
now to you Zandor: Since the error occurred on line 80 of your Custom scoreboard you should check that line.
It calls Crystal.getCrystal(player).getBalance();
wich means that Crystal.getCrystal(player) must return null

maybe try this:

Code:java

 
public static Crystal getCrystal(String player) {
 
30.
                for (Crystal crystal : allCrystals)
 
31.
                        if (crystal.getPlayer().getName()==player)
 
32.
                                return crystal;
 
33.
                return null;
 
34.
        }
 

 

I do it in my onEnable becouse when i just /reload it just shows it to the players allready in the server...

What is a better way?

I'm not even doing that...

Doesn't change anything:

Code:

Caused by: java.lang.NullPointerException
    at com.zandor300.hubessentials.utils.CustomScoreboard.updateScoreboard(CustomScoreboard.java:80) ~[?:?]
    at com.zandor300.hubessentials.listeners.players.PlayerAttack.onPlayerAttack(PlayerAttack.java:57) ~[?:?]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_11]
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_11]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_11]
    at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_11]
    at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:292)
    ... 20 more

 

Zandor300
1. The Thing with the onenable was just there to tell mythbusterma what I meant. Your way of doing it is perfectly fine.
2. Are you sure that the ArrayList<Crystel> contains the player?
i am pretty sure ist not. Then the method Returns null and you get an exception.
so make sure to put the player's Crystal in the ArrayList.

 

Just because you know some tricks doesn't mean you can't be a bad programmer

Your argument is invalid as it can be. The ScoreboardManager is available after the first world has been loaded. If you aren't loading your plugin at STARTUP, it's perfectly fine to get it in the class body (though when you want to switch later, it's recommended to do it a tick after (or a 0 delay scheduled task) the onEnable was called). So either way, wrong :3

Pass a main class reference through the constructor to both the scoreboard updater and Crystal, store their instance in the main class and add some getters. This way, from your updater class, you should be able to do something among the lines of

Code:java

Crystal = this.main.getCrystal().getCrystal(player)

Also, if you reload, you should create new Crystal objects for every player that is online at the time of onEnable.

 

Cycryl

I wasn't saying that about you, I was saying that about the video he linked (BCBlowz). Attacking other members of the forums like that is something I don't do.

That being said, there's barely any reason to use reflection and introspection in Bukkit, instead you could try using an interface and different implementations in different Maven modules, as is the case with TagAPI and DhUtils.

 

I don't know what you want to do with that... nvm But i think that will look odd...

And i was already doing that at onEnable...