Set custom display name as Health?

How would I set a custom display name as health and update it everytime the entity/player gets damaged?

I'v tried this:

Code:java

pig.setCustomName("Health: " + pig.getHealth());

I knew it wouldn't work because I needed to take a -1 everytime it got hit.


Any ideas?

 

shohouku Inside the EntityDamageEvent, check if the entity is one of the entities you want to display health for. Then, you can call the setCustomName() in there. You might need to do getHealth() - event.getDamage()

 

This is my full code:

Code:java

@EventHandler
    public void onEntityDamage(EntityDamageEvent e) {
        e.getEntityType();
        final Pig pig = (Pig)e.getEntity();
        if(e.getEntity() instanceof Pig) {
            if(pig.getCustomName().equalsIgnoreCase("Health: " + pig.getHealth())) {
                pig.setCustomName("Stupid Pig [Lvl ??]");
                    if(pig.getCustomName().equalsIgnoreCase("Stupid Pig [Lvl ??]")) {
 
 
                    pig.setCustomName("Health: " + pig.getHealth());
                    }
                }
 
 
 
        }
 
    }

 

Well, it looks like your code got a bit mixed up.

Line 3 of your code does nothing.
In line 4 you cast to a pig without checking if it actually is one beofre
In line 5 you check if it is a Pig - that should be before the cast
The check in line 6 will most likely be false, since the health is now lower than when you set the display name - use .startsWith or similar instead
line 8 will always be true, since you set the exact name you check for in the line before. I assume you are missing some closing brackets there.

Try cleaning and organising that code - this way it will never work.

 

Okay, I updated my code:

.setCustomName doesn't get updated. Events are all registered and I have listeners.

Code:java

    @EventHandler
        public void damaged(EntityDamageEvent devent){
                Damageable ddent = (Damageable)devent.getEntity();
                LivingEntity dlent = (LivingEntity)devent.getEntity();
                if(ddent.getHealth() <  ddent.getMaxHealth()){
                    String name = dlent.getCustomName();
                    int percent = (int) (dlent.getMaxHealth()/100 * dlent.getHealth());
                    if(percent >=99){
                        if(dlent.hasMetadata(name)){
                            String named = dlent.getCustomName();
                            dlent.setCustomName(named);
                        }
                    }
                    if(percent >= 90 && percent < 99){
                        dlent.setCustomName(ChatColor.GREEN + "|||||||||" + ChatColor.GRAY + "|");
                        dlent.setCustomNameVisible(true);
                    }
                    if(percent >= 80 && percent < 90){
                        dlent.setCustomName(ChatColor.GREEN + "||||||||" + ChatColor.GRAY + "||");
                        dlent.setCustomNameVisible(true);
                    }
                    if(percent >= 70 && percent < 80){
                        dlent.setCustomName(ChatColor.GREEN + "|||||||" + ChatColor.GRAY + "|||");
                        dlent.setCustomNameVisible(true);
                    }
                    if(percent >= 60 && percent < 70){
                        dlent.setCustomName(ChatColor.YELLOW + "||||||" + ChatColor.GRAY + "||||");
                        dlent.setCustomNameVisible(true);
                    }
                    if(percent >= 50 && percent < 60){
                        dlent.setCustomName(ChatColor.YELLOW + "|||||" + ChatColor.GRAY + "|||||");
                        dlent.setCustomNameVisible(true);
                    }
                    if(percent >= 40 && percent < 50){
                        dlent.setCustomName(ChatColor.YELLOW + "||||" + ChatColor.GRAY + "||||||");
                        dlent.setCustomNameVisible(true);
                    }
                    if(percent >= 30 && percent < 40){
                        dlent.setCustomName(ChatColor.RED + "|||" + ChatColor.GRAY + "|||||||");
                        dlent.setCustomNameVisible(true);
                    }
                    if(percent >= 20 && percent < 30){
                        dlent.setCustomName(ChatColor.RED + "||" + ChatColor.GRAY + "||||||||");
                        dlent.setCustomNameVisible(true);
                    }
                    if(percent >= 10 && percent < 20){
                        dlent.setCustomName(ChatColor.RED + "|" + ChatColor.GRAY + "||||||||");
                        dlent.setCustomNameVisible(true);
                    }
 
                }
                }
 

 

First Thing I noticed is your percentage calculation is wrong:

• 
  
  int percent = (int) (100/dlent.getMaxHealth() * dlent.getHealth());
  
  
  
  

 

Thought so I was getting errors on it...

Any other way how to use another calculation that will actual work? o.o

 

I already fixed it... compare yours with the one I postet.

 

oh oops didn't see haha,

anyways I don't get an error anymore but the custom names aren't showing up.

Could it still be the percent?

 

I did 2 or 3 small changes. Now I think the code should run, although I haven't testet it myself.

If it still doesn't work - do you register your listener propperly? is the plugin enabled?

Code:java

public class Main
{
    @EventHandler
    public void damaged(EntityDamageEvent event)
    {
        if (event.getEntity() instanceof LivingEntity)
        {
            LivingEntity ent = (LivingEntity) event.getEntity();
 
            if (ent.getHealth() < ent.getMaxHealth())
            {
                String name = ent.getCustomName();
                int percent = (int) (100 / ent.getMaxHealth() * ent.getHealth());
 
                if (percent >= 99)
                {
                    //Not sure what this is supposed to do - just get the name and set it again?
                    //Then you can just remove it.
                    if (ent.hasMetadata(name))
                    {
                        String named = ent.getCustomName();
                        ent.setCustomName(named);
                    }
                }
                if (percent >= 90 && percent < 99)
                {
                    ent.setCustomName(ChatColor.GREEN + "|||||||||" + ChatColor.GRAY + "|");
                    ent.setCustomNameVisible(true);
                }
                if (percent >= 80 && percent < 90)
                {
                    ent.setCustomName(ChatColor.GREEN + "||||||||" + ChatColor.GRAY + "||");
                    ent.setCustomNameVisible(true);
                }
                if (percent >= 70 && percent < 80)
                {
                    ent.setCustomName(ChatColor.GREEN + "|||||||" + ChatColor.GRAY + "|||");
                    ent.setCustomNameVisible(true);
                }
                if (percent >= 60 && percent < 70)
                {
                    ent.setCustomName(ChatColor.YELLOW + "||||||" + ChatColor.GRAY + "||||");
                    ent.setCustomNameVisible(true);
                }
                if (percent >= 50 && percent < 60)
                {
                    ent.setCustomName(ChatColor.YELLOW + "|||||" + ChatColor.GRAY + "|||||");
                    ent.setCustomNameVisible(true);
                }
                if (percent >= 40 && percent < 50)
                {
                    ent.setCustomName(ChatColor.YELLOW + "||||" + ChatColor.GRAY + "||||||");
                    ent.setCustomNameVisible(true);
                }
                if (percent >= 30 && percent < 40)
                {
                    ent.setCustomName(ChatColor.RED + "|||" + ChatColor.GRAY + "|||||||");
                    ent.setCustomNameVisible(true);
                }
                if (percent >= 20 && percent < 30)
                {
                    ent.setCustomName(ChatColor.RED + "||" + ChatColor.GRAY + "||||||||");
                    ent.setCustomNameVisible(true);
                }
                if (percent >= 10 && percent < 20)
                {
                    ent.setCustomName(ChatColor.RED + "|" + ChatColor.GRAY + "||||||||");
                    ent.setCustomNameVisible(true);
                }
            }
        }
    }

 

It works but the name doesn't get set when I hit the entity more then 5+ times?w

 

What's the last "name" that shows on your entity?

 

Nvm i was setting an entities health in my other class to 5000D

Ill check if it works now, ill notify you if it doesn't work

@minoneer

Okay, this code isn't working very well..

Do I have to use a scheduler for this?

Code:java

 if (ent.hasMetadata(name))
                    {
                        String named = ent.getCustomName();
                        ent.setCustomName(named);
                    }

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

No, you don't need to use the scheduler. What are you trying to do with that code? Right now it isn't doing anything.

 

Code:java

StringBuilder builder = new StringBuilder(); //create a string builder
for(int i = 0; i < pig.geatHealth(); i++) //loop for each health point
    builder.append(" |"); //append a pipe symbol
 
String name = builder.toString().trim(); //trim to get rid of possible white space from the first iteration of the loop

If statement spam is never healthy